Re: [PATCH 0/2] eeepc-laptop: add 3G rfkill support for 901Go

[Corentin Chary <corentin.chary@gmail.com>]

On Sat, Jun 13, 2009 at 1:06 PM, Janne Grunau<j@jannau.net> wrote:
> On Sat, Jun 13, 2009 at 08:52:17AM +0200, Corentin Chary wrote:
>> First,
>> Could you fill http://dev.iksaif.net/projects/acpi4asus/wiki/CMSG with
>> your model CMSG ?
>
> done, I suspect there's an error for the 701 and 901 in that table.
> CM_ASL_CARDREADER should be 1 instead of CM_ASL_MODEM.
> http://wiki.debian.org/DebianEeePC/Models supports that.

I'll check that, thanks

> Do you plan to update eeepc-laptop with all CM_ASL bits?

All CM_ASL bits found in latest asus_acpi driver, yep.

>> Then, I was working on a patch to refactor rfkill code in
>> eeepc-laptop. With this patch, adding 3g rfkill
>> is only 15-20 lines.
>
> good, I was too lazy to refactor it.
>
>> I'll add it to acpi4asus git tree soon.
>> From here:
>>  - I can rework your patch
>> - you can re-send it when rfkill refactoring is here.
>>
>> as you want =).
>
> Drop me a mail when you're done but doesn't really matter who does it.

Ok


-- 
Corentin Chary
http://xf.iksaif.net - http://uffs.org