From: Johannes Berg <johannes@sipsolutions.net>
To: Sasha Levin <sashal@kernel.org>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: syzbot+7e59a5bfc7a897247e18@syzkaller.appspotmail.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 4.14] wifi: cfg80211: lock wiphy mutex for rfkill poll
Date: Mon, 04 Dec 2023 21:50:29 +0100 [thread overview]
Message-ID: <71d0f8424661b0d7b2c371e422416854790e477a.camel@sipsolutions.net> (raw)
In-Reply-To: <20231204203735.2095033-1-sashal@kernel.org>
On Mon, 2023-12-04 at 15:37 -0500, Sasha Levin wrote:
>
> +++ b/net/wireless/core.c
> @@ -202,7 +202,9 @@ static void cfg80211_rfkill_poll(struct rfkill *rfkill, void *data)
> {
> struct cfg80211_registered_device *rdev = data;
>
> + wiphy_lock(&rdev->wiphy);
This can't even _build_ on this old kernel?!
Anyway, my locking rework only went into 6.7, so this doesn't make sense
in any stable kernel, it's just not required.
johannes
prev parent reply other threads:[~2023-12-04 20:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 20:37 Sasha Levin
2023-12-04 20:50 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71d0f8424661b0d7b2c371e422416854790e477a.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=syzbot+7e59a5bfc7a897247e18@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®