mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Matt Turner <mattst88@gmail.com>
Cc: Richard Henderson <richard.henderson@linaro.org>,
	Magnus Lindholm <linmag7@gmail.com>,
	linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v2 6/7] hwmon: Add driver for Marvel AlphaServer environmental sensors
Date: Tue, 17 Nov 2026 08:13:03 -0800	[thread overview]
Message-ID: <71d115df-0380-4724-8cc1-ca7da0aa5fc4@roeck-us.net> (raw)
In-Reply-To: <20261116-marvel-env-v2-6-ef614eb2e7f1@gmail.com>

On Mon, Nov 16, 2026 at 09:59:13PM -0500, Matt Turner wrote:
> The management firmware of the Marvel (EV7) AlphaServers, the GS1280,
> ES80 and ES47, monitors temperatures, fans, voltages and power supplies.
> The SRM console describes each sensor as a packet in a power and
> environment node of its config tree (GCT), and fills in the readings
> when asked to refresh the node. The packet layout was taken from Tru64
> UNIX.
> 
> The firmware gives each temperature, fan and voltage sensor a warning
> limit and a failure limit, and reports the sensor in the warning or
> failure state once its reading reaches one. Neither state means that the
> sensor is broken: a temperature past its failure limit is too high, not
> faulty. Power supplies are either working or failed, with the cause
> (AC, POK, overtemperature, fan) logged by the firmware.
> 
> Export the sensors through hwmon. A temperature's warning and failure
> limits become max and crit, with max_alarm set in either state and
> crit_alarm in the failure state. A fan's warning limit becomes min, with
> min_alarm set in either state and fault in the failure state, which is
> when the firmware counts the fan as failed. A voltage exports its
> reading, with min_alarm or max_alarm set in either state and lcrit_alarm
> or crit_alarm in the failure state, depending on which side of its
> nominal voltage it reads. The console gives the nominal voltage and only
> one other limit, so the voltage limits are not exported. A power supply
> is a voltage channel with only a fault attribute.
> 
> A refresh keeps the boot CPU in the console with interrupts disabled for
> up to 300 ms per node, so refresh a node at most once per
> update_interval. The hwmon core serializes the callbacks, which also
> serializes the refreshes.

This is not how the update_interval is supposed to be used. update_interval
is expected to be programmed into the chip.

Soft intervals should be hard-coded.

Thanks,
Guenter

  parent reply	other threads:[~2026-11-17 16:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  2:59 [PATCH v2 0/7] alpha: marvel: " Matt Turner
2026-11-17  2:59 ` [PATCH v2 1/7] alpha: marvel: fix the environmental subpacket layout Matt Turner
2026-11-17 11:08   ` Magnus Lindholm
2026-11-17  2:59 ` [PATCH v2 2/7] alpha: marvel: report environmental events without VERBOSE_MCHECK Matt Turner
2026-11-17 11:10   ` Magnus Lindholm
2026-11-17  2:59 ` [PATCH v2 3/7] alpha: marvel: refresh environmental readings through the console Matt Turner
2026-11-17 11:17   ` Magnus Lindholm
2026-11-17  2:59 ` [PATCH v2 4/7] alpha: marvel: notify environmental events Matt Turner
2026-11-17 11:10   ` Magnus Lindholm
2026-11-17  2:59 ` [PATCH v2 5/7] alpha: marvel: register a platform device for the environmental sensors Matt Turner
2026-11-17 11:11   ` Magnus Lindholm
2026-11-17  2:59 ` [PATCH v2 6/7] hwmon: Add driver for Marvel AlphaServer " Matt Turner
2026-11-17 11:27   ` Magnus Lindholm
2026-11-17 16:13   ` Guenter Roeck [this message]
2026-11-17  2:59 ` [PATCH v2 7/7] hwmon: (marvel-env) Notify userspace of environmental events Matt Turner
2026-11-17 11:30   ` Magnus Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71d115df-0380-4724-8cc1-ca7da0aa5fc4@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=linmag7@gmail.com \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mattst88@gmail.com \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®