From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Colin King <colin.king@canonical.com>,
Kristoffer Ericson <kristoffer.ericson@gmail.com>,
<linux-fbdev@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] video: fbdev: add missing \n at end of printk error message
Date: Tue, 27 Sep 2016 11:08:45 +0300 [thread overview]
Message-ID: <71d17288-3772-44ae-46fb-024ce9972bd3@ti.com> (raw)
In-Reply-To: <20160912102421.25926-1-colin.king@canonical.com>
[-- Attachment #1.1: Type: text/plain, Size: 894 bytes --]
On 12/09/16 13:24, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The message is missing a \n, add it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/video/fbdev/s1d13xxxfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/s1d13xxxfb.c b/drivers/video/fbdev/s1d13xxxfb.c
> index 96aa46d..6a271d8 100644
> --- a/drivers/video/fbdev/s1d13xxxfb.c
> +++ b/drivers/video/fbdev/s1d13xxxfb.c
> @@ -929,7 +929,7 @@ static int s1d13xxxfb_suspend(struct platform_device *dev, pm_message_t state)
> s1dfb->disp_save = kmalloc(info->fix.smem_len, GFP_KERNEL);
>
> if (!s1dfb->disp_save) {
> - printk(KERN_ERR PFX "no memory to save screen");
> + printk(KERN_ERR PFX "no memory to save screen\n");
> return -ENOMEM;
> }
>
>
Thanks, queued for 4.9.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-09-27 8:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 10:24 Colin King
2016-09-27 8:08 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71d17288-3772-44ae-46fb-024ce9972bd3@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=colin.king@canonical.com \
--cc=kristoffer.ericson@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®