Re: [PATCH] lib/raid6: Add AVX2 optimized recovery functions

["H. Peter Anvin" <hpa@zytor.com>]

Yes, consider it an implicit Acked-by.

NeilBrown <neilb@suse.de> wrote:

>On Fri, 09 Nov 2012 12:39:05 +0100 "H. Peter Anvin" <hpa@zytor.com>
>wrote:
>
>> Sorry, we cannot share those at this time since the hardwarenis not
>yet released.
>
>Can I take that to imply "Acked-by: "H. Peter Anvin" <hpa@zytor.com>"
>??
>
>It would be nice to have at least a statement like:
>These patches have been tested both with the user-space testing tool
>and in 
>a RAID6 md array and the pass all test.  While we cannot release
>performance
>numbers as the hardwere is not released, we can confirm that on that
>hardware
> the performance with these patches is faster than without.
>
>I guess I should be able to assume that - surely the patches would not
>be
>posted if it were not true...  But I like to avoid assuming when I can.
>
>Thanks,
>NeilBrown
>
>
>> 
>> Paul Menzel <pm.debian@googlemail.com> wrote:
>> 
>> >Dear Jim,
>> >
>> >
>> >Am Donnerstag, den 08.11.2012, 13:47 -0800 schrieb Jim Kukunas:
>> >> Optimize RAID6 recovery functions to take advantage of
>> >> the 256-bit YMM integer instructions introduced in AVX2.
>> >
>> >in my experiencing optimizations always have to be back up by
>> >benchmarks. Could you add those to the commit message please.
>> >
>> >> Signed-off-by: Jim Kukunas <james.t.kukunas@linux.intel.com>
>> >
>> >[…]
>> >
>> >
>> >Thanks,
>> >
>> >Paul
>> 

-- 
Sent from my mobile phone. Please excuse brevity and lack of formatting.