From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1B01C3DA79 for ; Thu, 29 Dec 2022 10:45:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232731AbiL2Kp4 (ORCPT ); Thu, 29 Dec 2022 05:45:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229919AbiL2Kpx (ORCPT ); Thu, 29 Dec 2022 05:45:53 -0500 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 440191274B for ; Thu, 29 Dec 2022 02:45:52 -0800 (PST) Received: by mail-lf1-x12e.google.com with SMTP id m6so16622346lfj.11 for ; Thu, 29 Dec 2022 02:45:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NTIWrY/I9iznPzbsuEZTHxW4AmSb2jAgZYmVDCvvcHM=; b=Swr2zkRQfivt3MiiJUmjule/G9pOEKThwbZllV8yDBQBXo4zhD31f29Fbj0LTKCY6S CCluJMmtMso7KZfL6YeXrRSI8FDe8wkw4yX92GhVr/Ra4IpfnlPncfbQVzQSgPPVfuCx 9RI989CoIPlGdq9D9JArkAAiIaZvnJoqOQnxGNrKTGa4/dZXu2xHWPfGTcdYiiVwUrOq +Uztn+lfWQJPWdqXJENG91hXcmtGPuv7XfgD/197l2OtCCu1J5dwUd2GRphD7bjyam2e g+sCkqHY8NCJII82cLViYjhLdyouAXHj70KFrqb/JikO9sKasdqrBOHOFJQ33Xc872E/ tqOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NTIWrY/I9iznPzbsuEZTHxW4AmSb2jAgZYmVDCvvcHM=; b=Muwe1S8/TGUCXcaM4RibuYXe3xvK7uA8dCHHsNS/yXN5pSBH0ZFDWWgFvQiOafPInH KgooCPc7r4rbaHURzGg3MweEka2KcbguB9LUryFuXFE1C+h+RjX5LM7lf7z9oWb2fF5L 1xXd+hrwIaOXwNJV7Tbp3oHiiqln5xBCrljCNguEfSSP31nfwbTHzis1b+q1fKx714cf IemMbFHR69//EF3mMSOJZJMxDNcElUS9HNT8PZ67EEwa4HhZ1hlWHQl8W9m2YEtrdpbE ru2Z9YL8AixTPIibw60zlLLOCQFOhEMBk9V7FoZT2OZTrnOcgP5o+ijPk8y5n1MVm/lf 9ASA== X-Gm-Message-State: AFqh2krGp1Xm39Q2UZRKvbffvcJaOdE+2FyW0ufJSQAjps90uxGRFPPF 3tPBw4d5RH9NFqs9p2FjqawXDQ== X-Google-Smtp-Source: AMrXdXtRTwT3Y1PV0nYirk3i9PKbnQoJFfVhyUcj6OWn5YAfUdVHJnWQd3FNE+qq0i8vDTRYgSl9qg== X-Received: by 2002:a05:6512:340d:b0:4b6:ec96:bb9a with SMTP id i13-20020a056512340d00b004b6ec96bb9amr10753400lfr.60.1672310750662; Thu, 29 Dec 2022 02:45:50 -0800 (PST) Received: from [192.168.1.101] (abyl184.neoplus.adsl.tpnet.pl. [83.9.31.184]) by smtp.gmail.com with ESMTPSA id u20-20020a05651220d400b004949f7cbb6esm3023225lfr.79.2022.12.29.02.45.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Dec 2022 02:45:50 -0800 (PST) Message-ID: <71d7a162-569d-1443-9e53-3ba374d06ccd@linaro.org> Date: Thu, 29 Dec 2022 11:45:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 1/7] arm64: dts: qcom: sm8450: add spmi node Content-Language: en-US To: Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, andersson@kernel.org, agross@kernel.org Cc: marijn.suijten@somainline.org, Vinod Koul , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221229103212.984324-1-konrad.dybcio@linaro.org> <7b32e414-96a9-7265-efee-f872badb32b2@linaro.org> From: Konrad Dybcio In-Reply-To: <7b32e414-96a9-7265-efee-f872badb32b2@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29.12.2022 11:42, Krzysztof Kozlowski wrote: > On 29/12/2022 11:32, Konrad Dybcio wrote: >> From: Vinod Koul >> >> Add the spmi bus as found in the SM8450 SoC >> >> Signed-off-by: Vinod Koul >> Reviewed-by: Konrad Dybcio >> [Konrad: 0x0 -> 0, move #cells down, make reg-names a vertical list] >> Signed-off-by: Konrad Dybcio >> --- >> v1 -> v2: >> No changes >> >> arch/arm64/boot/dts/qcom/sm8450.dtsi | 22 ++++++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi >> index 570475040d95..b9b59c5223eb 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi >> @@ -2715,6 +2715,28 @@ aoss_qmp: power-controller@c300000 { >> #clock-cells = <0>; >> }; >> >> + spmi_bus: spmi@c42d000 { > > Hmm looks different than reg. > >> + compatible = "qcom,spmi-pmic-arb"; >> + reg = <0 0x0c400000 0 0x00003000>, >> + <0 0x0c500000 0 0x00400000>, >> + <0 0x0c440000 0 0x00080000>, >> + <0 0x0c4c0000 0 0x00010000>, >> + <0 0x0c42d000 0 0x00010000>; > x Hm, my guess would be that Vinod chose to put the "cnfg" reg instead of "core" in the unit address, as 8450 has 2 SPMI bus hosts and they both share the core reg, so it would have been impossible to have two spmi@core nodes.. Konrad > > Best regards, > Krzysztof >