From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 840CD84A4F; Fri, 12 Apr 2024 15:56:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712937418; cv=none; b=eG2Nb47gLoa+Z61XVEmjeQxmPHCr5MJQkLMrG/luCMsZEMaX3Q7qK+e20y89RhSEvFsy0Frq5oBMRbjY16QoycPjP4iaHTIOUjrmFZNN1ilc6oe8bqlKxap11tnHw9U4F9g4Cd7XpXzHmKU9OBWbFOQepCmc3EdnQX3QAG9+nIQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712937418; c=relaxed/simple; bh=cV/yNRtWyjR/V9qoznur2BTJZZ0nkpdDkONIGztzVs0=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=rrZIzx0dx09pKXWUVDkZnX7C/1bHJRpMEj5/XnrB9DFkD0TR8QEZbZlXW0jQYZUDTcecI+84FeYHvajSim859Z6k/lYyPN8zx89RnX4KRYiwfJvj7rFWoeOG5nJpfMmqbcbh/OMub4iCWUxdFNLP5PPo8HJLEimF1H4HOi+zBTs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=a0cV7gJz; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="a0cV7gJz" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 43CDroku010886; Fri, 12 Apr 2024 15:56:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=7i5ZjKaXUVSslnuOoJq884VDlvNZOSPZM+exvkmp3u8=; b=a0 cV7gJzDeAjVk0TLFrv7Ei3I/g21yAgAW308L0sx2TXY872BfB5g5uDWz5a3dGJfz gfTbl5smIabXyEo6hBp76/JxhwxqWRxpEj2YkQHOaVbN89EKL+cRfUjvf6xE+Cye N+Q7/CDLgm/YbZ7UXjfAYAMuuzB8iaTVmspfkNEIwchXfJgnYjtpf/OzAbObKIqQ 8+Jwj5U/jUDXrr+A6/GctNP6k2p9qr7c3Ayv5U9FLZWqcgT7pO72zRwUt9p1jNzv J8DSwx3fnn9YYViZT06iPSZik6VFbCgoC0KtZJDKFJuGTy+7dQfsAQfsCWY7JKCb PzOgDtiG+ipn9smjUDsA== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3xer1tsxyf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 12 Apr 2024 15:56:49 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 43CFumgr001378 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 12 Apr 2024 15:56:48 GMT Received: from [10.226.59.182] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Fri, 12 Apr 2024 08:56:47 -0700 Message-ID: <71da620b-d590-282a-0e27-2d6fa2902e6e@quicinc.com> Date: Fri, 12 Apr 2024 09:56:47 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH] accel/qaic: mark debugfs stub functions as static inline Content-Language: en-US To: Arnd Bergmann , Oded Gabbay , "Jacek Lawrynowicz" , "Pranjal Ramajor Asha Kanojiya" , Carl Vanderlip CC: Arnd Bergmann , , , References: <20240409133945.2976190-1-arnd@kernel.org> From: Jeffrey Hugo In-Reply-To: <20240409133945.2976190-1-arnd@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: f50c3nz43jmDNkXS6Z_RTi4Lnz6MmjTh X-Proofpoint-GUID: f50c3nz43jmDNkXS6Z_RTi4Lnz6MmjTh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-12_12,2024-04-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxlogscore=999 malwarescore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 impostorscore=0 clxscore=1015 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2404010003 definitions=main-2404120116 On 4/9/2024 7:39 AM, Arnd Bergmann wrote: > From: Arnd Bergmann > > The alternative stub functions are listed as global, which produces > a build failure in some configs: > > In file included from drivers/accel/qaic/qaic_drv.c:31: > drivers/accel/qaic/qaic_debugfs.h:16:5: error: no previous prototype for 'qaic_bootlog_register' [-Werror=missing-prototypes] > 16 | int qaic_bootlog_register(void) { return 0; } > | ^~~~~~~~~~~~~~~~~~~~~ > drivers/accel/qaic/qaic_debugfs.h:17:6: error: no previous prototype for 'qaic_bootlog_unregister' [-Werror=missing-prototypes] > 17 | void qaic_bootlog_unregister(void) {} > | ^~~~~~~~~~~~~~~~~~~~~~~ > drivers/accel/qaic/qaic_debugfs.h:18:6: error: no previous prototype for 'qaic_debugfs_init' [-Werror=missing-prototypes] > 18 | void qaic_debugfs_init(struct qaic_drm_device *qddev) {} > | ^~~~~~~~~~~~~~~~~ > > Make them static inline as intended. > > Fixes: 5f8df5c6def6 ("accel/qaic: Add bootlog debugfs") > Signed-off-by: Arnd Bergmann Pushed to drm-misc-next -Jeff