From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sg-1-22.ptr.blmpb.com (sg-1-22.ptr.blmpb.com [118.26.132.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3BED23BF9B for ; Thu, 25 Dec 2025 16:44:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=118.26.132.22 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766681092; cv=none; b=lpUEtlFcZug0E9ilSeFtTjGrIkMILAmMo4sQzZWXU4W33w7Emi6Vbqo92FGbpEYXsT0qK51Q+KGV7RNHTBOoR1Z5e6e02dcIK97HGfnObtB3pNhmWJ/W6tIfmex36/akEm6pwBSxO7Vzmz3o2g7pRBig5yICL/ydUmiMboUHizY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766681092; c=relaxed/simple; bh=LZp7Rn7KVq7rL6RB3F9iQeNPCeJPLJqWhm4LFj+xDLc=; h=References:To:From:Date:Mime-Version:Content-Type:Cc:Subject: Message-Id:In-Reply-To; b=CEI5Q3TewVdsXWDeb5B7nSWyIctAS+Q1r31CO3UhjPrpIEt0XHTyxbKzGCw44IXBgj4l233xM6kk1x9tqM53AGFJUe+qp49ZSs+jC5EDb4q4GDjF47Y8/5yzslYLE3JCnpM56pVJWMih2mikOu9a9ZsBxIM6rB1bP7/zE3kabMY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=fnnas.com; spf=none smtp.mailfrom=fnnas.com; dkim=pass (2048-bit key) header.d=fnnas-com.20200927.dkim.feishu.cn header.i=@fnnas-com.20200927.dkim.feishu.cn header.b=aDI56EEt; arc=none smtp.client-ip=118.26.132.22 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=fnnas.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=fnnas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fnnas-com.20200927.dkim.feishu.cn header.i=@fnnas-com.20200927.dkim.feishu.cn header.b="aDI56EEt" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=s1; d=fnnas-com.20200927.dkim.feishu.cn; t=1766681082; h=from:subject:mime-version:from:date:message-id:subject:to:cc: reply-to:content-type:mime-version:in-reply-to:message-id; bh=+ORxIbZHc36hCwJDvGUay9Dhj9NZj8XTOZ7wTnOOdzg=; b=aDI56EEtAvGpFlO5cNqCauzl5TsFiB+EI2BONjHIyO0sgqGkUncZ1Xs15ayPDepqrMnqwW YKWbZSejU9SDB/g8C/NO8TW3FnTd1S2S6mHkrtgiryGMLOYcZUtgu6WODm4qfeUkjH2W3+ n3TnrtIbbWdcKQEbWyxAwkV2YlFdGXEsoak2Fny/hHY845g7hWoMnV6x9tZJiApBi+Y7ko 1N0PKRS1hdvAdvLdHiGzo8V/GhdQkuxqmIYGmmhdjDJX1uSK7awsXp0jZ7HFnt00hZYxdH zqso6RYvvrSagAq7Bgv3BoOGL4IRshc8sMsNsGV/VpqCCugX4D/1kNZWg9BsMg== References: <20251222021937.1280-1-shechenglong@xfusion.com> Reply-To: yukuai@fnnas.com To: "shechenglong" , , , From: "Yu Kuai" Date: Fri, 26 Dec 2025 00:44:37 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 X-Original-From: Yu Kuai Received: from [192.168.1.104] ([39.182.0.136]) by smtp.feishu.cn with ESMTPS; Fri, 26 Dec 2025 00:44:39 +0800 Content-Language: en-US Cc: , , , , , Subject: Re: [PATCH] block: fix aux stat accumulation destination Message-Id: <71df89fb-1766-40d5-8dd5-5d0c6f49519e@fnnas.com> X-Lms-Return-Path: In-Reply-To: <20251222021937.1280-1-shechenglong@xfusion.com> User-Agent: Mozilla Thunderbird Hi, =E5=9C=A8 2025/12/22 10:19, shechenglong =E5=86=99=E9=81=93: > Route bfqg_stats_add_aux() time accumulation into the destination > stats object instead of the source, aligning with other stat fields. > > Signed-off-by: shechenglong > --- > block/bfq-cgroup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Please change the title and follow existing prefix: block, bfq: fix aux stat accumulation destination Otherwise, feel free to add: Reviewed-by: Yu Kuai > > diff --git a/block/bfq-cgroup.c b/block/bfq-cgroup.c > index 9fb9f3533150..6a75fe1c7a5c 100644 > --- a/block/bfq-cgroup.c > +++ b/block/bfq-cgroup.c > @@ -380,7 +380,7 @@ static void bfqg_stats_add_aux(struct bfqg_stats *to,= struct bfqg_stats *from) > blkg_rwstat_add_aux(&to->merged, &from->merged); > blkg_rwstat_add_aux(&to->service_time, &from->service_time); > blkg_rwstat_add_aux(&to->wait_time, &from->wait_time); > - bfq_stat_add_aux(&from->time, &from->time); > + bfq_stat_add_aux(&to->time, &from->time); > bfq_stat_add_aux(&to->avg_queue_size_sum, &from->avg_queue_size_sum); > bfq_stat_add_aux(&to->avg_queue_size_samples, > &from->avg_queue_size_samples); --=20 Thansk, Kuai