From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757100AbcHYFu5 (ORCPT ); Thu, 25 Aug 2016 01:50:57 -0400 Received: from mout.web.de ([212.227.15.4]:62857 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751063AbcHYFuw (ORCPT ); Thu, 25 Aug 2016 01:50:52 -0400 To: linux-ia64@vger.kernel.org, Fenghua Yu , Tony Luck Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini From: SF Markus Elfring Subject: [PATCH] [IA64] MCA: Use kmalloc_array() in init_record_index_pools() Message-ID: <71e94d34-27fc-1c98-50aa-be96abddabab@users.sourceforge.net> Date: Thu, 25 Aug 2016 07:47:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:jsDLIk4cD3o7unPsjT2T20tLtFv4OH1OUQSOheIm9GasyeYFdcw 3XP23J1dBYGCjnaT1aBRlUYAzERX21C6/KOSY98UUXY5WtE6pdUZKXSbrKyai4dQjYzG/AE zeJNqIkKG6Kk9lTjeaRUAC+4elZdgNm82yJ4ZeNus3TTXRnTBNzhyNn+wqrv3fw3SSGxSKU P6g7UnF1jpJWmwN2NBLwA== X-UI-Out-Filterresults: notjunk:1;V01:K0:UrO0n7D8J/k=:GS8r8vpaP/6h23+fP/d9Vd IfxSF57IU0r/C3db/VxZ7bAC3oRt1zyainmoJfK+zlzQ1KuQYvSag6uiiblaXhUWmGywMmtTW OUB0b9SaBx+shGqPcCyXwYA0KrD6aqpryMtCglG24cCHNXXI1b1R/HHnteW/jaFG9+tzzFJdo 7aUsy5YG+nenlREqJfQmJNMqNrpJvPt5oNWAvm/JJT5nYs/wEgU+hNjBn5QNbUMoNcTZkr6Xg szBD/xyNdwX269BGkLE4ZBXDQG+BX4ZUGJnh6hezncz4Dz6X0JnAGF4DtI2BKZjqtCe/zgxEO djzykXBjiOAGDXfTu9ntScJANFBefYJivtE2TL74Zy2vtR/D3bZw+uhTyevxMOkW1hSeyaY6O YpLw0JdJVeGzWhAj0t/LkvZpu2BSqR4/+VZd19Fmyk8socJFD5FW6tAbavFWtawmnc6b9Dm/6 O0LifeWCYYY3yHAjVu1lnkl5zuULzt7/s06hlyNRg6gRn117in9/+v+v98+YpTrjJ7koUGQd5 yFIkdWO/dwqskahkIh3ng1/ja8yDYbYIVEiylwGjz8n+k6AE/B5feiALhNN1xxYqnNU4ZzA1B M5A/s3asJlWI7BqrpY6QgVcSjrKFhJ1x+EdhWdb7dILICUbBh5j7oKUxAx5f1a2kliZLJY6oS fk7sM+4AuQCwjg7wO6x4Le+SXekR5IYAYgc5TBMzoQTwUUkPDbLcat2YVszNOYTMyLYy7izoK Dlx+vBpMAGWEbj5XmIdtqg8qr0ntEr2j32zyu4/leyz4iKFVuZlYnCVhBKvHA2BPIHQ/Mk83w pOOjh+v22jQluHr+p9p7MSEW0jaRA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 25 Aug 2016 07:37:46 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus reuse the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data structure by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- arch/ia64/kernel/mca_drv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/ia64/kernel/mca_drv.c b/arch/ia64/kernel/mca_drv.c index 94f8bf7..e4ce128 100644 --- a/arch/ia64/kernel/mca_drv.c +++ b/arch/ia64/kernel/mca_drv.c @@ -349,9 +349,9 @@ init_record_index_pools(void) /* - 3 - */ slidx_pool.max_idx = (rec_max_size/sect_min_size) * 2 + 1; - slidx_pool.buffer = - kmalloc(slidx_pool.max_idx * sizeof(slidx_list_t), GFP_KERNEL); - + slidx_pool.buffer = kmalloc_array(slidx_pool.max_idx, + sizeof(*slidx_pool.buffer), + GFP_KERNEL); return slidx_pool.buffer ? 0 : -ENOMEM; } -- 2.9.3