mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Marek <jonathan@marek.ca>
To: Will Deacon <will@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
	Catalin Marinas <catalin.marinas@arm.com>,
	James Morse <james.morse@arm.com>,
	Douglas Anderson <dianders@chromium.org>,
	Trilok Soni <quic_tsoni@quicinc.com>,
	shechenglong <shechenglong@xfusion.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Shameer Kolothum <skolothumtho@nvidia.com>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: proton-pack: Fix hard lockup when !MITIGATE_SPECTRE_BRANCH_HISTORY
Date: Sun, 23 Nov 2025 12:50:24 -0500	[thread overview]
Message-ID: <71ec790c-511d-7b57-a5cb-7c26c46257fe@marek.ca> (raw)
In-Reply-To: <20251117051211.16108-1-jonathan@marek.ca>

Can you pick this up? Its an urgent fix..

And looks like I forgot it, you can add:

Signed-off-by: Jonathan Marek <jonathan@marek.ca>

On 11/17/25 12:12 AM, Jonathan Marek wrote:
> The "drop print" commit removed the whole branch and not just the print.
> For some ARM64 cpus, this leads to hard lockup when
> CONFIG_MITIGATE_SPECTRE_BRANCH_HISTORY is not enabled.
> 
> Fixes: 62e72463ca71 ("arm64: proton-pack: Drop print when !CONFIG_MITIGATE_SPECTRE_BRANCH_HISTORY")
> ---
>   arch/arm64/kernel/proton-pack.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/kernel/proton-pack.c b/arch/arm64/kernel/proton-pack.c
> index c7d70d04c164c..80a580e019c50 100644
> --- a/arch/arm64/kernel/proton-pack.c
> +++ b/arch/arm64/kernel/proton-pack.c
> @@ -1032,6 +1032,8 @@ void spectre_bhb_enable_mitigation(const struct arm64_cpu_capabilities *entry)
>   
>   	if (arm64_get_spectre_v2_state() == SPECTRE_VULNERABLE) {
>   		/* No point mitigating Spectre-BHB alone. */
> +	} else if (!IS_ENABLED(CONFIG_MITIGATE_SPECTRE_BRANCH_HISTORY)) {
> +		/* Do nothing */
>   	} else if (supports_ecbhb(SCOPE_LOCAL_CPU)) {
>   		state = SPECTRE_MITIGATED;
>   		set_bit(BHB_HW, &system_bhb_mitigations);
> 

  reply	other threads:[~2025-11-23 17:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-17  5:12 Jonathan Marek
2025-11-23 17:50 ` Jonathan Marek [this message]
2025-11-24 14:41 ` Will Deacon
2025-11-27  1:08 ` Vladimir Zapolskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71ec790c-511d-7b57-a5cb-7c26c46257fe@marek.ca \
    --to=jonathan@marek.ca \
    --cc=catalin.marinas@arm.com \
    --cc=dianders@chromium.org \
    --cc=james.morse@arm.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_tsoni@quicinc.com \
    --cc=shechenglong@xfusion.com \
    --cc=skolothumtho@nvidia.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®