From: Alexey Dobriyan <adobriyan@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] proc: make struct proc_dir_entry::name const
Date: Thu, 30 Nov 2023 09:58:36 +0300 [thread overview]
Message-ID: <71f006db-5b08-4a81-b577-b1d6b3332e00@p183> (raw)
In-Reply-To: <20231129140705.c1a7faa8f49572f5a50d2416@linux-foundation.org>
On Wed, Nov 29, 2023 at 02:07:05PM -0800, Andrew Morton wrote:
> On Wed, 29 Nov 2023 12:46:57 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:
>
> > Multiply ::name into "mut_name" and "name" which is "const char*".
> >
> > PDE's name must not be mutated on live PDE, hint modules they should not
> > do it.
>
> Do any modules do this?
x86_64 allmodconfig is OK, so in-kernel modules are OK.
> If so, we just broke them.
pff...
> If not, why bother with this change?
I don't know, out of love for humanity and increasing OOT modules
code quality. I don't think I've seen changing pde->name, but then
it is OOT modules we are talking about.
C doesn't have a notion for write once members, oh well.
prev parent reply other threads:[~2023-11-30 6:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 9:46 Alexey Dobriyan
2023-11-29 22:07 ` Andrew Morton
2023-11-30 6:58 ` Alexey Dobriyan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71f006db-5b08-4a81-b577-b1d6b3332e00@p183 \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®