Re: [PATCH 4/4] HID: asus: Implement Fn+F5 fan control key handler

[Denis Benato <benato.denis96@gmail.com>]

On 1/7/26 12:19, Ionut Nechita (Sunlight Linux) wrote:
> From: Ionut Nechita <ionut_n2001@yahoo.com>
>
> On Asus ROG laptops, the Fn+F5 key (HID code 0xae) is used to cycle
> through fan modes. This key press needs to be forwarded to the asus-wmi
> driver to actually change the fan mode.
>
> Add ASUS_FAN_CTRL_KEY_CODE define and implement the handler in
> asus_raw_event() to send WMI events when this key is pressed.
>
> Tested on Asus ROG G14/G15 series laptops.
>
> Change-Id: Ic03df877b71e34c421e992a06e5e706d954e7dbf
> Signed-off-by: Ionut Nechita <ionut_n2001@yahoo.com>
> ---
>  drivers/hid/hid-asus.c | 22 +++++++++++++++++-----
>  1 file changed, 17 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
> index 05fa35489258d..d93c8f030b239 100644
> --- a/drivers/hid/hid-asus.c
> +++ b/drivers/hid/hid-asus.c
> @@ -65,6 +65,9 @@ MODULE_DESCRIPTION("Asus HID Keyboard and TouchPad");
>  #define ASUS_SPURIOUS_CODE_0X8A 0x8a
>  #define ASUS_SPURIOUS_CODE_0X9E 0x9e
>  
> +/* Special key codes */
> +#define ASUS_FAN_CTRL_KEY_CODE 0xae
> +
>  #define SUPPORT_KBD_BACKLIGHT BIT(0)
>  
>  #define MAX_TOUCH_MAJOR 8
> @@ -379,12 +382,21 @@ static int asus_raw_event(struct hid_device *hdev,
>  	if (report->id == FEATURE_KBD_LED_REPORT_ID1 || report->id == FEATURE_KBD_LED_REPORT_ID2)
>  		return -1;
>  	if (drvdata->quirks & QUIRK_ROG_NKEY_KEYBOARD) {
> -		/*
> -		 * G14 and G15 send these codes on some keypresses with no
> -		 * discernable reason for doing so. Filter them out to avoid
> -		 * unmapped warning messages.
> -		 */
>  		if (report->id == FEATURE_KBD_REPORT_ID) {
> +			/* Fn+F5 fan control key, send WMI event to toggle fan mode */
> +			if (data[1] == ASUS_FAN_CTRL_KEY_CODE) {
> +				int ret = asus_wmi_send_event(drvdata, ASUS_FAN_CTRL_KEY_CODE);
> +
What if asus-wmi is not compiled with the kernel?

Would it make sense, in that situation (or in case of a failure)
to tell userspace (via evdev) about the button press?
> +				if (ret < 0)
> +					hid_warn(hdev, "Failed to trigger fan control event\n");
> +				return -1;
> +			}
> +
> +			/*
> +			 * G14 and G15 send these codes on some keypresses with no
> +			 * discernable reason for doing so. Filter them out to avoid
> +			 * unmapped warning messages.
> +			 */
>  			if (data[1] == ASUS_SPURIOUS_CODE_0XEA ||
>  			    data[1] == ASUS_SPURIOUS_CODE_0XEC ||
>  			    data[1] == ASUS_SPURIOUS_CODE_0X02 ||