From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 392C8C433EF for ; Tue, 31 May 2022 06:28:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244275AbiEaG2H (ORCPT ); Tue, 31 May 2022 02:28:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232025AbiEaG2D (ORCPT ); Tue, 31 May 2022 02:28:03 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF15D3FDBF; Mon, 30 May 2022 23:28:01 -0700 (PDT) Received: from canpemm500006.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4LC2Lm3XT0zBrnj; Tue, 31 May 2022 14:24:48 +0800 (CST) Received: from [10.174.179.200] (10.174.179.200) by canpemm500006.china.huawei.com (7.192.105.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 31 May 2022 14:27:53 +0800 Subject: Re: [PATCH net] macsec: fix UAF bug for real_dev To: Jakub Kicinski CC: , , , , , References: <20220528093659.3186312-1-william.xuanziyang@huawei.com> <20220530212338.7a7d4145@kernel.org> From: "Ziyang Xuan (William)" Message-ID: <71f44378-3961-b751-1ae9-f9c4bc4b061a@huawei.com> Date: Tue, 31 May 2022 14:27:53 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20220530212338.7a7d4145@kernel.org> Content-Type: text/plain; charset="gbk" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.200] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500006.china.huawei.com (7.192.105.130) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Sat, 28 May 2022 17:36:59 +0800 Ziyang Xuan wrote: >> --- a/drivers/net/macsec.c >> +++ b/drivers/net/macsec.c >> @@ -107,6 +107,7 @@ struct pcpu_secy_stats { >> struct macsec_dev { >> struct macsec_secy secy; >> struct net_device *real_dev; >> + netdevice_tracker dev_tracker; > > You need to add kdoc for @dev_tracker. Yes, it's right. I will give v2 later. Thank you! > . >