From: Paolo Abeni <pabeni@redhat.com>
To: Hariprasad Kelam <hkelam@marvell.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: kuba@kernel.org, davem@davemloft.net,
willemdebruijn.kernel@gmail.com, andrew@lunn.ch,
sgoutham@marvell.com, lcherian@marvell.com, gakula@marvell.com,
jerinj@marvell.com, sbhatta@marvell.com, naveenm@marvell.com,
edumazet@google.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com,
jiri@resnulli.us, maxtram95@gmail.com, corbet@lwn.net,
linux-doc@vger.kernel.org
Subject: Re: [net-next Patch 1/3] octeontx2-pf: implement transmit schedular allocation algorithm
Date: Fri, 23 Jun 2023 15:01:09 +0200 [thread overview]
Message-ID: <71f51047892001e6cdac1de4a6f7c2b9f97c7c8b.camel@redhat.com> (raw)
In-Reply-To: <20230622085638.3509-2-hkelam@marvell.com>
On Thu, 2023-06-22 at 14:26 +0530, Hariprasad Kelam wrote:
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/qos.h b/drivers/net/ethernet/marvell/octeontx2/nic/qos.h
> index 19773284be27..0c5d2f79dc15 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/qos.h
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/qos.h
> @@ -35,6 +35,7 @@ struct otx2_qos_cfg {
> int dwrr_node_pos[NIX_TXSCH_LVL_CNT];
> u16 schq_contig_list[NIX_TXSCH_LVL_CNT][MAX_TXSCHQ_PER_FUNC];
> u16 schq_list[NIX_TXSCH_LVL_CNT][MAX_TXSCHQ_PER_FUNC];
> + u16 schq_used_index[NIX_TXSCH_LVL_CNT][MAX_TXSCHQ_PER_FUNC];
This struct is already quite big, and you use schq_used_index[x][y] as
a bool. I think you will be better off changing the used type
accordingly.
Side note 'schq_index_used' sounds a little more clear to me, but could
be simply ENONATIVELANG here ;)
Cheers,
Paolo
next prev parent reply other threads:[~2023-06-23 13:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 8:56 [net-next Patch 0/3] octeontx2-pf: support Round Robin scheduling Hariprasad Kelam
2023-06-22 8:56 ` [net-next Patch 1/3] octeontx2-pf: implement transmit schedular allocation algorithm Hariprasad Kelam
2023-06-23 13:01 ` Paolo Abeni [this message]
2023-06-25 4:19 ` Hariprasad Kelam
2023-06-22 8:56 ` [net-next Patch 2/3] sch_htb: Allow HTB quantum parameter in offload mode Hariprasad Kelam
2023-06-22 8:56 ` [net-next Patch 3/3] octeontx2-pf: htb offload support for Round Robin scheduling Hariprasad Kelam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71f51047892001e6cdac1de4a6f7c2b9f97c7c8b.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=jerinj@marvell.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=lcherian@marvell.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxtram95@gmail.com \
--cc=naveenm@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=willemdebruijn.kernel@gmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®