From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.214.172 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794323278; b=JQzuVrcuq5/rl0/qkBW5Oj/jTs8Olht4pSygGLtHr3QMRcaSqK7p8xFWuFpXnVwWwWZe bcgb4M8divEV8yOOnXGaPbZ4idOZEplTT5vSH80hADvwPXWEfmDHhl0ylOEfqagW50kes 3maJSPlMB12sXf1tY8S5YZ4vURge7Tiooudl6SlbLX/VMjocw+V3IC5qy2L68cdOXot9c vQTFxbYC8KLEgQUFCPgYL5sTBVZ3ZRytHO/4nfp0S4Hnueb+raQU+/SVc/cxDaHzgPjwh rhP0QcOTIhEM00/lXR9VDDibPwPuXCosoPesX6SeGKtHQwjupEEhuzVysiHxfeUgWWw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794323278; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=JtM9UtzYhAWCxTCfoBKbcmHIR3U4Wq7tzdw7gboBY64=; b=C5UiTgtHvzwVM/IihUFQ4cYLF3i/JwZ7cwtZClUwLoW7F8oSjNLQwtHBNT8wdZILUW2U 8aYltazKR3wxUU/G94medmybREfW6oCsz4dl/kT/bSvaa7vaNit6RyO0j5y7mVA8Nf46R CYi3j7J9K2SWowhIc/a7STxTOP7vaU4nT97DuwLDU+8RmzsWC1KPXRwryPoVG9xsNd1ea rhzkESbng/esxQ80qQmK1nU9TZagiAGKpNrsMTReAb68hQGSakl5S4GCBcsvcjzaNkbLP a0hhQg3kkv94eI7GBgI8cxGdquCYhuA0Ns9AujwYxR2LqnTWJCw9GItIgg2cTzoy6AQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=LHozpx7Z; arc=none smtp.remote-ip=209.85.214.172 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20A9F60A2621 for ; Tue, 10 Nov 2026 15:07:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 20A9F60A2621 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=LHozpx7Z Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2e977109392so12284655ad.0 for ; Tue, 10 Nov 2026 07:07:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794323277; x=1794928077; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=JtM9UtzYhAWCxTCfoBKbcmHIR3U4Wq7tzdw7gboBY64=; b=LHozpx7ZkQyIUBsAkv4C311vzxfheFN2pzrL9Y/FTHkEXQzaVUkMAz9U9wFUejAOr8 YATASi40x9WcOvyF4dkS6SJQ2bBJHO0yE68WsOT8oewufPXMhMYT6O7d4/5H33a+EMHR jjCu1KqktdAA/9c8ZIpbjFjA/3BLyNbgEZc3fS3F9+PTZ5y3jCgkJQ9rhGft5ONP+cJO aTEF5vn9sQP8UWqDXO8UszNcV0yZFTKvtrsUk25y1Sz/3h5njQt9uj1PBQLO+FuWPgpB LsGoLTWDE/iFYFuKD+GJLya2PXFipxPXM8zYDthkWkjgd0549O004Xgoom3qc/ylK84T vykg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794323277; x=1794928077; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=JtM9UtzYhAWCxTCfoBKbcmHIR3U4Wq7tzdw7gboBY64=; b=ZRgtshOffMNqt5wUqwXEcDs69Ktl27zgcwsxTp/uhIppo9HnrZWbTrjAkjzyajNWv8 pDsH3ryGRuHgRTP0KuyvlLagHsFHrm9GQwVdUuBGlfGm2I1O1GD+kqNkwJXJYL6VIYR4 e+yQSqebDRTCllFtDeHIC6coJQw3LW8ePD0hgrN4K8d79BqKaEJwlugD6lJfDHzYfz0V SK2VeuOW1wWIOaXc7BUxBABk+TKjxmRlLine6c6CB0XVZ2gtgNPslWbZXRX6QvXXEotg ihSZtriJS2HnhbD4fP6ZSsowvBn/Q3jHiJ7VtCUYL/Ja28OxPqRb5mlaRYKJRoPT8Bbn 9OWg== X-Forwarded-Encrypted: i=1; AL+hErFljyTc3gIAffQl967cpGBE7fOdCKAegroqh7yahlG8eV10xOFoLAmKbJ/1grOYch1GQJlNebjfvnJ80f0=@vger.kernel.org X-Gm-Message-State: APuU4Z9idxB4tvqJ6mER62xDxeHpyw7F4VQ2Kf07xrD1L9MeSiKTFHIj yBAFSJqgNG70lyy7iSVynKPQ0mfBpEFCg9CZlvTZSOYgVrS9mdEPBlmq X-Gm-Gg: AYBFou3hcS3rSAoHalcndtLtOquD9pefLS9ZupNj1lnn9A4CqTHqf1j2L0tdVqjUlrs xmG9my93A3+JF8IMJLdvRSMCr/2aD+LLpkN+d9yxVRx5MQIUr5MgOaKIN+oEDUAK28pMTkk/6A+ iglvmiKd5R9UbBNEG2c2kUypWcPqXiFCT2sZ9XABCT2blN25WyxshCnyCsCTL49wCIDyxex5ys8 96jqZI/d3yonS6Nq/2ZM7QMVSbXcFOeoJqKo6ohpc8D4CBoRGVRNX7ldVHuja9S+RfeQIELNouX eEBtxstIz76YsnmmfV3+4HgvWbXZVE0gHD7D36fyQoXBJb6hmDtziqk8/Tbof7wIYIM3wVv7DAn 5YY2CtixjGLSQu4tWFwDNcReMYmfixP30aiCaO2B2eatwxUIrKi1EAbp9LvuO3EUG6SUTZ3Y7wd 659e+hEteX1JudYDGB74ftGiV5PwXVZodOsVttoNyb/NG15K7jrNSc6r5xG+YlsYyQEmUZ4HI85 ozo8qayfFEwOUNFe4kf/PsvLmEF9pYEzXMQ4b+2UKIqpFfYsm97WCNKukS7BIJzGMoySiQHaUFc THbJXOF4kzL2X8Y5Fy09SuZOh3RW1o+9pJPV8zne6onjgR5c0G/EqNat/N7Jw7/mt5tzVCmWKtu U/R2hJ+As3m0= X-Received: by 2002:a17:902:d481:b0:2ed:1ef3:9ec with SMTP id d9443c01a7336-2edb9172a2dmr26826345ad.14.1794323276968; Tue, 10 Nov 2026 07:07:56 -0800 (PST) Received: from [192.168.2.6] ([27.75.101.24]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2edb6d78dbcsm10397575ad.27.2026.11.10.07.07.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Nov 2026 07:07:56 -0800 (PST) Message-ID: <71f76e5e-ce24-4a71-863a-169ad262c510@gmail.com> Date: Tue, 10 Nov 2026 22:07:46 +0700 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 36/41] nvmet: refuse files on pseudo filesystems as namespace backing files To: Christian Brauner , linux-fsdevel@vger.kernel.org Cc: Jann Horn , Chris Mason , Josef Bacik , Christoph Hellwig , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Alexander Viro , Jan Kara , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, driver-core@lists.linux.dev, linux-mm@kvack.org, bpf@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, apparmor@lists.ubuntu.com, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, fuse-devel@lists.linux.dev, linux-efi@vger.kernel.org, xen-devel@lists.xenproject.org, ocfs2-devel@lists.linux.dev, linux-s390@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-usb@vger.kernel.org, Amir Goldstein , linux-erofs@lists.ozlabs.org, linux-kselftest@vger.kernel.org References: <20261110-work-loop-pseudo-v1-0-4c998976c6c7@kernel.org> <20261110-work-loop-pseudo-v1-36-4c998976c6c7@kernel.org> Content-Language: en-US From: Bui Nguyen Nhu Quynh In-Reply-To: <20261110-work-loop-pseudo-v1-36-4c998976c6c7@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/10/2026 4:14 PM, Christian Brauner wrote: > The file backend takes any path that isn't a block device. With > buffered_io=1 that includes files on procfs or sysfs which then get read > and written by a kernel worker on behalf of the host. Refuse files on > pseudo filesystems just like loop does. > > Signed-off-by: Christian Brauner (Amutable) > --- > drivers/nvme/target/io-cmd-file.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/nvme/target/io-cmd-file.c b/drivers/nvme/target/io-cmd-file.c > index dfa8aa46188c..71c69bac5394 100644 > --- a/drivers/nvme/target/io-cmd-file.c > +++ b/drivers/nvme/target/io-cmd-file.c > @@ -52,6 +52,11 @@ int nvmet_file_ns_enable(struct nvmet_ns *ns) > goto err; > } > > + if (file_is_pseudo(ns->file)) { > + ret = -EINVAL; > + goto err; > + } > + > nvmet_file_ns_revalidate(ns); > > /* > I noticed patch 41/41 doesn't include a test for nvmet. Would it make sense to add one with buffered_io=1? The test would need a pseudo file that can be opened with O_RDWR and supports both read_iter and write_iter. Otherwise, it could pass without ever reaching the new file_is_pseudo() check. Thanks.