From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7CEE32F6922 for ; Mon, 16 Feb 2026 10:12:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771236737; cv=none; b=j/L241c63qgG4HOHvqWCYE2b+0emsR0wyK4CFAW2+1+81aQSBAQJLBnKIazPES9Xq1yIL+oxVQpCkTBtE1KjKX+5oycSk07i4uHPV4D/GYDT5oK2co383b7VpANgkrYdsJW8lVuI52aijD5cuGdIUExDCj2o5UNZFBQ2q0gGeRg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771236737; c=relaxed/simple; bh=Ot/kmpbQEe/4R34Hfvq4D4SoLQY3Z82yHBqbFKTfrjQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Cmjyzp0GkfZk9D2l2Us2o1FEo91kgs+CWQgr1RPqtR2MdPk6icfMEIBHWAzvp4qauq1rLUb3iLHkpp08kr9kUvE5JGw0zXqE+YOUsBICPsahvasKKRiq7KDxxxjcfpmHRmNWoOV0xsLPS/mph6qpS0d9C9Eby760QJHpfgSZ2bw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F2BF1150C; Mon, 16 Feb 2026 02:12:07 -0800 (PST) Received: from [10.164.19.71] (unknown [10.164.19.71]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3452D3F73F; Mon, 16 Feb 2026 02:12:10 -0800 (PST) Message-ID: <71fbee21-f1b4-4202-a790-5076850d8d00@arm.com> Date: Mon, 16 Feb 2026 15:42:08 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [REGRESSION] mm/mprotect: 2x+ slowdown for >=400KiB regions since PTE batching (cac1db8c3aad) To: "David Hildenbrand (Arm)" , Suren Baghdasaryan , Pedro Falcato Cc: Luke Yang , jhladky@redhat.com, akpm@linux-foundation.org, Liam.Howlett@oracle.com, willy@infradead.org, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <764792ea-6029-41d8-b079-5297ca62505a@kernel.org> Content-Language: en-US From: Dev Jain In-Reply-To: <764792ea-6029-41d8-b079-5297ca62505a@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 13/02/26 10:56 pm, David Hildenbrand (Arm) wrote: > On 2/13/26 18:16, Suren Baghdasaryan wrote: >> On Fri, Feb 13, 2026 at 4:24 PM Pedro Falcato wrote: >>> >>> On Fri, Feb 13, 2026 at 04:47:29PM +0100, David Hildenbrand (Arm) wrote: >>>> >>>> Hi! >>>> >>>> >>>> Micro-benchmark results are nice. But what is the real word impact? >>>> IOW, why >>>> should we care? >>> >>> Well, mprotect is widely used in thread spawning, code JITting, >>> and even process startup. And we don't want to pay for a feature we can't >>> even use (on x86). >> >> I agree. When I straced Android's zygote a while ago, mprotect() came >> up #30 in the list of most frequently used syscalls and one of the >> most used mm-related syscalls due to its use during process creation. >> However, I don't know how often it's used on VMAs of size >=400KiB. > > See my point? :) If this is apparently so widespread then finding a real > reproducer is likely not a problem. Otherwise it's just speculation. > > It would also be interesting to know whether the reproducer ran with any > sort of mTHP enabled or not.  Yes. Luke, can you experiment with the following microbenchmark: https://pastebin.com/3hNtYirT and see if there is an optimization for pte-mapped 2M folios, before and after the commit? (set transparent_hugepages/enabled=always, hugepages-2048Kb/enabled=always) > >> >>> >>> In any case, I think I see the problem. Namely, that we now need to call >>> vm_normal_folio() for every single PTE (this seems similar to the mremap >>> problem caught in 0b5be138ce00f421bd7cc5a226061bd62c4ab850). I'll try to >>> draft up a patch over the weekend if I can. > > I think we excessively discussed that during review and fixups of the > commit in question. You might want to dig through that because I could > have sworn we might already have discussed how to optimize this.  I have written a patch to call vm_normal_folio only when required, and use pte_batch_hint instead of vm_normal_folio + folio_pte_batch. The results, testing with  https://pastebin.com/3hNtYirT on Apple M3: without-thp (small 4K folio case): patched beats vanilla by 6.89% (patched avoids vm_normal_folio overhead) 64k-thp: no diff pte-mapped-2M thp: vanilla beats patched by 10.71% (vanilla batches over 2M, patched batches over 64K) Interestingly, I don't see an obvious reason why the last case should have a win. Batching over 16 ptes or 512 ptes in this code path, AFAIU is *not* going to batch over TLB flushes, atomic ops etc (the tlb_flush_pte_range in prot_commit_flush_ptes is an mmu-gather extension and not a TLB flush). So, the fact that similar operations are now getting batched should imply better memory access locality, fewer function calls etc. > > When going from none -> writable we always did a vm_normal_folio() with > anonymous folios. For the other direction not. >