From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E23BC25B4E for ; Tue, 24 Jan 2023 09:05:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231483AbjAXJFg (ORCPT ); Tue, 24 Jan 2023 04:05:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233066AbjAXJFe (ORCPT ); Tue, 24 Jan 2023 04:05:34 -0500 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 870FF3E08B for ; Tue, 24 Jan 2023 01:05:32 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id r2so13160536wrv.7 for ; Tue, 24 Jan 2023 01:05:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wh9YPwUFmU9TlXE8h6aarMlvLtrqOnroY8ktmkM9cF4=; b=NZLu/mXW/jR7P3J17bOgR6qP2EvV8pBIAs2EK+EY8boNhE8FtlYTBwgw1o4LP0Ou5l 7o9Ot2ODWivHgzBSAJ0IBV+AjHzdb/yukmzpiuClYyjEROnI3ViQRRGAxEgPg+Aa8riC /AEH2/T5wFH6p7d08431R59fEPkQPu0yfIC+5VFqCfp1HoGp3Pzsb2O0R+lJCpAhsUGS dxOGk6V7Uo+G3wxAFhgDfzHRNuEFmH3+71rHT0oNwPvn/PfJj4WULB6tuCfythudkkAk Iq3YSBNJYb0c/jvBZfE4g6qZiRcRY90ZDBvI2s9Iu4kIZb8WiN9rzzTZchvcSyXjzL9p p4UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wh9YPwUFmU9TlXE8h6aarMlvLtrqOnroY8ktmkM9cF4=; b=Im6eJWKqdgPYThF/in2Qt5Wph3z6pWb2zzPzYQs+Yx0rn9OlRjthjWt78kHJzei8xl PbRx+hyV74dLOvuHf8kwZOHERS1jyhJShpNMu2dzhWp9s78LmPuff3SulwvihIMqRCyy CIYlCJwJMxnHzzJQ6tV2JWF7sUc2zzhJFoWxEwGZTbR6wkB9vp5cAhoUK4xIPzTH2pRw j9W58ZpcIDzAmGwEFGsHgTl/lt3KrI0NIVo8fcbp4Lb7qqvkyk7vqCwcxkA55ujD+sRV qVNROMxiPMUDdiKMlhhMdJtrsRAuJrn2PrRsFxrmJ9C7qFPuNt7eDkSJDMNru04klqST FOYg== X-Gm-Message-State: AFqh2kqVvkcIlf5RV6/kNORfuweszjztU1o2h9gDqtUUnrTFtT5WSx8N ZGC69d23MPplShYuj1ba86fqtA== X-Google-Smtp-Source: AMrXdXukUC6LKF0R6+9iNiS48zc+9/Y6jhzP7MWyQ85ZuTQuZfZ3Y1McusWuaT27kf+OhuNHIrxGtQ== X-Received: by 2002:a5d:6b05:0:b0:2bd:cf99:e6ab with SMTP id v5-20020a5d6b05000000b002bdcf99e6abmr22075514wrw.65.1674551131018; Tue, 24 Jan 2023 01:05:31 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id l4-20020adfa384000000b00241fab5a296sm1365052wrb.40.2023.01.24.01.05.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Jan 2023 01:05:30 -0800 (PST) Message-ID: <71fd9674-63a7-9887-d602-1f57ae3982aa@linaro.org> Date: Tue, 24 Jan 2023 10:05:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH 11/13] dt-bindings: serial: restrict possible child node names Content-Language: en-US To: Rob Herring Cc: Rob Herring , - , linux-riscv@lists.infradead.org, Alexandre Torgue , Pengutronix Kernel Team , Tomer Maimon , Paul Walmsley , Sascha Hauer , Peter Korsgaard , Chester Lin , Geert Uytterhoeven , Martin Blumenstingl , linux-stm32@st-md-mailman.stormreply.com, Kevin Hilman , linux-kernel@vger.kernel.org, Fugang Duan , Shawn Guo , Greg Kroah-Hartman , linux-serial@vger.kernel.org, Neil Armstrong , Fabio Estevam , Maxime Coquelin , Le Ray , Michal Simek , Lubomir Rintel , Jerome Brunet , Magnus Damm , Pragnesh Patel , Krzysztof Kozlowski , linux-amlogic@lists.infradead.org, NXP Linux Team , Palmer Dabbelt , Vignesh Raghavendra , linux-arm-kernel@lists.infradead.org References: <20230123151302.368277-1-krzysztof.kozlowski@linaro.org> <20230123151302.368277-11-krzysztof.kozlowski@linaro.org> <167451486467.2795286.1299932821783618559.robh@kernel.org> From: Krzysztof Kozlowski In-Reply-To: <167451486467.2795286.1299932821783618559.robh@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/01/2023 00:05, Rob Herring wrote: > > On Mon, 23 Jan 2023 16:13:00 +0100, Krzysztof Kozlowski wrote: >> The re-usable serial.yaml schema matches every property with ".*" >> pattern, thus any other schema referencing it will not report unknown >> (unevaluated) properties. This hides several wrong properties. It is >> a limitation of dtschema, thus provide a simple workaround: expect >> children to be only of few names matching upstream usage (Bluetooth, >> GNSS, GPS and MCU). >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> Documentation/devicetree/bindings/serial/serial.yaml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/bus/intel,ixp4xx-expansion-bus-controller.example.dtb: serial@1,0: Unevaluated properties are not allowed ('intel,ixp4xx-eb-byte-access', 'intel,ixp4xx-eb-cycle-type', 'intel,ixp4xx-eb-t3', 'intel,ixp4xx-eb-write-enable' were unexpected) > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/serial/8250.yaml Eh, this is not trivial to solve. The "intel,ixp4xx-expansion-bus-controller.yaml" bindings add properties to children nodes, just like spi-peripheral-props: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/bus/intel,ixp4xx-expansion-bus-controller.yaml?h=v6.2-rc5#n147 Any node can be there: 1. serial, which was broken since beginning but errors not visible, 2. flash, which work fine just because mtd-physmap.yaml allows it, 3. more? Existing DTS of this ixp4xx controller have different nodes, for example: flash, shared-dma-pool, ns8250, arcom,vulcan-gpio, maxim,max6369: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/intel-ixp42x-arcom-vulcan.dts?h=v6.2-rc5#n40 Probably we need expansion-bus-controller-peripheral-props.yaml and include it in every possible child. Does it sound reasonable? Best regards, Krzysztof