From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A138155389; Thu, 10 Jul 2025 14:33:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752157990; cv=none; b=LI7oN1cFDV0/5/1VWFLihTCTJ2V8aKWBNscdeQwipfe12zsDI6fYAivTtmkN1XBaW8BWsQN/yIJogKRbCOhJcY8ieUAoU3mV1J40vy5BbxOlrnkTls/2KWtNUJsmeXt7iSV8cqJa2RIw2xfWLhLFtdbnWhIzd+5ANbg6lAWMBgg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752157990; c=relaxed/simple; bh=d2PggKXh65C5wsYv+sAOWEiyIFudIEs6dBBQURke4Pg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=agelgz66Zx5QHRBsiFW0XLyxWSC3nmjNLPLzkIoQgrM9SQXzmHIhy8cHam4/wiKPy2nWEv00aHn5obM3YxHWlDkvSq1zmvVqXeoVR2vyJcJxcRTjAXwvsaiTv/lo3n2b8o/0fr/GmQ6in5MdjkCAeRUGCjqjc+TZm2d0twbOHfk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ghiti.fr; spf=pass smtp.mailfrom=ghiti.fr; arc=none smtp.client-ip=217.70.183.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ghiti.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ghiti.fr Received: by mail.gandi.net (Postfix) with ESMTPSA id 8123C44330; Thu, 10 Jul 2025 14:32:58 +0000 (UTC) Message-ID: <7204f633-5b35-41ce-b847-7dfbaedbac47@ghiti.fr> Date: Thu, 10 Jul 2025 16:32:57 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2] riscv: ftrace: Fix the logic issue in DYNAMIC_FTRACE selection To: Miao Chen Cc: kernel test robot , Linux RISCV , oe-kbuild-all@lists.linux.dev, Paul Walmsley , Palmer Dabbelt , Albert Ou , Steven Rostedt , Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Heiko Carstens , Pu Lehui , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org References: Content-Language: en-US From: Alexandre Ghiti In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdegtdeilecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtvdejnecuhfhrohhmpeetlhgvgigrnhgurhgvucfihhhithhiuceorghlvgigsehghhhithhirdhfrheqnecuggftrfgrthhtvghrnhepfeeujedtgeekvdehhfduhfegfeeiveehueegheegvdfgjefhteejieduledvfeetnecuffhomhgrihhnpehgihhthhhusgdrtghomhdpkhgvrhhnvghlrdhorhhgpdhinhhfrhgruggvrggurdhorhhgnecukfhppedvtddtudemkeeiudemfeefkedvmegvfheltdemsgeffhdumeejtgeirgemsgehudelmegrfhgstdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpedvtddtudemkeeiudemfeefkedvmegvfheltdemsgeffhdumeejtgeirgemsgehudelmegrfhgstddphhgvlhhopeglkffrggeimedvtddtudemkeeiudemfeefkedvmegvfheltdemsgeffhdumeejtgeirgemsgehudelmegrfhgstdgnpdhmrghilhhfrhhomheprghlvgigsehghhhithhirdhfrhdpnhgspghrtghpthhtohepudehpdhrtghpthhtoheptghhvghnmhhirghordhkuhesghhmrghilhdrtghomhdprhgtphhtthhopehlkhhpsehin hhtvghlrdgtohhmpdhrtghpthhtoheplhhinhhugidqrhhishgtvheslhhishhtshdrihhnfhhrrgguvggrugdrohhrghdprhgtphhtthhopehovgdqkhgsuhhilhguqdgrlhhlsehlihhsthhsrdhlihhnuhigrdguvghvpdhrtghpthhtohepphgruhhlrdifrghlmhhslhgvhiesshhifhhivhgvrdgtohhmpdhrtghpthhtohepphgrlhhmvghrsegurggssggvlhhtrdgtohhmpdhrtghpthhtoheprghouhesvggvtghsrdgsvghrkhgvlhgvhidrvgguuhdprhgtphhtthhopehrohhsthgvughtsehgohhoughmihhsrdhorhhg X-GND-Sasl: alex@ghiti.fr On 7/10/25 14:34, Miao Chen wrote: > Hello Alex, > > Sure, I'll checkout it. Btw, this is my first commit, so can u tell > how to reproduce failed case? Using the reproduce and .config.gz gived > by build-bot? Yes exactly! > > Thanks, > > Chen Miao > > Alexandre Ghiti 于2025年7月10日周四 19:53写道： >> Hi ChenMiao, >> >> On 7/9/25 03:08, kernel test robot wrote: >>> Hi ChenMiao, >>> >>> kernel test robot noticed the following build errors: >>> >>> [auto build test ERROR on fda589c286040d9ba2d72a0eaf0a13945fc48026] >>> >>> url: https://github.com/intel-lab-lkp/linux/commits/ChenMiao/riscv-ftrace-Fix-the-logic-issue-in-DYNAMIC_FTRACE-selection/20250706-231907 >>> base: fda589c286040d9ba2d72a0eaf0a13945fc48026 >>> patch link: https://lore.kernel.org/r/20250706151830.25091-1-chenmiao.ku%40gmail.com >>> patch subject: [PATCH V2] riscv: ftrace: Fix the logic issue in DYNAMIC_FTRACE selection >>> :::::: branch date: 2 days ago >>> :::::: commit date: 2 days ago >>> config: riscv-randconfig-r112-20250708 (attached as .config) >>> compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90) >>> reproduce: (attached as reproduce) >>> >>> If you fix the issue in a separate patch/commit (i.e. not just a new version of >>> the same patch/commit), kindly add following tags >>> | Reported-by: kernel test robot >>> | Closes: https://lore.kernel.org/oe-kbuild-all/202507090650.YGY56SIA-lkp@intel.com/ >>> >>> All errors (new ones prefixed by >>): >>> >>>>> :1:14: error: operand must be a symbol with %lo/%pcrel_lo/%tprel_lo modifier or an integer in the range [-2048, 2047] >>> addi sp, sp, -FREGS_SIZE_ON_STACK >>> ^ >>> arch/riscv/kernel/mcount-dyn.S:185:2: note: while in macro instantiation >>> SAVE_ABI_REGS >>> ^ >>>>> :2:18: error: unexpected token >>> sw t0, FREGS_EPC(sp) >>> ^ >>> arch/riscv/kernel/mcount-dyn.S:185:2: note: while in macro instantiation >>> SAVE_ABI_REGS >>> ^ >>> :3:17: error: unexpected token >>> sw x1, FREGS_RA(sp) >>> ^ >>> arch/riscv/kernel/mcount-dyn.S:185:2: note: while in macro instantiation >>> SAVE_ABI_REGS >>> ^ >>> :7:17: error: unexpected token >>> sw x6, FREGS_T1(sp) >>> ^ >>> arch/riscv/kernel/mcount-dyn.S:185:2: note: while in macro instantiation >>> SAVE_ABI_REGS >>> ^ >>> :9:17: error: unexpected token >>> sw x7, FREGS_T2(sp) >>> ^ >>> arch/riscv/kernel/mcount-dyn.S:185:2: note: while in macro instantiation >>> SAVE_ABI_REGS >>> ^ >>> :10:18: error: unexpected token >>> sw x28, FREGS_T3(sp) >>> ^ >>> arch/riscv/kernel/mcount-dyn.S:185:2: note: while in macro instantiation >>> SAVE_ABI_REGS >>> ^ >>> :11:18: error: unexpected token >>> sw x29, FREGS_T4(sp) >>> ^ >>> arch/riscv/kernel/mcount-dyn.S:185:2: note: while in macro instantiation >>> SAVE_ABI_REGS >>> ^ >>> :12:18: error: unexpected token >>> sw x30, FREGS_T5(sp) >>> ^ >>> arch/riscv/kernel/mcount-dyn.S:185:2: note: while in macro instantiation >>> SAVE_ABI_REGS >>> ^ >>> :13:18: error: unexpected token >>> sw x31, FREGS_T6(sp) >>> ^ >>> arch/riscv/kernel/mcount-dyn.S:185:2: note: while in macro instantiation >>> SAVE_ABI_REGS >>> ^ >>> :16:18: error: unexpected token >>> sw x10, FREGS_A0(sp) >>> ^ >>> arch/riscv/kernel/mcount-dyn.S:185:2: note: while in macro instantiation >>> SAVE_ABI_REGS >>> ^ >>> :17:18: error: unexpected token >>> sw x11, FREGS_A1(sp) >>> ^ >>> arch/riscv/kernel/mcount-dyn.S:185:2: note: while in macro instantiation >>> SAVE_ABI_REGS >>> ^ >>> :18:18: error: unexpected token >>> sw x12, FREGS_A2(sp) >>> ^ >>> arch/riscv/kernel/mcount-dyn.S:185:2: note: while in macro instantiation >>> SAVE_ABI_REGS >>> ^ >>> :19:18: error: unexpected token >>> sw x13, FREGS_A3(sp) >>> ^ >>> arch/riscv/kernel/mcount-dyn.S:185:2: note: while in macro instantiation >>> SAVE_ABI_REGS >>> ^ >>> :20:18: error: unexpected token >>> sw x14, FREGS_A4(sp) >>> ^ >>> arch/riscv/kernel/mcount-dyn.S:185:2: note: while in macro instantiation >>> SAVE_ABI_REGS >>> ^ >>> :21:18: error: unexpected token >>> sw x15, FREGS_A5(sp) >>> ^ >>> arch/riscv/kernel/mcount-dyn.S:185:2: note: while in macro instantiation >>> SAVE_ABI_REGS >>> ^ >>> :22:18: error: unexpected token >>> sw x16, FREGS_A6(sp) >>> ^ >>> arch/riscv/kernel/mcount-dyn.S:185:2: note: while in macro instantiation >>> SAVE_ABI_REGS >>> ^ >>> :23:18: error: unexpected token >>> sw x17, FREGS_A7(sp) >>> ^ >>> arch/riscv/kernel/mcount-dyn.S:185:2: note: while in macro instantiation >>> SAVE_ABI_REGS >>> ^ >>> :25:15: error: operand must be a symbol with %lo/%pcrel_lo/%tprel_lo modifier or an integer in the range [-2048, 2047] >>> addi a0, a0, FREGS_SIZE_ON_STACK >>> ^ >>> arch/riscv/kernel/mcount-dyn.S:185:2: note: while in macro instantiation >>> SAVE_ABI_REGS >>> >>> Kconfig warnings: (for reference only) >>> WARNING: unmet direct dependencies detected for DYNAMIC_FTRACE >>> Depends on [n]: FTRACE [=y] && FUNCTION_TRACER [=y] && HAVE_DYNAMIC_FTRACE [=n] >>> Selected by [y]: >>> - RISCV [=y] && FUNCTION_TRACER [=y] >> To avoid that, we should check HAVE_DYNAMIC_FTRACE too: >> >> select DYNAMIC_FTRACE if FUNCTION_TRACER && HAVE_DYNAMIC_FTRACE >> >> That fixes the build error for me. Can you send a v3 with this change? >> >> Thanks, >> >> Alex >> >> > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv