mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yunlong Song <yunlong.song@huawei.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-f2fs-devel@lists.sourceforge.net>
Cc: <miaoxie@huawei.com>, <yuchao0@huawei.com>,
	chao <chao@kernel.org>, <bintian.wang@huawei.com>,
	<heyunlei@huawei.com>, "shengyong (A)" <shengyong1@huawei.com>
Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: show precise # of blocks that user/root can use
Date: Fri, 5 Jan 2018 15:05:07 +0800	[thread overview]
Message-ID: <7206fb17-4785-756c-9fef-39565adf8780@huawei.com> (raw)
In-Reply-To: <20180103185845.29953-1-jaegeuk@kernel.org>

NACK

man statfs shows:

struct statfs {
     ...
     fsblkcnt_t   f_bfree;   /* free blocks in fs */
     fsblkcnt_t   f_bavail;  /* free blocks available to
                                     unprivileged user */
     ...
}

f_bfree is free blocks in fs, so buf->bfree should be

buf->f_bfree = user_block_count - valid_user_blocks(sbi) + ovp_count;

On 2018/1/4 2:58, Jaegeuk Kim wrote:
> Let's show precise # of blocks that user/root can use through bavail and bfree
> respectively.
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
>   fs/f2fs/super.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 0a820ba55b10..4c1c99cf54ef 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -1005,9 +1005,9 @@ static int f2fs_statfs(struct dentry *dentry, struct kstatfs *buf)
>   	buf->f_bsize = sbi->blocksize;
>   
>   	buf->f_blocks = total_count - start_count;
> -	buf->f_bfree = user_block_count - valid_user_blocks(sbi) + ovp_count;
> -	buf->f_bavail = user_block_count - valid_user_blocks(sbi) -
> +	buf->f_bfree = user_block_count - valid_user_blocks(sbi) -
>   						sbi->current_reserved_blocks;
> +	buf->f_bavail = buf->f_bfree;
>   
>   	avail_node_count = sbi->total_node_count - sbi->nquota_files -
>   						F2FS_RESERVED_NODE_NUM;

-- 
Thanks,
Yunlong Song

  parent reply	other threads:[~2018-01-05  7:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-03 18:58 Jaegeuk Kim
2018-01-03 18:58 ` [PATCH 2/2] f2fs: add reserved blocks for root user Jaegeuk Kim
2018-01-04  6:51   ` [PATCH 2/2 v2] " Jaegeuk Kim
2018-01-04  7:21     ` [f2fs-dev] " Chao Yu
2018-01-05  4:43     ` [PATCH 2/2 v3] " Jaegeuk Kim
2018-01-05  8:04   ` [f2fs-dev] [PATCH 2/2] " Yunlong Song
2018-01-04  1:12 ` [f2fs-dev] [PATCH 1/2] f2fs: show precise # of blocks that user/root can use Chao Yu
2018-01-04  6:50 ` [PATCH 1/2 v2] " Jaegeuk Kim
2018-01-04  7:20   ` [f2fs-dev] " Chao Yu
2018-01-05  7:05 ` Yunlong Song [this message]
2018-01-08 11:23   ` [f2fs-dev] [PATCH 1/2] " Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7206fb17-4785-756c-9fef-39565adf8780@huawei.com \
    --to=yunlong.song@huawei.com \
    --cc=bintian.wang@huawei.com \
    --cc=chao@kernel.org \
    --cc=heyunlei@huawei.com \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miaoxie@huawei.com \
    --cc=shengyong1@huawei.com \
    --cc=yuchao0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®