From: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
cros-qcom-dts-watchers@chromium.org,
linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/6] spi: spi-qcom-qspi: Add interconnect support for memory path
Date: Mon, 30 Mar 2026 10:13:17 +0530 [thread overview]
Message-ID: <721b870f-400c-40dc-b33f-0241252ca886@oss.qualcomm.com> (raw)
In-Reply-To: <92c58ea3-5492-4de9-bcf7-d4a419480002@sirena.org.uk>
On 3/24/2026 9:54 PM, Mark Brown wrote:
> On Tue, Mar 24, 2026 at 06:43:19PM +0530, Viken Dadhaniya wrote:
>
>> @@ -829,6 +842,13 @@ static int __maybe_unused qcom_qspi_runtime_suspend(struct device *dev)
>> return ret;
>> }
>>
>> + ret = icc_disable(ctrl->icc_path_mem);
>> + if (ret) {
>> + dev_err_ratelimited(ctrl->dev, "ICC disable failed for memory: %d\n", ret);
>> + icc_enable(ctrl->icc_path_cpu_to_qspi);
>> + return ret;
>> + }
>> +
>
> This reenables the ICC but not the clocks on error (which is a
> preexisting bug with the error handling if the other ICC fails but
> still...).
I will add proper error handling in the runtime PM path in v2.
next prev parent reply other threads:[~2026-03-30 4:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 13:13 [PATCH 0/6] Add QSPI support for QCS615 and improve interconnect handling Viken Dadhaniya
2026-03-24 13:13 ` [PATCH v1 1/6] spi: dt-bindings: qcom-qspi: Add QCS615 compatible Viken Dadhaniya
2026-03-25 11:12 ` Krzysztof Kozlowski
2026-03-26 9:07 ` Konrad Dybcio
2026-03-26 9:10 ` Krzysztof Kozlowski
2026-03-24 13:13 ` [PATCH v1 2/6] spi: spi-qcom-qspi: Add interconnect support for memory path Viken Dadhaniya
2026-03-24 16:24 ` Mark Brown
2026-03-30 4:43 ` Viken Dadhaniya [this message]
2026-03-24 13:13 ` [PATCH v1 3/6] arm64: dts: qcom: talos: Add QSPI support Viken Dadhaniya
2026-03-24 20:51 ` Dmitry Baryshkov
2026-03-25 9:32 ` Konrad Dybcio
2026-03-30 11:23 ` Viken Dadhaniya
2026-03-30 13:19 ` Konrad Dybcio
2026-03-24 20:52 ` Dmitry Baryshkov
2026-03-25 11:13 ` Krzysztof Kozlowski
2026-03-30 4:40 ` Viken Dadhaniya
2026-03-24 13:13 ` [PATCH v1 4/6] arm64: dts: qcom: qcs615-ride: enable QSPI and NOR flash Viken Dadhaniya
2026-03-24 20:53 ` Dmitry Baryshkov
2026-03-24 13:13 ` [PATCH v1 5/6] arm64: dts: qcom: kodiak: Add QSPI memory interconnect path Viken Dadhaniya
2026-03-24 20:54 ` Dmitry Baryshkov
2026-03-30 4:44 ` Viken Dadhaniya
2026-03-24 13:13 ` [PATCH v1 6/6] arm64: dts: qcom: sc7180: " Viken Dadhaniya
2026-03-24 20:54 ` Dmitry Baryshkov
2026-03-30 4:44 ` Viken Dadhaniya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=721b870f-400c-40dc-b33f-0241252ca886@oss.qualcomm.com \
--to=viken.dadhaniya@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®