From: Ivan Safonov <insafonov@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Michael Straube <straube.linux@gmail.com>,
gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "staging:r8188eu: use lib80211 CCMP decrypt"
Date: Wed, 2 Jan 2019 22:35:35 +0300 [thread overview]
Message-ID: <721d7c62-5119-f52a-6d5f-c3138654d0ae@gmail.com> (raw)
In-Reply-To: <2aab932b-b4ba-2601-06de-ca095a549fb7@lwfinger.net>
On 1/2/19 4:06 AM, Larry Finger wrote:
> On 1/1/19 1:31 PM, Michael Straube wrote:
>>
>> I've tested your patch and it solved the issue. No freezes and dmesg
>> looks good.
>>
>> I noticed that try_then_request_module() is also used in
>> rtw_wep_encrypt() and
>> rtw_wep_decrypt(). I guess that also could cause problems?
>
> Yes, I believe it would if anyone is still using WEP. My plan is to get
> rid of the try_then_request_module() there as well, and for
> completeness, I plan to restore usage of the lib80211 routines for TKIP
> as well.
Patch "load lib80211 crypto ops from interruptible context" (
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-August/124851.html
) is a preparation to replace
crypto_ops = try_then_request_module(lib80211_get_crypto_ops(*),
"lib80211_crypt_*");
with
(struct crypto_algorithm).ops
>
> Once I get a chance to test the TKIP and WEP changes, I plan to have a
> set of 4 patches to switch the driver to using lib80211 routines for all
> decryption/encryption.
There are four other patches to use lib80211:
use lib80211 CCMP decrypt (
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-February/116533.html
)
Use lib80211 to encrypt (WEP) tx frames (
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-June/122642.html
)
Use lib80211 to encrypt (TKIP) tx frames (
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-July/123249.html
)
Use lib80211 to encrypt (CCMP) tx frames (
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-July/123250.html
)
They all crash when try_then_request_module() called.
>
> Larry
>
>
prev parent reply other threads:[~2019-01-02 19:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-30 18:39 Michael Straube
2019-01-01 2:17 ` Larry Finger
2019-01-01 9:02 ` Ivan Safonov
2019-01-01 19:45 ` Michael Straube
2019-01-01 21:38 ` Larry Finger
2019-01-02 19:03 ` Ivan Safonov
2019-01-01 19:31 ` Michael Straube
2019-01-02 1:06 ` Larry Finger
2019-01-02 19:35 ` Ivan Safonov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=721d7c62-5119-f52a-6d5f-c3138654d0ae@gmail.com \
--to=insafonov@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®