mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dinh Nguyen <dinguyen@kernel.org>
To: "Ong, Hean Loong" <hean.loong.ong@intel.com>,
	Thor Thayer <thor.thayer@intel.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, chin.liang.see@intel.com
Subject: Re: [PATCHv1] ARM64: defconfig: Add LEDS_TRIGGERS_TIMER for blinking leds
Date: Mon, 1 Jul 2019 10:54:36 -0500	[thread overview]
Message-ID: <722335f6-1c39-5f1e-d5f5-8aa32626dc6c@kernel.org> (raw)
In-Reply-To: <20190627140709.707-2-hean.loong.ong@intel.com>



On 6/27/19 9:07 AM, Ong, Hean Loong wrote:
> Adding LED Triggers Timers for LED blinking support on ARM devices
> 
> Signed-off-by: Ong, Hean Loong <hean.loong.ong@intel.com>
> ---
>  arch/arm64/configs/defconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 4d58351..6fbd651 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -595,6 +595,7 @@ CONFIG_LEDS_TRIGGER_HEARTBEAT=y
>  CONFIG_LEDS_TRIGGER_CPU=y
>  CONFIG_LEDS_TRIGGER_DEFAULT_ON=y
>  CONFIG_LEDS_TRIGGER_PANIC=y
> +CONFIG_LEDS_TRIGGER_TIMER=y
>  CONFIG_EDAC=y
>  CONFIG_EDAC_GHES=y
>  CONFIG_RTC_CLASS=y
> 

I've applied this patch with this change:

--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -590,6 +590,7 @@ CONFIG_LEDS_CLASS=y
 CONFIG_LEDS_GPIO=y
 CONFIG_LEDS_PWM=y
 CONFIG_LEDS_SYSCON=y
+CONFIG_LEDS_TRIGGER_TIMER=y
 CONFIG_LEDS_TRIGGER_DISK=y defconfig
 CONFIG_LEDS_TRIGGER_HEARTBEAT=y
 CONFIG_LEDS_TRIGGER_CPU=y

Also, the commit header should be "arm64: defconfig".

Dinh

  reply	other threads:[~2019-07-01 15:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-27 14:07 [PATCHv1] ARM64: defconfig: Adding LEDS_TRIGGERS_TIMER Ong, Hean Loong
2019-06-27 14:07 ` [PATCHv1] ARM64: defconfig: Add LEDS_TRIGGERS_TIMER for blinking leds Ong, Hean Loong
2019-07-01 15:54   ` Dinh Nguyen [this message]
2019-07-02  0:31     ` Ong, Hean Loong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=722335f6-1c39-5f1e-d5f5-8aa32626dc6c@kernel.org \
    --to=dinguyen@kernel.org \
    --cc=chin.liang.see@intel.com \
    --cc=hean.loong.ong@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thor.thayer@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®