From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0FAA3AA516 for ; Tue, 7 Apr 2026 12:27:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775564840; cv=none; b=KEpijhlpTvZP1Ukxpq9CfY8+ifQdqhIkG82ae6k/v8O8gHkD1tZpnl15k6q75jYN+PawKkyaZ7ZZteW7O4Wt2u2m5Fosj5a2CZ96uY1Tn3A6BleEjgWv1NApxYknbMX1QutuJEN/cobhS6tzIb69IGcCSWCvVp9+Mg8Xp0fH50A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775564840; c=relaxed/simple; bh=PGfxzkueR3nRx1WShdZvaow/9FylWih2gh4HXYnQKuM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=saAsXzTIc78cxqZ7/YI4/OHFtzqziLNLy2y54RJ+i+Xh9IDivMwpnfkPsn8rfEEOuGNIr+AczCF2kWmQ3crFwXXm01Tg1kwvowEoJ1sHpuBis0HbFtRCYS37MxYBHpIaGasUU4xCVReM91/6giHtDBqkyJdCLHyqzj+tSYUnF4I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KcKAzBGu; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PYHZNZCy; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KcKAzBGu"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PYHZNZCy" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 637BWlrC2581367 for ; Tue, 7 Apr 2026 12:27:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= DQ/FbsFha5BP0Qq1tyZZGZ3cnWFodwIbFLgBI/EBXAY=; b=KcKAzBGuA+uNFqh1 GUHpbNgWwIoGNOKORSUj3iVxVDVXXJ1XXA0wQapsFX2AcdjsbZra9geP0hmLaSaR V3aroWBEhwHEC3qI4zVaKoFXYq1r82xzdaZarJfxey02dAKR4b6SGQbsywjI9VMG gM8tBry3lyZODzTzGOaawTz08sAtd7eOr9djkmht6TahjmhNxomg9NooXhBCBqnW hmiNhF+rJ5rijbqYzF8Fra8momDu2k5RPfUA76f1y8ZAPLyWACHY7QzpinaTWT8v F45rNtozzpa9okshLJqFFLvv4txyuZ32bipbBkoP4lVfBRL7kBWFKSCQUIuwJKBX /R7fvA== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dcmsf2pjs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Apr 2026 12:27:12 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-50d8c183c2eso19409941cf.0 for ; Tue, 07 Apr 2026 05:27:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775564832; x=1776169632; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DQ/FbsFha5BP0Qq1tyZZGZ3cnWFodwIbFLgBI/EBXAY=; b=PYHZNZCyi6OwmEHQDlvc+RSHEMVCPodRL053WNBQksavqGxMFU1+17e43ngC/l1ZhU ZVYiNZuTw2BCWd3sDHizVeADCOAYpR7q/I6QrfXz6Ovcwif+96cVmSFr7w5eQ9eaNTi2 nYZa2DpweedUXY3AFxX7jwssjZ9gdjeDlg8PiMS6kaDYtGQcXjfLA87UhnFTMicGNlaQ uteeVKsgj8BEolK4JVutVkch1To2kgzNBb5TW9gtdffpRDFyJEGQ1w3Mb50Zn8mJ4Qky VGrm2S+N3QLW2Ye0qr8xgWUO9iDvJuUBcfQ3jRMwlmq5dSaqrWitR1DY/2xdLegsn3eC uh1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775564832; x=1776169632; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DQ/FbsFha5BP0Qq1tyZZGZ3cnWFodwIbFLgBI/EBXAY=; b=PSLvfpyS3B+PN1PW4Bjg7dT89Gd5v7U3pa1w6rol9HYhUOMJzsN3O6MGkzs78FOUj+ TYMbe30T93awhEnyyVDkbAFf7qu2CO+UkJxCyA7xzf/Aup1nAAU6U/VC9uhBijVVkGqK FACuY8KXgEMU0xCk0secLDOQIv83Owsobae+1YNgW13USszxXtOqQT0cGTy+Iooelx+y MHgkOJYisXex/NHjPh1YsfjzCJUYAHZXe/vMWywjzHWJwLzQZMZGlege0fy24ef0KrNB cBn2JadQGPijDzk2evYZFqTI3xdccFrXjIZpOI+sbNQTl0TxmtkIIYp0ebwKj6UOFHOc kbjw== X-Forwarded-Encrypted: i=1; AJvYcCU8dEBTz0VARlH5ZVBSwnNpTbjgQz99bQJiDWFStuegAE0+HJ7rM1dEcWuAa+soynHOvyWVmXByLGR2jdg=@vger.kernel.org X-Gm-Message-State: AOJu0YxY6pXurdPLZTW9728mzPFjHZ6FjvVAyxCBk89nSPG9SVBneRKq 46rPmW4K2LwUJIPd/31ufcRgILI/06sxi+Prqk1pNMx5tU+KbRxy3wclL3ROLD6i8qeQjgqH51p EwFhjRcd3lPmuB9Coayqxm4zCATZmSZdmBolFnzkuNuYppC6JTiXFGYwNhWrnOhB2H28= X-Gm-Gg: AeBDiev+MTRkQ5jpyYaXb+34V2e9NCFYu+wMkW8eSH1B5L8hdQ8mE+5tAnyom/9pLZQ 1dYMFfpSgfFOKD4QdXR2vGvdCG+WcLpgUhABj9YAjFoaXdoUu5cp0fF1+wDJENy5Lm/yMxi5Ed0 uZMXsf9/WB5lsZuwYK4TzORB8JQq9CMLP/sHJYCrCb9h4l7FNvJ1hFEPoykvogFatbJWhqKezRz jag+zjCSni2xnF6cigxMeyQNaN3Z6KK0VDANwCMcR6fTSL4z2iBDhePHR2f4qLx7bcuzCH/gb10 u+aIOeyME42y+KtSK1y57KaxfFFrxvtwTw0NMg+NwwfyaZ/pBWgKX7dXLhdyFU8pUAL9HqipBj0 CPilsovhy5IcAQAmR1Une1qNGftvJ8lVk7bJUC91e12yys78fqyewyrtqJ+nan2pnaSE5dzCm5h a4Nq4= X-Received: by 2002:a05:622a:15d3:b0:501:4767:a6f with SMTP id d75a77b69052e-50d62c47a06mr180545751cf.3.1775564831680; Tue, 07 Apr 2026 05:27:11 -0700 (PDT) X-Received: by 2002:a05:622a:15d3:b0:501:4767:a6f with SMTP id d75a77b69052e-50d62c47a06mr180545411cf.3.1775564831264; Tue, 07 Apr 2026 05:27:11 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9c3cff19c0sm547473366b.48.2026.04.07.05.27.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Apr 2026 05:27:10 -0700 (PDT) Message-ID: <7223c10f-6298-472f-97df-8753b8935598@oss.qualcomm.com> Date: Tue, 7 Apr 2026 14:27:07 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/5] PCI: qcom: Add D3cold support To: Krishna Chaitanya Chundru , Jingoo Han , Manivannan Sadhasivam , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Will Deacon Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jonathanh@nvidia.com, bjorn.andersson@oss.qualcomm.com References: <20260311-d3cold-v3-0-4d85dc7c2695@oss.qualcomm.com> <20260311-d3cold-v3-5-4d85dc7c2695@oss.qualcomm.com> <4a18abf4-32b0-40c0-bdd1-81ea819c4089@oss.qualcomm.com> <38f51e0a-fef4-46b5-84e3-0138cc5f79c5@oss.qualcomm.com> <2d193ac6-619c-4cd7-b0f1-39f5aa1ec02b@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <2d193ac6-619c-4cd7-b0f1-39f5aa1ec02b@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA3MDExNiBTYWx0ZWRfX/wkAdHWlKX4R yrUfST7uhaexQDizdKpLtSkTt8nyP/UcPrCU3es8ZneH8wKbC+4FGAiuwhlgIdLijhb7YE8wzSt QmYGTTl1EbTPAocjLQzyheGj0LQyof00Y2yiZKBK115s4u9emFcq0YociGI8HNnJmcYxy7g1Apb wVNZOwBkqX4Lf3KplWfWADMQQ8EWYGtid6dWbmISNp5Rx7JYK1XZZX8sWioMDwaqSXFbTYsADsT MY8+5ibrrf9eWXItS7linzKs7q2HCyJMeP/OrypRn6YpNxV0HYE+IbMB8qugNmsJkbjuLwyEC1W +jEZMcSoM7rNC/LNvh+LNlzb2UvQ7qLyCGIHhvnVx4+rc/qoY9Po5DHSEMh8PANI8yYFcRTZHKz 26v7F5/3xNSJXhloFBboy/6RAeBOxtBgtH24CdOPpo62KWJHIABCSfYSfM2Hj8dT45qzDLqhpYF tfl9PS0aglfm6V9fV5g== X-Proofpoint-ORIG-GUID: xGGYgMBXXwzNeKVQ61lrgoN0fxXLq1b0 X-Proofpoint-GUID: xGGYgMBXXwzNeKVQ61lrgoN0fxXLq1b0 X-Authority-Analysis: v=2.4 cv=DcInbPtW c=1 sm=1 tr=0 ts=69d4f820 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=ZCbfbMl1FPzj5El2ZOUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-07_02,2026-04-07_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 spamscore=0 phishscore=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604070116 On 4/7/26 1:37 PM, Krishna Chaitanya Chundru wrote: > > > On 4/7/2026 5:06 PM, Konrad Dybcio wrote: >> On 4/6/26 11:08 AM, Krishna Chaitanya Chundru wrote: >>> >>> On 3/17/2026 2:45 PM, Konrad Dybcio wrote: >>>> On 3/11/26 11:26 AM, Krishna Chaitanya Chundru wrote: >>>>> Add support for transitioning PCIe endpoints & bridges into D3cold by >>>>> integrating with the DWC core suspend/resume helpers. >>>>> >>>>> Implement PME_TurnOff message generation via ELBI_SYS_CTRL and hook it >>>>> into the DWC host operations so the controller follows the standard >>>>> PME_TurnOff-based power-down sequence before entering D3cold. >>>>> >>>>> When the device is suspended into D3cold, fully tear down interconnect >>>>> bandwidth, OPP votes. If D3cold is not entered, retain existing behavior >>>>> by keeping the required interconnect and OPP votes. >>>>> >>>>> Drop the qcom_pcie::suspended flag and rely on the existing >>>>> dw_pcie::suspended state, which now drives both the power-management >>>>> flow and the interconnect/OPP handling. >>>>> >>>>> Signed-off-by: Krishna Chaitanya Chundru >>>>> --- >>>> [...] >>>> >>>>>           ret = icc_disable(pcie->icc_cpu); >>>>>           if (ret) >>>>>               dev_err(dev, "Failed to disable CPU-PCIe interconnect path: %d\n", ret); >>>>>             if (pcie->use_pm_opp) >>>>>               dev_pm_opp_set_opp(pcie->pci->dev, NULL); >>>> Does calling .suspend not drop the vote by itself? >>> No, unlike genpd framework for power domains, opp votes will not removed as part of suspend. >> Hm, I would imagine the power vote goes down.. is that the ICC vote >> that's still hanging if we don't do this? > yes, ICC votes are still present OK, thanks for confirming Konrad