From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753721AbcD1Jyw (ORCPT ); Thu, 28 Apr 2016 05:54:52 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:54164 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753389AbcD1Jyu (ORCPT ); Thu, 28 Apr 2016 05:54:50 -0400 From: Arnd Bergmann To: Sagar Dharia Cc: gregkh@linuxfoundation.org, bp@suse.de, poeschel@lemonage.de, treding@nvidia.com, broonie@kernel.org, gong.chen@linux.intel.com, andreas.noever@gmail.com, alan@linux.intel.com, mathieu.poirier@linaro.org, daniel@ffwll.ch, jkosina@suse.cz, sharon.dvir1@mail.huji.ac.il, joe@perches.com, davem@davemloft.net, james.hogan@imgtec.com, michael.opdenacker@free-electrons.com, daniel.thompson@linaro.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kheitke@audience.com, mlocke@codeaurora.org, agross@codeaurora.org, sheetal.tigadoli@gmail.com, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH V5 2/6] of/slimbus: OF helper for SLIMbus Date: Thu, 28 Apr 2016 11:54:02 +0200 Message-ID: <7224042.xJrLyG5lxh@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1461801489-16254-3-git-send-email-sdharia@codeaurora.org> References: <1461801489-16254-1-git-send-email-sdharia@codeaurora.org> <1461801489-16254-3-git-send-email-sdharia@codeaurora.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:NDaOtkXAoo521x194TmLDdZLHKExMOrbAk/T/KZkG/2PfXHuGIN n73pqerUPXNI7snHMHw8LB+Bz/Dh/AEDTWQ/ydg/vXyy1dVL6zUcQ0Dma+zK0IKF5BKe8jY UVRPxX6O8V9RSY8JfSoGSWEYqwbjp5mOCajHRuckW7eW4uWEvacqqCI43JpMv/0xGd0/Y01 hVuyhMGOeq44jDlzS89/A== X-UI-Out-Filterresults: notjunk:1;V01:K0:B6VPuzpbiMM=:o5qrtFxpUPKhItpepSuxSq RxmFe88byJauMbPI0VAPgBtl4xKKcdgeiZ0DTeUOtuFQyJRV2Ax6OwP7wlNhBWSNgVjA1e+UC KSg27DXBelidVVIkvOzQwwbkQRZvhRHrksKtoadhEb0ZQAvgmWss/IYyLJJt2aZaQ1s/ifj9H OUfLHa1U786S9S6avmj8A0YpbqSkk5z3LJUsEbffSUL6hagwfZHiqq1LSavfz7Rb1IEbl8h7h 7ssshJlqBxiAGx46bURAln04dOdNwU37dh5BHl+yMSe6/yx7xi1HSZIQq1IBPnqSOHnFjs82N Rat7WE2VcEBCgthK+GkkKD8ZxGZkLrDobbdptkFued+swtaNMaA8VNYxkeDrq9bpQvEc+0l3R 75GXUfYYMYbe8EI5j3GjmvGRqe5bErUyxBG4VPnAYedOGwo4MKaHp0jddootDnMlz7mWbS84c beb01XwSpzOS4WgyuDHQLyuHZf+FkzqAGmiyKSYFkzhoLOOalYoB2W3OFm/5rKfyOj/HrF+0s dmzhYB1eewzrdz4JA+MKE3youvA+n+1GOmIuc9QDZppvSPL9mrChXEOT7krZAWaU8CmFsNldx wFf8zplud4G+npE4x9gFFBQ8k2UrgypekbiNmZxx8dVDEZsscVMbTHSPJpPx/fXx97+Q4wMIu dQhB4FTuIHMbA8vOzjHlOdesjz42naPn/xr7Qy44YlgxAnA9YYTlQsUVQwCgjcmOfY9DoaRP+ AyMxUUj5fi6JuBnZ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 27 April 2016 17:58:05 Sagar Dharia wrote: > +#if IS_ENABLED(CONFIG_OF) > +/* OF helpers for SLIMbus */ > +static void of_register_slim_devices(struct slim_controller *ctrl) > +{ > + struct device_node *node; > The #ifdef seems useless here, what kind of system would not have CONFIG_OF enabled? I'd suggest merging this into patch 1 and removing the conditional Arnd