From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751749AbdKVPuT (ORCPT ); Wed, 22 Nov 2017 10:50:19 -0500 Received: from mout.web.de ([212.227.17.12]:55666 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751292AbdKVPuS (ORCPT ); Wed, 22 Nov 2017 10:50:18 -0500 Subject: [PATCH 2/3] ASoC: cs42l73: Improve two size determinations in cs42l73_i2c_probe() From: SF Markus Elfring To: alsa-devel@alsa-project.org, Brian Austin , Jaroslav Kysela , Liam Girdwood , Mark Brown , Paul Handrigan , Takashi Iwai Cc: LKML , kernel-janitors@vger.kernel.org References: <609e2542-4750-fe60-4f42-08bca79bfb56@users.sourceforge.net> Message-ID: <7229b291-d1e3-6269-4c68-435bbdffb0fd@users.sourceforge.net> Date: Wed, 22 Nov 2017 16:49:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <609e2542-4750-fe60-4f42-08bca79bfb56@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:muTGR72hCiSB9UYPTIK/5TawrWq0N7isZxU2xR4Pq5N8NtdgsT1 exTkUs4wqz4E+/UEgibP6TrQG0BhfVDOxCFgitVm/Fuf8aQIqkZNmqtjenH5dF7ksG63zGU jTxLasYl6SqvQ9wuaFmXZb8/F3iSoVQ+ppiaVMRgFitdDJOWocb/jRR6zxj9bM3SOy2TtVl aZz5gvp3qLsWY7oaB72cg== X-UI-Out-Filterresults: notjunk:1;V01:K0:VivJhIbpztY=:4Np56tCPB3VJBGrjMObtcI po2cIEV1Bsg+lSEnHCplMDIdOb4J2dVUgUyDGoeMFJeMBEiCO7GpUDfHR46eADyyZ66glBNUh V7upvnQpc0xcDa0QlqxYrMjLFA1d2N0CQ7RxTv3u1+Ko9cxKnB8U5j9/6FQgohSCqIn+fPrqx CQJccyGECqiDU7OvnmDmkr7icLScKIAVqDkRO9P6JRVfdsJYkTxpuUJvkNmH910I/7OiYAMpZ xjRf3Q0JVlOiKe/1+ibEqS0tqHZU2Kb3obqvjEB5Kx+qiVmZi4SmhbuslM8ascqA+1pjynFPg X7onJFOVGTS6eUo04nz+fXp0acS7LLeR6XUaj8UDfjXI4v5ou4NHldo847PU9HZ3ILIeH8rNU LmsdLqwZrV01BgXau1wvEoi8lrP3AjaH1DOXshNjoqUAFv8yae44azy+LoXZrYaXkhwG7jHtG mc+P+gxagJBC6pT0DbBfNyzJWvlk3m4QniNLIQamdyQE5Td1doSAWLSiKF9JiEMlKZ9IBzuox kNwMWiICO9uQaQJFr9i45/cJMghxTGmJWu03I2tNV4Ld4SZ+eYccPVAPn+RVTwjux2G1GiYna ILQEE7jtl66PS/yHq1RkKmHXc3oK2Xbz9QG6NfSpXOhl1m/ZNPc3ySjIA16TmWdzOpp4t0NgP MgNDlDNbEW1VAgfoOc6knK4IDWRMEnl27n8x5q4qQq6rJ+RX/FV71Jf4pHc+C3G7+6IvxWhYc /AD2ZEb84MaGC5d8Qza7bBN0NfJ2pxq430ywTvjaYP2RcQejnP1jCjiTXF+a9O8Ju8dgGKhqP 6IGZnyI7nbMPIrsansOiCe9fP8ErVaDN+7OTmZ2h6xD8+FTq8M= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 22 Nov 2017 16:07:42 +0100 Replace the specification of two data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- sound/soc/codecs/cs42l73.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/cs42l73.c b/sound/soc/codecs/cs42l73.c index 978cfbbad408..dde37e569ade 100644 --- a/sound/soc/codecs/cs42l73.c +++ b/sound/soc/codecs/cs42l73.c @@ -1289,8 +1289,7 @@ static int cs42l73_i2c_probe(struct i2c_client *i2c_client, unsigned int reg; u32 val32; - cs42l73 = devm_kzalloc(&i2c_client->dev, sizeof(struct cs42l73_private), - GFP_KERNEL); + cs42l73 = devm_kzalloc(&i2c_client->dev, sizeof(*cs42l73), GFP_KERNEL); if (!cs42l73) return -ENOMEM; @@ -1304,9 +1303,8 @@ static int cs42l73_i2c_probe(struct i2c_client *i2c_client, if (pdata) { cs42l73->pdata = *pdata; } else { - pdata = devm_kzalloc(&i2c_client->dev, - sizeof(struct cs42l73_platform_data), - GFP_KERNEL); + pdata = devm_kzalloc(&i2c_client->dev, sizeof(*pdata), + GFP_KERNEL); if (!pdata) return -ENOMEM; -- 2.15.0