From: "Youghandhar Chintala (Temp)" <quic_youghand@quicinc.com>
To: Kalle Valo <kvalo@kernel.org>
Cc: Jeff Johnson <quic_jjohnson@quicinc.com>,
<ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] wifi: ath10k: Add WLAN firmware image version info into smem
Date: Tue, 1 Nov 2022 14:38:22 +0530 [thread overview]
Message-ID: <722d3571-b399-dbf0-26da-04b73331df49@quicinc.com> (raw)
In-Reply-To: <877d0fgiaa.fsf@kernel.org>
On 11/1/2022 2:31 PM, Kalle Valo wrote:
> (fixing quotation)
>
> "Youghandhar Chintala (Temp)" <quic_youghand@quicinc.com> writes:
>
>> On 10/28/2022 12:19 AM, Jeff Johnson wrote:
>>
>>> On 10/26/2022 3:22 AM, Youghandhar Chintala wrote:
>>>> +static void ath10k_qmi_add_wlan_ver_smem(struct ath10k *ar, char
>>>> *fw_build_id)
>>> const char *fw_build_id?
>>>
>>>> +{
>>>> + u8 *smem_table_ptr;
>>>> + size_t smem_block_size;
>>>> + const u32 version_string_size = 128;
>>> should you s/128/MAX_BUILD_ID_LEN/ since that is what is used to
>>> size qmi->fw_build_id?
>>>
>>> or alternately have the caller pass fw_build_id length as a separate
>>> param?
>> Sure Jeff. Will address it in next version of patch.
> BTW Youghandhar, your quotes were broken in this mail so your reply was
> difficult to find. See here:
>
> https://patchwork.kernel.org/project/linux-wireless/patch/20221026102257.19919-1-quic_youghand@quicinc.com/
>
> If you are using Outlook, I recommend switching to an application which
> respects standards more :) For example, some people seem to be happy
> with Thunderbird.
Thank you so much for your suggestion. I will address it.
Currently I am using Thunderbird.
next prev parent reply other threads:[~2022-11-01 9:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 10:22 Youghandhar Chintala
2022-10-26 12:11 ` kernel test robot
2022-10-27 18:49 ` Jeff Johnson
2022-10-31 6:54 ` Youghandhar Chintala (Temp)
2022-11-01 9:01 ` Kalle Valo
2022-11-01 9:08 ` Youghandhar Chintala (Temp) [this message]
2022-11-01 9:29 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=722d3571-b399-dbf0-26da-04b73331df49@quicinc.com \
--to=quic_youghand@quicinc.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®