mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Palash Kambar <palash.kambar@oss.qualcomm.com>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: James.Bottomley@hansenpartnership.com,
	martin.petersen@oracle.com, linux-arm-msm@vger.kernel.org,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	bvanassche@acm.org, shawn.lin@rock-chips.com,
	nitin.rawat@oss.qualcomm.com
Subject: Re: [PATCH V6 1/2] ufs: core: Configure only active lanes during link
Date: Thu, 23 Apr 2026 15:31:31 +0530	[thread overview]
Message-ID: <722eb005-351e-40a1-af8c-c6cd01fb168a@oss.qualcomm.com> (raw)
In-Reply-To: <we5guwh4bayq2fertkfsh27ykkzz4h2owzt5wjiezn2yzfjpni@77a3xpe6in2l>



On 4/23/2026 1:34 PM, Manivannan Sadhasivam wrote:
> On Thu, Apr 23, 2026 at 11:29:13AM +0530, palash.kambar@oss.qualcomm.com wrote:
>> From: Palash Kambar <palash.kambar@oss.qualcomm.com>
>>
>> The number of connected lanes detected during UFS link startup can be
>> fewer than the lanes specified in the device tree. The current driver
>> logic attempts to configure all lanes defined in the device tree,
>> regardless of their actual availability. This mismatch may cause
>> failures during power mode changes.
>>
>> Hence, Add a check during link startup to ensure that only the lanes
>> actually discovered are considered valid. If a mismatch is detected,
>> fail the initialization early, preventing the driver from entering
>> an unsupported configuration that could cause power mode transition
>> failures.
>>
>> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
>> Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>
>> Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
>> Signed-off-by: Palash Kambar <palash.kambar@oss.qualcomm.com>
>> ---
>>  drivers/ufs/core/ufshcd.c | 35 +++++++++++++++++++++++++++++++++++
>>  1 file changed, 35 insertions(+)
>>
>> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
>> index 31950fc51a4c..fe5bc85c6870 100644
>> --- a/drivers/ufs/core/ufshcd.c
>> +++ b/drivers/ufs/core/ufshcd.c
>> @@ -5035,6 +5035,37 @@ void ufshcd_update_evt_hist(struct ufs_hba *hba, u32 id, u32 val)
>>  }
>>  EXPORT_SYMBOL_GPL(ufshcd_update_evt_hist);
>>  
>> +static int ufshcd_validate_link_params(struct ufs_hba *hba)
>> +{
>> +	int ret, val;
>> +
>> +	ret = ufshcd_dme_get(hba, UIC_ARG_MIB(PA_CONNECTEDTXDATALANES),
>> +			     &val);
>> +	if (ret)
>> +		return ret;
>> +
>> +	if (val != hba->lanes_per_direction) {
>> +		dev_err(hba->dev, "Tx lane mismatch [config,reported] [%d,%d]\n",
>> +			hba->lanes_per_direction, val);
>> +		ret = -ENOLINK;
>> +		return ret;
> 
> Really? If you had spent a minute in reading the patch after writing, you
> would've seen this obvious mistake.

Ok Mani, will update this. Thanks.

> 
>> +	}
>> +
>> +	ret = ufshcd_dme_get(hba, UIC_ARG_MIB(PA_CONNECTEDRXDATALANES),
>> +			     &val);
>> +	if (ret)
>> +		return ret;
>> +
>> +	if (val != hba->lanes_per_direction) {
>> +		dev_err(hba->dev, "Rx lane mismatch [config,reported] [%d,%d]\n",
>> +			hba->lanes_per_direction, val);
>> +		ret = -ENOLINK;
>> +		return ret;
> 
> Same here.
> 
> - Mani
> 


  reply	other threads:[~2026-04-23 10:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-23  5:59 [PATCH V6 0/2] Add post change sequence for link start notify palash.kambar
2026-04-23  5:59 ` [PATCH V6 1/2] ufs: core: Configure only active lanes during link palash.kambar
2026-04-23  8:04   ` Manivannan Sadhasivam
2026-04-23 10:01     ` Palash Kambar [this message]
2026-04-23  5:59 ` [PATCH V6 2/2] ufs: ufs-qcom: Enable Auto Hibern8 clock request support palash.kambar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=722eb005-351e-40a1-af8c-c6cd01fb168a@oss.qualcomm.com \
    --to=palash.kambar@oss.qualcomm.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=bvanassche@acm.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=nitin.rawat@oss.qualcomm.com \
    --cc=shawn.lin@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®