From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04F8B324B38 for ; Tue, 17 Feb 2026 11:01:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771326073; cv=none; b=clylTKN7jEvAspKDy0HNcodB8UBH+xvaEZW7KdypyfV/1aIvUiWJLeZHCiXmSzG7GYjEGO6tjOy1AEkhfGY7jAzpHs6nRlzKHwT36EBeMkZzRyZqXdNTOG6v/Q4xBsUvdOPKtE6L8m2xTPv3ugauHzdMIyfYL33Ho8dbnAREK20= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771326073; c=relaxed/simple; bh=TgP4eIL2o3Br0ZpQFwhQ+40TY+blI4J5W7HKlZRoZso=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RH6595zKpeCNnrPUHcDBo5UJW2vN6ZckMaw7bdL7nd3wnApG39pQkeN74g6fT5+EMpp+FpEN+iL1BCij874MB9DeoeUyZMvOf2EJnGc3UI6z+hLh8G06ogM8OSFz2yLLMe3PN6UXSbchgDNRXGcaC0pKHU4HiVyx6WfUWr9HLGI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AQ6ZQS63; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CIsf20jY; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AQ6ZQS63"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CIsf20jY" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61H8lgas1601370 for ; Tue, 17 Feb 2026 11:01:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= a/MmwzlzQwA4NZGjD9k+8lgzrwfTbajopFzs7MjCYkc=; b=AQ6ZQS63FTGad4IQ sfYXPtYeq0a+fsi7ei5vswvpo+2W3qWPkdanCi3yWTRwwz6G89JG4LKtiz8WE0B1 FQKdLmX3xC3qq+gI8aA7GZCzjG2Ilckz18I94GM5cFVBgdSsRlp6vVcqoD+LtkdY OCCHAZZb4azywH10yyTrCMCOtjm83RwA7SBaOFDeQ0vDsgiWYOxX/0iJdXmlRjFE VQOUcBxC4Vm9qfaDPzIJBL3qsAKe7zUy2fkec4EaFL+Twhm9wIUxCMmtghRO/dqQ kF9UW6lfHTiHy8eAxoN8OK2eI1j02GBlF0xU//r3KZm3CIhAiOiUa2NHk4MUD/Cu Skz30Q== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cc6tm9xhp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Feb 2026 11:01:10 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-8946c23cf90so32490066d6.1 for ; Tue, 17 Feb 2026 03:01:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771326069; x=1771930869; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=a/MmwzlzQwA4NZGjD9k+8lgzrwfTbajopFzs7MjCYkc=; b=CIsf20jYPoFH06lLNN2a+Tf/lrZSQKSnR7SUznliryzTx7bO9LlUz4bIKLcdtJlYzj cRXPaMcR/SHBss8bXc3R5k6E1KJLm8zUmoemcjmblPtJExfcrghuk43W51swGpn20GZq pkHvz/nh4C1fgLTp9hMnE0Pw1/LC5+BbaxmDjVatwn1W/QrD7Fo3yQ1LcO1OwIvn4m2s 8dfvFSlNULX9RT9EuhamPr4zwstf+Y54YrAwFVqW3AClGG/jmX/fjeJ1eOVoEFrOXwC8 4AqVgR6njUN7yRZ5VyZ3MIYq1QzL6lWGKiDc+AXcJem3eDTK85iGKDwtgB71qnM3MsNo 45Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771326069; x=1771930869; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=a/MmwzlzQwA4NZGjD9k+8lgzrwfTbajopFzs7MjCYkc=; b=NkQDy7AWQ2lHyvAtFCkY4oZnbNXH838hzKJylmiGETXU66lb3db0jELtVuQcdDLDb0 8oQXdJgkCJhh2yXmNq7xDTYwQTDyaJe9GqPfKLj4Yc8t2nvvFlOz+DfaHUwXTQqtfg14 bZwFuyk0qFLvdUSG7n1QnPusaVEKnCYvRqzUmI6NRx4HCmsuYiSOiycKXAaHA9p7flCn xGyg4NBv9hd7hxkvItjfHmmeqoewGqvxqfjYyDzR4a2iNOiGxTSJ32GRvbWM87ru1bTg hCEDgn5CQfE2UDisCY3ViFmUTIRHpLhhC82+emHjl7CJXYW46bs1YDX6IHcir6AKyfyi Fxuw== X-Forwarded-Encrypted: i=1; AJvYcCU6EPy18K5MwoVyNpKEwOFhFlIK9jT0lmR55CxhF47uYA50lpJ3/thc2hJLwDJdEmiUDbK8Afn4p+V/Sfc=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+cPa1mEVaOVVLMn1sVjcoKLMSlDZP5xZkJJNMbRLkN26g4Lkg JSNCvFQ3mx3Y3eKZA6SV3xf0YZ/1Luh8pysvecFTvfGd/sgQxPUdc/18a4S/qf5ow0pDFvIPOHB wfNakujKHAldBe4BLobY/AIZi3xLVljYCyyOwcDVCohoNdVHfPFXhHZ3nAB4a34iKErg= X-Gm-Gg: AZuq6aK3QJBizFzagiwGG7iYo+wz0M2crPIMnRAvkJQAUVV8BAcv9aT6PBB2KCevCMS 1GSMp6UzILJhUaviQMjV+bQrIv2grpgH1yJ64/cwX73PSUNRrlz2lM/MwJ8KJ4wZXuAkeJ90OzT pKs/bk7CIzgc4aJkRL31HYkT0jiAaNEzjsaOoj6f/gy9cov2yFhuPMlEOU0uLl+aPaOCAn6VdDn 0ctwJWMSKVunsFjMoFNGn3B55mpsq+/ZgKEmPRRtc8+//c2aYd2yif3iQk2NkKHgSoHd0VhXK51 QFuNeIMmRgvAxK1bWUgdUvpy3NbDQfwkQEAopmvqyrg/DQGdrDA3YdXgldEvqqjWSdmEOSjUBp6 BOeIaooHUiL4M5PHvy4N5xpu0OFNBbS8ZOAagUxxs3pG+Rw9RiNB4XxKZ9CRH5zlTniZuJ5rJo+ KqbtY= X-Received: by 2002:a05:6214:55c6:b0:894:a36b:f7df with SMTP id 6a1803df08f44-8973480967fmr128481656d6.8.1771326069393; Tue, 17 Feb 2026 03:01:09 -0800 (PST) X-Received: by 2002:a05:6214:55c6:b0:894:a36b:f7df with SMTP id 6a1803df08f44-8973480967fmr128481366d6.8.1771326068897; Tue, 17 Feb 2026 03:01:08 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8fc7627fa7sm345474666b.38.2026.02.17.03.01.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Feb 2026 03:01:08 -0800 (PST) Message-ID: <722f1bb8-250c-4cf6-b409-05f0090330b8@oss.qualcomm.com> Date: Tue, 17 Feb 2026 12:01:06 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] arm64: dts: qcom: milos: Add WCN6750 WiFi node To: Luca Weiss , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alexander Koskovich , Jeff Johnson Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20260116-milos-fp6-bt-wifi-v1-0-27b4fbb77e9c@fairphone.com> <20260116-milos-fp6-bt-wifi-v1-3-27b4fbb77e9c@fairphone.com> <5fe80f4a-ef5c-4008-88e2-60ad1f8c2a18@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: hSqMeTlWV1Z7mZJERTPYtxU7OnLSvmzG X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE3MDA5MiBTYWx0ZWRfX3EgiHLn/Ln/j HrXWFaBLMDUEYnOqXC+eqAOXrfNwqvDZ6nyTOmFbyQsbwf3lr/YlDzdYh2wUX/jvn79pAeNuEyX OEjRAt78rsml+zH+t8qfCtw+BL1nIyujUO7v+O5tmr53MSkesN0Dt7pi+sMakto1jFeQ+7LENm7 bTn95Nr3calfQZdUJKCB4W+JJ+FWryx0skPIRxIEFnGQO/9bOboqnN+r8pcpyfclLSRpVXojcsE y5hVb6G0/19V0I9B+fWTZoqIYKo8S1lRDNoaRcGyPlMy+2b02Nb77XAsNn+YLA+MzlBr91Mmnwc WgfyBgXoZAyIgVO+8ZfzPok861L1ni1uWzUoRtEnH9VEKVv5p7pIEUDeEaMi569tgEFulJGaJD0 3NWZ7rO3SdgNp2xCNZne2Vkjoc+AbvK5bNh0riC0mEcExL9pX2NfvESHUH42zKT4A7Pw30/UJP2 EH8BtgJ/tK5Pm+D0JMg== X-Proofpoint-ORIG-GUID: hSqMeTlWV1Z7mZJERTPYtxU7OnLSvmzG X-Authority-Analysis: v=2.4 cv=IOoPywvG c=1 sm=1 tr=0 ts=69944a76 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=6H0WHjuAAAAA:8 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=BzWC11Xf9Xekc_JAJjkA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 a=Soq9LBFxuPC4vsCAQt-j:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-17_01,2026-02-16_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 suspectscore=0 malwarescore=0 bulkscore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602170092 On 2/13/26 2:42 PM, Luca Weiss wrote: > Hi Konrad, > > On Tue Jan 20, 2026 at 3:39 PM CET, Konrad Dybcio wrote: >> On 1/16/26 3:50 PM, Luca Weiss wrote: >>> Add a node for the WCN6750 WiFi found with the Milos SoC. >>> >>> Signed-off-by: Luca Weiss >>> --- >>> arch/arm64/boot/dts/qcom/milos.dtsi | 46 +++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 46 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/milos.dtsi b/arch/arm64/boot/dts/qcom/milos.dtsi >>> index 024e1c9992fe..80feb3e9d3e2 100644 >>> --- a/arch/arm64/boot/dts/qcom/milos.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/milos.dtsi >>> @@ -2043,6 +2043,52 @@ gic_its: msi-controller@17140000 { >>> }; >>> }; >>> >>> + wifi: wifi@17110040 { >>> + compatible = "qcom,wcn6750-wifi"; >>> + reg = <0x0 0x17110040 0x0 0x0>; >> >> This reg doesn't.. sound.. very.. good.. >> >> The size being 0 is of course wrong, but perhaps more interestingly >> the base address is a register within the GIC.. >> >>> + iommus = <&apps_smmu 0x1400 0x1>; >> >> And this is a PCIe stream >> >> But I see kodiak has the exact same setup.. >> >> After digging a little into the driver, that 'reg' is apparently >> indeed consumed, as a base for PCI MSIs.. I feel like there should be >> some better way to express this.. non-everyday setup >> >> There's this commit message: >> >> commit 00fd24089b8154ddf5b3e724e2c4c9974b9ba91e >> Author: Manikanta Pubbisetty >> Date: Fri Apr 29 22:34:54 2022 +0530 >> >> dt: bindings: net: add bindings of WCN6750 for ath11k >> >> WCN6750 is the WLAN chip on Qualcomm Snapdragon SoC SC7280; >> Though being a PCIe based solution, it is not attached to >> the APSS processor (Application Processor SubSystem), it is >> instead attached to another tiny processor called WPSS Q6 >> processor (Wireless Processor SubSystem) on the SC7280 MSM, >> where the WLAN firmware runs, and it is the WLAN firmware >> running on the Q6 processor which enumerates WCN6750, as a >> result APPS processor would never know such a device being >> present in the system and would not detect the WCN6750 >> hardware unless and otherwise WCN6750 is registered as a >> platform device. This is the reason behind adding WCN6750 >> WLAN node in the device tree. >> >> Add WCN6750 wireless driver support, its based on ath11k driver. >> >> Sorry to hijack this patch, but I am not comfortable with this binding >> as-is.. >> >> Adding +Jeff in case he has any thoughts > > To be honest I find it a bit discouraging to get this relatively simple > patch with existing bindings blocked. Yes, the bindings are probably bad > (not that I can really judge) but sc7280/kodiak already uses them and > it's functional, so I don't know what I would need to change. > > Re-designing the bindings and driver seems a bit overkill to get milos > wifi upstream. I was *really* hoping this would attract more attention from the Atheros folks, but that seems not to have happened.. With that in mind, I think the way to go for now is to go forward with this is to simply roll with it, especially given we need to carry this setup for kodiak regardless. Acked-by: Konrad Dybcio Konrad