From: "H. Peter Anvin" <hpa@zytor.com>
To: "Li, Fei" <fei.li@intel.com>, Ingo Molnar <mingo@kernel.org>
Cc: "mingo@redhat.com" <mingo@redhat.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"Liu, Chuansheng" <chuansheng.liu@intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"holt@sgi.com" <holt@sgi.com>,
"rmk+kernel@arm.linux.org.uk" <rmk+kernel@arm.linux.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] reboot: perform warm/cold reset correctly for CF9 type
Date: Wed, 21 Aug 2013 11:07:48 +0200 [thread overview]
Message-ID: <7233d29e-ea01-4eb6-8018-b9c8e3730a30@email.android.com> (raw)
In-Reply-To: <BEC9F67575FA1E429CA7CF5AE9BE3634012ED68C@SHSMSX104.ccr.corp.intel.com>
The thing is that the existing "warm" and "cold" means something different, I believe (skip post vs do post.) It is possible it just works, but it would be good to know which platforms or works on.
Also, why do you need the cf9 boot method at all? All current systems * should * use the ACPI method.
"Li, Fei" <fei.li@intel.com> wrote:
>> Careful. This is a very different definition of warm vs cold boot
>used elsewhere.
>
>We have tested both warm and cold reboot on our x86 platform, and it
>works well.
>Besides with commit, the expected warm and reboot type can be specified
>through
>command line.
>
>> >Looks good, but please introduce a reboot_val intermediate
>> >variable instead of duplicating that ugly line-broken
>> >construct twice.
>
>Accepted and will update it in later version.
>
>> >
>> >Thanks,
>> >
>> > Ingo
>>
>
>Thanks,
>Fei
--
Sent from my mobile phone. Please excuse brevity and lack of formatting.
next prev parent reply other threads:[~2013-08-21 9:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 1:52 Li Fei
2013-08-21 7:29 ` Ingo Molnar
2013-08-21 7:33 ` H. Peter Anvin
2013-08-21 8:08 ` Li, Fei
2013-08-21 9:07 ` H. Peter Anvin [this message]
2013-08-22 3:32 ` Li, Fei
2013-09-03 17:35 ` H. Peter Anvin
2013-09-09 1:53 ` Liu, Chuansheng
2013-09-09 2:56 ` H. Peter Anvin
2013-08-21 8:13 ` [PATCH V2] " Li Fei
2013-09-10 19:51 ` [tip:x86/reboot] reboot: Allow specifying warm/ cold reset for CF9 boot type tip-bot for Li Fei
2013-09-25 17:36 ` tip-bot for Li Fei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7233d29e-ea01-4eb6-8018-b9c8e3730a30@email.android.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=chuansheng.liu@intel.com \
--cc=fei.li@intel.com \
--cc=holt@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®