From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA5CB3D093E; Thu, 28 May 2026 12:46:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779972380; cv=none; b=YB1ODX8zHhTpSJHRhkujgyEqLkIA+A9QEnlTG6Scv5ZmcYhFclGE1aZSOSwehdZTum2EHBckk09/1t8Zn1Ae4jrHAOjL0IjUMYXDRoFVa2AEJ23YNo4lZDnqlfOxUmaIU+qP9gwn/cmte+VNQr4pEg4ygDLwSQ0Gb/B5b7RFofY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779972380; c=relaxed/simple; bh=OD7o9MDgjTj8YX8g90cEbBLX0ChOGs0N34DwDMOZenM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=beKG1K1NVy1oLnwUUp1dfqnfUxXQUnVGGrFPA9gpPR2MPmILiYBLT6sm1wwtyve0GZDnvavVe8H5WSI0+Izm6y2r8U/av3k2dsk+mQhb8mNwd+dR9WGNIw9CL+qg9xXTPLZrKWNTUAxgnu3GdZTdOKWbBab/+3GebPoExdvdwMM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=NP1beM3H; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="NP1beM3H" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=ut/Qe9YdI4WHkXTTJGwEVhJ+o8KwuXlfpkvaFGgGtTo=; b=NP1beM3HPdc3Zfmy0dtCgbc8X7 G6+9lEgOPk5xVh0m5H31CLThw3ZPXWWng53y303yK5A4zpXSyESlSuUNqMAyr4DjfRHEtg0u5jTZ/ TuIa5kZ/uNi2K5JRmKeXj2wD8ypEtofGoeM07tEXOz/OzDFTpVEmBJyqim7DvNkQYCjw=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1wSa7k-004tyP-1m; Thu, 28 May 2026 14:46:08 +0200 Date: Thu, 28 May 2026 14:46:08 +0200 From: Andrew Lunn To: Luke Howard Cc: Cedric Jehasse , Cedric Jehasse , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Russell King , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Kieran Tyrrell , Max Hunter Subject: Re: [PATCH net-next 2/2] net: dsa: mv88e6xxx: add support for credit based shaper Message-ID: <723c23da-69e4-4cdb-8b72-9a3af5f8dba3@lunn.ch> References: <20260522-net-next-mv88e6xxx-cbs-v1-0-c87a8e6bcc0c@luminex.be> <20260522-net-next-mv88e6xxx-cbs-v1-2-c87a8e6bcc0c@luminex.be> <885A5B11-A34A-4F69-9E9F-ABF10159B789@padl.com> <2E4F8243-8687-4591-A03D-4402D4FBEC02@padl.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2E4F8243-8687-4591-A03D-4402D4FBEC02@padl.com> > It would be good to support both, particularly for switches with >4 > queues. Maybe this can be keyed the presence of the DT property (now > renamed, marvell,avb-mode). You need to be careful with DT. It represents hardware. Configuration of that hardware, or policy, should not be in DT. Andrew