From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1945979AbcBRKqP (ORCPT <rfc822;w@1wt.eu>);
	Thu, 18 Feb 2016 05:46:15 -0500
Received: from mout.kundenserver.de ([212.227.17.10]:56609 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1426083AbcBRKqK (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 18 Feb 2016 05:46:10 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: Vladimir Murzin <vladimir.murzin@arm.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux@arm.linux.org.uk,
        pawel.moll@arm.com, ijc+devicetree@hellion.org.uk,
        gregkh@linuxfoundation.org, daniel.lezcano@linaro.org,
        linux-kernel@vger.kernel.org, robh+dt@kernel.org,
        andy.shevchenko@gmail.com, galak@codeaurora.org,
        linux-serial@vger.kernel.org, u.kleine-koenig@pengutronix.de,
        tglx@linutronix.de, linux-api@vger.kernel.org, jslaby@suse.cz,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 09/10] ARM: dts: introduce MPS2 AN385/AN386
Date: Thu, 18 Feb 2016 11:45:12 +0100
Message-ID: <7245560.jfhuhtPsB8@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <56C598D9.3030001@arm.com>
References: <1455617295-23736-1-git-send-email-vladimir.murzin@arm.com> <7272921.u1gphgWzUn@wuerfel> <56C598D9.3030001@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:yeuiEWyKhoUKEf0S6exQWMiEgJybjnQ6tBunXaCwDmG/9/JjNXs
 xICdB1TWqTZ8Vrwx6DWCayf4+iMiHn5HQoAesh7ibGWvfV1Ry14avrRq6VEfrUaPPuQ79bu
 h/I4VNRGiOZLa5GDxgqYazHdBh4LYXsIVqCn9Pedx3EGRRRYEWyX7HqFu0PVoXJVm7c1U5y
 8DU6mPntfPAGt/tecooAw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:2YpkrPpel2Q=:redeQKEjotxPLStDzYvSBw
 WMOT0QlMbMzxXfjAN4QJnspQqkVkRph/dt2EYt75fgpYtYDQi4C6JI/yrfNOP4JNphXnqdNju
 ABEnps+FsrNfe/gJVjDufjgEdJ+vtTdFHr+3yyiDuvIc74TG+lqVcyjHZ/k3n53GSjnyUgAmf
 MM+YO6Oixnwk5UQLPDHYYH27BuXaVl7k845emkBWvSEz3jLkfLY9UX9Ni+36A/lyEiw0KVuJu
 HoSk5fvcbOhqCBHe/GH70SvF5ZhZNLV0c3yxsbV+lpPeSfwrqnyqOuCjX1QGCmv9i1T236wSz
 X2bcf69cquxyOVvDIpgZYW3HuRZ3ELiEdDca1CnNIlEoQPZHg3qintDVXJ+KeKG7nyHttsHv3
 IdijXwsiHKrxbBE/++q/geq5QSrwKb9YcpDRwiNBhZaW6BzVRhLzfI0k23xQ5Mh8FsHTVvR4y
 hjsbAox9MPY6JzRUGNeEBwjQkXv89HqsLg7xZ5zju31PWblzJDDldH1/DtaZSx4aSSPPj5R3i
 8xfx5uhHMWIyPTwd/VWGrAxSNUfH6egzTYuyheX9BxpjB+AT48SsXwetDTGlYogQvbhp0HMpB
 5l01NOFd+C4SXgz5wgADiVDYvtRsLnXWhKcYcwc9hjJQES+A0bpYGpee6/3XoeRK2pFHMDZNx
 nj1QnFdITq4jpnO4hfING38kMq4KH/j+azQfyz68/GF859sX2+G8JT55sBhzHWFMK0646KeKU
 95JmzzYIrx6pPoJp
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thursday 18 February 2016 10:11:37 Vladimir Murzin wrote:
> 
> Right, I thought in a wrong way, in opposite it makes more sense now.
> 
> .dtsi
> 
> /* below the soc/ */
> smb {
>         compatible = "simple-bus";
>         #address-cells = <2>;
>         #size-cells = <1>;
>         ranges = <0 0 0x40200000 0x10000>,
>                  <1 0 0xa0000000 0x10000>;
> };

That looks good, yes.

Is 0x10000 the correct maximum addressable size of the external bus
in both cases?

Intuitively, I would guess that the 0xa0000000 range might
be much wider.

> .dts
> 
> smb {
>         ethernet@0,0 {
>                 compatible = "smsc,lan9220", "smsc,lan9115";
>                 reg = <0 0x0 0x10000>;
>                 interrupts = <13>;
>                 interrupt-parent = <&nvic>;
>                 smsc,irq-active-high;
> };
> 
> 
> and looking again at .dtsi it seems to me that fpgaio should be moved
> below the soc/ under separate bus interface which would hosts audio and
> spi too or I keep missing things around device-tree?
> 

I don't see the audio and spi nodes, so I'm not sure where exactly
you would put them.

Ideally those things should be visible from a block diagram in the
datasheet.

	Arnd