From: Paolo Bonzini <pbonzini@redhat.com>
To: KarimAllah Ahmed <karahmed@amazon.de>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Radim Krčmář" <rkrcmar@redhat.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"H . Peter Anvin" <hpa@zytor.com>,
x86@kernel.org
Subject: Re: [PATCH v2] X86/VMX: Disable VMX preemption timer if MWAIT is not intercepted
Date: Tue, 10 Apr 2018 13:07:05 +0200 [thread overview]
Message-ID: <724738be-2117-3a44-8328-e3ec2f54711f@redhat.com> (raw)
In-Reply-To: <1523354922-17955-1-git-send-email-karahmed@amazon.de>
On 10/04/2018 12:08, KarimAllah Ahmed wrote:
> @@ -11908,6 +11908,9 @@ static int vmx_set_hv_timer(struct kvm_vcpu *vcpu, u64 guest_deadline_tsc)
> u64 guest_tscl = kvm_read_l1_tsc(vcpu, tscl);
> u64 delta_tsc = max(guest_deadline_tsc, guest_tscl) - guest_tscl;
>
> + if (kvm_pause_in_guest(vcpu->kvm))
> + return -EOPNOTSUPP;
> +
This is still doing a relatively expensive kvm_read_l1_tsc, so move it
even further up. :)
Paolo
next prev parent reply other threads:[~2018-04-10 11:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 10:08 KarimAllah Ahmed
2018-04-10 11:07 ` Paolo Bonzini [this message]
2018-04-10 12:16 ` Raslan, KarimAllah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=724738be-2117-3a44-8328-e3ec2f54711f@redhat.com \
--to=pbonzini@redhat.com \
--cc=hpa@zytor.com \
--cc=karahmed@amazon.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome