From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bout3.ijzerbout.nl (bout3.ijzerbout.nl [136.144.140.114]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 72CB419ABC6; Thu, 5 Dec 2024 19:50:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=136.144.140.114 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733428225; cv=none; b=R4FbGDm5PhLihNG9vycO7OpjQmVtScdJsjZp3clOo5ckkes8vjiwJJd1w/9lsGDEazWdpSyENb+Yd18L5C+qvd+LgU0zNNH52oM/ixJJyFC7caL2UAN69HKQjmULIz2t7naYlWezQMo3TI31QMbmlH4yV4JTA8gxt/A4ADw8s+E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733428225; c=relaxed/simple; bh=YbwFw+E4aKyUl5eKWEN/nZ+GKgdxjpTjfO7xGnRiWeA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=B2v/yhxyBxdzEhscCedxRVDRnhFigKn+L68FI86j7l+L7zFa6UxviXUOGK2aEPHLOhdo1iXoGPvWXbMfVp6xTOOvSfu7KDz3Xu3P6zfJZYUPV4KTtzdcbCGauK3ND7tqSMfVt6lB8ay5UDzASXXM54rzcFS6C83N/acxz8T8+2A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ijzerbout.nl; spf=pass smtp.mailfrom=ijzerbout.nl; dkim=pass (4096-bit key) header.d=ijzerbout.nl header.i=@ijzerbout.nl header.b=RVUI6abm; arc=none smtp.client-ip=136.144.140.114 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ijzerbout.nl Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ijzerbout.nl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=ijzerbout.nl header.i=@ijzerbout.nl header.b="RVUI6abm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ijzerbout.nl; s=key; t=1733428216; bh=YbwFw+E4aKyUl5eKWEN/nZ+GKgdxjpTjfO7xGnRiWeA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=RVUI6abmPvpgaoy/W3tb0CwqY54O4+5aY/ttRx+nHWmCvj2EUZ/bPdLahbEroCFI3 /FrPcuH4qT5lj4kxdAqf5AGFoCwtPvoHWc8JrRHQsBfeiKE50GZ6dMsml4U70E0cKt xAVJpVOc0483J39EuHkD/Q5Ebb6mDnxMT3r+kvgqy641ojYDccta4TqzK+H463raHs NLEdIK+xXoh+VW2CO/vDszgegLcVXjx2LvX7qj74A2D6d7lTmri6bAbCPQZdAWr0CB D6Y+yJjDWHLTKWxw3qWihyAsosZ2ZQAhxkLvjp4hPbQym5j/hxFC3WR+FlyvE8lz4U EwZfQ2H/ZwC1CE/gcY0onWVlvLcEOQBWDB7P+MN1/f5faRMJtV4jiI/ajhh/wAcL+C IO42a9OZjWHzbNPNZmFg7kODV1d288Sq1kUBY02oc2RRrI8gsqre41u3+Q3sQ+Tp/L p/1rWrGTKrEq9yPWYGN8rlQKj3GColHN2s3Kbq+ojrsi7kvgmz36MP3ztsOsxZKkoV ymWWHStb6uMMI9CCzzA+o4ndZhjbykcgU9GQ7Z5qtfNbFPGJAqv8IUKWlTRQhnf06x wYW09FUbm+xOzIxSslFcPuml/rJDcKs4Kl8gXAMId/G328Z2A/RQSe4N653nXxSogD o5S5dOysCbCmGCbmtnZrz8HI= Received: from [IPV6:2a10:3781:99:1:1ac0:4dff:fea7:ec3a] (racer.ijzerbout.nl [IPv6:2a10:3781:99:1:1ac0:4dff:fea7:ec3a]) by bout3.ijzerbout.nl (Postfix) with ESMTPSA id 3832018BC4C; Thu, 5 Dec 2024 20:50:16 +0100 (CET) Message-ID: <72486280-1852-41a2-ae17-2288d7fedd54@ijzerbout.nl> Date: Thu, 5 Dec 2024 20:50:14 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/3] hwmon: (pmbus/tps25990): add initial support To: Jerome Brunet , Jean Delvare , Guenter Roeck , Jonathan Corbet , Delphine CC Chiu Cc: linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, Vaishnav Achath References: <20241202-tps25990-v4-0-bb50a99e0a03@baylibre.com> <20241202-tps25990-v4-3-bb50a99e0a03@baylibre.com> Content-Language: en-US From: Kees Bakker In-Reply-To: <20241202-tps25990-v4-3-bb50a99e0a03@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Op 02-12-2024 om 11:28 schreef Jerome Brunet: > Add initial support for the Texas Instruments TPS25990 eFuse. > This adds the basic PMBUS telemetry support for the device. > > Tested-by: Vaishnav Achath > Signed-off-by: Jerome Brunet > --- > Documentation/hwmon/index.rst | 1 + > Documentation/hwmon/tps25990.rst | 148 +++++++++++++ > MAINTAINERS | 2 + > drivers/hwmon/pmbus/Kconfig | 17 ++ > drivers/hwmon/pmbus/Makefile | 1 + > drivers/hwmon/pmbus/tps25990.c | 437 +++++++++++++++++++++++++++++++++++++++ > 6 files changed, 606 insertions(+) > > [...] > diff --git a/drivers/hwmon/pmbus/tps25990.c b/drivers/hwmon/pmbus/tps25990.c > new file mode 100644 > index 0000000000000000000000000000000000000000..0a267014c88997fca5e83b2ec974a0d521808512 > [...] > + case PMBUS_VIRT_READ_IIN_MAX: > + return TPS25990_READ_IIN_PEAK; > + ret = pmbus_read_word_data(client, page, phase, > + TPS25990_READ_IIN_PEAK); > + break; > [...] Is the return intended? Or some left-over debug code? -- Kees