From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-b3-smtp.messagingengine.com (fhigh-b3-smtp.messagingengine.com [202.12.124.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0C3E23E350 for ; Mon, 14 Jul 2025 15:01:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.154 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752505319; cv=none; b=XNIHDJZcTpgV4ZHEGskbyNjZfVB1Wti7lf3m0OdhpEnxAkOrT3lufCUSqGb7M1rd7YC9efdC62JblsmZV15xh417EOrcQ94msIxJS2/39B3wfiJtThgtg37iRoQ6kE4jUiAZdLVINzrrIUKu6V05eNeTNbGPIrMPrc6C6WP4v7Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752505319; c=relaxed/simple; bh=slLAgUlx75U7/G8RA1frwVRi8YBjPDCiwjGUjzItolw=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=YO0uSrpQGiVJe2VO2dFWLrWuU7dMrqxny9Z8igAGaV0fMt21wKvHmvLR2EDdHm6w+u6uG14/t8okL+kWgjB1zSClB5KbNM57TZYY/QG6DSVyTFSuCeXvyfFHMTi8A/VKGzSpcPegZNfajfsacfASy4YXGrN1N2wikxKJliGi+mM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de; spf=pass smtp.mailfrom=arndb.de; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b=Lnt9gkmO; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=hD9nCXPB; arc=none smtp.client-ip=202.12.124.154 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arndb.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="Lnt9gkmO"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="hD9nCXPB" Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfhigh.stl.internal (Postfix) with ESMTP id AA1F77A030E; Mon, 14 Jul 2025 11:01:55 -0400 (EDT) Received: from phl-imap-02 ([10.202.2.81]) by phl-compute-05.internal (MEProxy); Mon, 14 Jul 2025 11:01:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1752505315; x=1752591715; bh=+1B/AXLCX2MnzgZT1P/hZnnKS44NBY8AHKmKaJUNjHA=; b= Lnt9gkmOg7Xkq89lXSDdqF6u/n5n+KP+kWpxSKsa0W5EyJFy4hdiOGa1JbYwumSm 9IkPXtrZTsGYg9ZyJnTrP8MTuiN60IAOssZ0GOkp1W8ZDls1nuRGdab2ZWZJNLWd 0XmoTJsl98lONw+/oXzvM87Zc7X07ubenQevj2gP6XYArab8E8xeH4WyAZIXIyhs iwK7BCo35DnzvnuCWMhpEaYoG/p10glsfdQPObSyc11IiRNAPifVCRX3ptturnFu q7LqYuLZVSaJhysaSJkedd1/cYw3HF1j5fL4OE4QbygtrDt6R3EstAeBgm6UEFvd 416FY0+G6ebBi2UPHPXWqA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1752505315; x= 1752591715; bh=+1B/AXLCX2MnzgZT1P/hZnnKS44NBY8AHKmKaJUNjHA=; b=h D9nCXPBNwV9yhWnhYz6+BE0yJa7wDhKiwsVUafySXFes/USmMAvijahCEIZEVKAk ciolENnVd8dGzsMKHr7I0eRdseKf/gLKDyMFkZyzuUDKE9EUqdeleMGxXNq9Brwk qw8bNJ6CROfTtLX5fu7ygZwS/iSxEfztmpDiEpId8J5a6uo6mJY6gcdJZSa8RA+q UZBUWwNUf3ExLjDaIgl4h2fmQpAkLqVJghoYYvwstMKiOH1oyHmPvUVQI5YZkYA0 DVktlWzFKV/XklDEuyWngo11r8bXH3mdQrP9GpUmuLeAP54uThchLcSlXQWyc/Fs oXpKwIdN7t7vYBYKgZymg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdehvddviecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefoggffhffvvefkjghfufgtgfesthejredtredttdenucfhrhhomhepfdetrhhnugcu uegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtthgvrh hnpeefhfehteffuddvgfeigefhjeetvdekteekjeefkeekleffjeetvedvgefhhfeihfen ucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomheprghrnhgusegrrhhnuggsrdguvgdpnhgspghrtghp thhtohepuddvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegrlhgvgigrnhguvg hrrdguvghutghhvghrsegrmhgurdgtohhmpdhrtghpthhtoheptghhrhhishhtihgrnhdr khhovghnihhgsegrmhgurdgtohhmpdhrtghpthhtohepghhuohhqihhnghdriihhrghngh esrghmugdrtghomhdprhgtphhtthhopehlihhjohdrlhgriigrrhesrghmugdrtghomhdp rhgtphhtthhopehmrghrvghkrdholhhsrghksegrmhgurdgtohhmpdhrtghpthhtohepmh grrhhiohdrlhhimhhonhgtihgvlhhlohesrghmugdrtghomhdprhgtphhtthhopehsihhm ohhnrgesfhhffihllhdrtghhpdhrtghpthhtoheprghirhhlihgvugesghhmrghilhdrtg homhdprhgtphhtthhopegrrhhnugeskhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 06F92700069; Mon, 14 Jul 2025 11:01:55 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: T6e7c1da684903917 Date: Mon, 14 Jul 2025 17:01:34 +0200 From: "Arnd Bergmann" To: "Mario Limonciello" , "Arnd Bergmann" , "Alex Deucher" , =?UTF-8?Q?Christian_K=C3=B6nig?= , "Dave Airlie" , "Simona Vetter" , "Lijo Lazar" , "Zhang, GuoQing (Sam)" Cc: "Olsak, Marek" , "amd-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Message-Id: <724b4600-d983-434a-acf6-68cd87b04636@app.fastmail.com> In-Reply-To: References: <20250714081635.4071570-1-arnd@kernel.org> Subject: Re: [PATCH] drm/amdgpu: fix link error for !PM_SLEEP Content-Type: text/plain Content-Transfer-Encoding: 7bit On Mon, Jul 14, 2025, at 16:59, Limonciello, Mario wrote: > On 7/14/25 3:16 AM, Arnd Bergmann wrote: >> From: Arnd Bergmann >> >> When power management is not enabled in the kernel build, the newly >> added hibernation changes cause a link failure: >> >> arm-linux-gnueabi-ld: drivers/gpu/drm/amd/amdgpu/amdgpu_drv.o: in function `amdgpu_pmops_thaw': >> amdgpu_drv.c:(.text+0x1514): undefined reference to `pm_hibernate_is_recovering' >> >> Make the power management code in this driver conditional on >> CONFIG_PM and CONFIG_PM_SLEEP >> >> Fixes: 530694f54dd5 ("drm/amdgpu: do not resume device in thaw for normal hibernation") >> Signed-off-by: Arnd Bergmann > > We're going to fix it using this stub instead. > > https://lore.kernel.org/linux-pm/20250712233715.821424-1-superm1@kernel.org/ > > It's in drm-misc-next as of this weekend and it should show up in > linux-next in the next day or two. That patch makes sense as well, but I think mine is useful as an improvement even if it doesn't address a link failure but only reduces the object size by reducing the amount of dead code. Arnd