From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFF0BC33CA9 for ; Tue, 14 Jan 2020 02:15:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B481B2084D for ; Tue, 14 Jan 2020 02:15:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729600AbgANCPc convert rfc822-to-8bit (ORCPT ); Mon, 13 Jan 2020 21:15:32 -0500 Received: from szxga02-in.huawei.com ([45.249.212.188]:2989 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729402AbgANCPb (ORCPT ); Mon, 13 Jan 2020 21:15:31 -0500 Received: from DGGEMM403-HUB.china.huawei.com (unknown [172.30.72.56]) by Forcepoint Email with ESMTP id B9AA8675F32A4268D52D; Tue, 14 Jan 2020 10:15:28 +0800 (CST) Received: from dggeme716-chm.china.huawei.com (10.1.199.112) by DGGEMM403-HUB.china.huawei.com (10.3.20.211) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 14 Jan 2020 10:15:28 +0800 Received: from dggeme763-chm.china.huawei.com (10.3.19.109) by dggeme716-chm.china.huawei.com (10.1.199.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Tue, 14 Jan 2020 10:15:28 +0800 Received: from dggeme763-chm.china.huawei.com ([10.6.66.36]) by dggeme763-chm.china.huawei.com ([10.6.66.36]) with mapi id 15.01.1713.004; Tue, 14 Jan 2020 10:15:28 +0800 From: linmiaohe To: Sean Christopherson CC: "pbonzini@redhat.com" , "rkrcmar@redhat.com" , "vkuznets@redhat.com" , "wanpengli@tencent.com" , "jmattson@google.com" , "joro@8bytes.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "hpa@zytor.com" , "liran.alon@oracle.com" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "x86@kernel.org" Subject: Re: [PATCH v2] KVM: nVMX: vmread should not set rflags to specify success in case of #PF Thread-Topic: [PATCH v2] KVM: nVMX: vmread should not set rflags to specify success in case of #PF Thread-Index: AdXKfnlTqBbphD17SN+x8lK5ZNmfGA== Date: Tue, 14 Jan 2020 02:15:28 +0000 Message-ID: <724c22eff5f94a338e0f8af4f2c1df93@huawei.com> Accept-Language: en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.173.221.158] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, Jan 13, 2020 at 12:09:42PM -0800, Sean Christopherson wrote: > > On Sat, Dec 28, 2019 at 02:25:24PM +0800, linmiaohe wrote: > > > From: Miaohe Lin > > > > > > In case writing to vmread destination operand result in a #PF, > > vmread should not call nested_vmx_succeed() to set rflags to specify success. > > > Similar to as done in VMPTRST (See handle_vmptrst()). > > > > > > Reviewed-by: Liran Alon > > > Signed-off-by: Miaohe Lin > > > > Reviewed-by: Sean Christopherson > > Gah, got trigger happy. This could also have "Cc: stable@vger.kernel.org". > With that, my Reviewed-by stands :-). Many thanks for your review. I would add Cc tag and resend a v3. Thanks again.