From: "Csókás Bence" <csokas.bence@prolan.hu>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: mdiobus: Move all reset registration to `mdiobus_register_reset()`
Date: Mon, 25 Aug 2025 16:39:12 +0200 [thread overview]
Message-ID: <724f69f0-7eab-40aa-84f0-07055f051175@prolan.hu> (raw)
In-Reply-To: <aKxwVNffu9w8Mepl@shell.armlinux.org.uk>
Hi,
On 2025. 08. 25. 16:16, Russell King (Oracle) wrote:
> On Mon, Aug 25, 2025 at 04:09:34PM +0200, Bence Csókás wrote:
>> Make `mdiobus_register_reset()` function handle both gpiod and
>> reset-controller-based reset registration.
>
> The commit description should include not only _what_ is being done but
> also _why_.
Well, my question was, when I saw this part of code: why have it
separate? Users shouldn't care whether a device uses gpiod or
reset-controller when they call `mdio_device_reset()`, so why should
they have to care here and call two separate register functions, one
after another? In fact, the whole thing should be moved to mdio_device.c
honestly. Along with the setting of mdiodev->reset_{,de}assert_delay.
The end goal is fixing this "Can't read PHY ID because the PHY was never
reset" bug that's been plaguing users for years.
Bence
next prev parent reply other threads:[~2025-08-25 14:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-25 14:09 Bence Csókás
2025-08-25 14:16 ` Russell King (Oracle)
2025-08-25 14:39 ` Csókás Bence [this message]
2025-08-25 14:54 ` Russell King (Oracle)
2025-08-25 15:01 ` Csókás Bence
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=724f69f0-7eab-40aa-84f0-07055f051175@prolan.hu \
--to=csokas.bence@prolan.hu \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®