From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98CA81D63C6 for ; Tue, 5 Nov 2024 12:52:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730811132; cv=none; b=h00MjmYGvjDlpNV8DOb1EQQLztc49U7t4YKdciNjgB8oBXIFIFph2aJpsgPgznM0rxAVL2VRKyVPGbe3f9ECiCyfpsEJcjk9tS2yrv9n0tJxB4p+b98jJAmKqmD3tE3FLVIcLvz/a1UwzcUR7AjOgt8jdcyBsbPzjCNHvjADIPc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730811132; c=relaxed/simple; bh=5AavB2k8eTzT+b9vnQylCFfBcymntVGRSHXHCEWFvuU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mtxU2agrZ/DijUKERNYdcZG09zI6XHvg2kI8NT4bwgjKqNNaNEia+/wWr4uklx5oZlYytF10SpNwh/CWfg7C6OK/rWgUXT1ctajpiDbxEmrYHo8QmI87Z3nD52PYV/uDBOvWZ1g7tBxX/6qmgDuG2j6lHPTTEKQe28ZLGn8uiiE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=i/3V9+s3; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="i/3V9+s3" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-2e2e2d09decso4690811a91.1 for ; Tue, 05 Nov 2024 04:52:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1730811128; x=1731415928; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=At2805czTihicDRdY+YJdDpwWq0X5S/HDbS43yOjnkM=; b=i/3V9+s3/JNEFfHOcuRpBzd5G7491DomHO3MF90MHZr8nK8fiYJ+KudnQUZquDj8b6 q45RrF536g5AH9//3l+BOQjbAHt58ppvReuxu5e3yaqb7r9oEZMX3lmp+3tcyFHTSHzy 8GCycCWQlYOpKejYxa4qUFhVBlgQaIKYyPHncdAnpi31kmHc72bcE3+saecPfyG7O4A5 7auenblDUBKF4Yjpe5RZ3yGBgcHjIq/ZD79uzbAtuiUNbCQC9JvGE57DFYLpep7tdnmi r1ogtFk78mBsXAhjUM1xCDvzqm80jvNF1b3OFJ/g2YRpTzrwawYA4S2HFhXrIIrJrK6s kh/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730811128; x=1731415928; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=At2805czTihicDRdY+YJdDpwWq0X5S/HDbS43yOjnkM=; b=eR5mCW8re1NOZWTDWP8jOtOX+BSutGy5pT8wv4LSObFvzJWu7RztcjctdxBSu9Cxu9 Lw+8XC6ZchE2BV30NDR4O+WMAgqqE9o7OKo1kt/OmmScUQAX6bePEw0FI2ywmKDI3SFl k+tmsz4hKaJkL/YI7q3p3ghetfgYarex6Lbg9Vl/aSTV6JTAPH7Lc2jQNTdC86S1S9Mz g/3PcT578O8jenWWVfJ6o9AdiTPB6+OwCuRvqvBq2gU1eG7wvu+8iiYfRMwrC5H7Qfbc 25kypYJspyxmHY3CwpuoJFU5N9BLYr02gZYdnzW+xdUNeeMQ4h1XGpJysu402o+/IL/S ujRg== X-Forwarded-Encrypted: i=1; AJvYcCWC0hhjSEFnRWHE8dTmnJk2x2aG3tBDtvhXlHkHf5nNzpg8HMbkJBxIWU0Rck0Oafs++NiERzKqMXtw+Cw=@vger.kernel.org X-Gm-Message-State: AOJu0YyoT80fqh1VPXt9qfNJMziR2UfD1Al4ejeedZOByzl/evsMFpPt z0z91xBYH+YKZlgex3rFJzfTKvM4Ze3dpdKVB3wag+0SuIHzsz0SGFkFuyV6gYI= X-Google-Smtp-Source: AGHT+IFZ2rqlU9xmlbidWBPBOCsO4c5ZoLFE3W7KH4q7MLqnYLyStlgN4LLR9uK8B2J9oi1JSXBZXQ== X-Received: by 2002:a17:90b:540c:b0:2e2:b94c:d6a2 with SMTP id 98e67ed59e1d1-2e93ddf4d4fmr29684686a91.0.1730811128404; Tue, 05 Nov 2024 04:52:08 -0800 (PST) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e92fbe0252sm11939317a91.45.2024.11.05.04.52.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Nov 2024 04:52:07 -0800 (PST) Message-ID: <72515c41-4313-4287-97cc-040ec143b3c5@kernel.dk> Date: Tue, 5 Nov 2024 05:52:05 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [ANNOUNCE] work tree for untorn filesystem writes To: Carlos Maiolino , "Darrick J. Wong" Cc: "Ritesh Harjani (IBM)" , John Garry , brauner@kernel.org, Catherine Hoang , linux-ext4@vger.kernel.org, Theodore Ts'o , Jan Kara , Christoph Hellwig , Ojaswin Mujoo , linux-block@vger.kernel.org, Dave Chinner , linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <20241105004341.GO21836@frogsfrogsfrogs> Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/5/24 4:19 AM, Carlos Maiolino wrote: > On Mon, Nov 04, 2024 at 04:43:41PM -0800, Darrick J. Wong wrote: >> Hi everyone, >> >> Nobody else has stepped up to do this, so I've created a work branch for >> the fs side of untorn writes: >> https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git/log/?h=fs-atomic_2024-11-04 >> >> Can you all check this to make sure that I merged it correctly? And >> maybe go test this on your storage hardware? :) >> >> If all goes well then I think the next step is to ask brauner very >> nicely if he'd consider adding this to the vfs trees for 6.13. If not >> then I guess we can submit it ourselves, though we probably ought to ask >> rothwell to add the branch to for-next asap. >> >> PS: We're now past -rc6 so please reply quickly so that this doesn't >> slip yet another cycle. >> >> Catherine: John's on vacation all week, could you please send me the >> latest versions of the xfs_io pwrite-atomic patch and the fstest for it? > > I am kind confused here now. IIRC Jens pulled the first three patches > from John's series into his tree, and John asked me to pull the other > ones. I'm much happier to see a single person pulling the whole series > instead of splitting it into different maintainers though. > > Giving how spread the series is, I'd say going through vfs tree would > be the best place, but I'm not opposed to pull them myself. Guys, not sure why this is so difficult to grasp. I already pulled the initial bits weeks ago, into an immutable branch: https://git.kernel.dk/cgit/linux/log/?h=for-6.13/block-atomic which was subsequently also pulled into for-6.13/block. Whoever wants to stage the xfs bits must simply: 1) Pull the above for-6.13/block-atomic branch 2) Apply XFS bits on top Why is this so difficult to grasp? It's a pretty common method for cross subsystem work - it avoids introducing conflicts when later work goes into each subsystem, and freedom of either side to send a PR before the other. So please don't start committing the patches again, it'll just cause duplicate (and empty) commits in Linus's tree. -- Jens Axboe