From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0C9CC6FA8A for ; Thu, 8 Sep 2022 23:57:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229955AbiIHX5M (ORCPT ); Thu, 8 Sep 2022 19:57:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229566AbiIHX5K (ORCPT ); Thu, 8 Sep 2022 19:57:10 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23D14F9120; Thu, 8 Sep 2022 16:57:09 -0700 (PDT) Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 288Nu9rg018354; Thu, 8 Sep 2022 23:57:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=xtNL9juSKiUlsYkTX1QTR8yYA0DFTAhoBW2fRPh34m0=; b=WRwzw/rQ4XDtGj8mIohegewcB+jDJ1Ic2jRXw3+AmEfDbhuKPgwHiJDJOGeJ87sGiBtw LFEwCF0YCn0+tlw+bNfn5Bs0gDzl2d07yoT4on9qfMTd+isV1eBt68S6V6QuIsqA0BL1 pbXPzeg3j44UEoJzmxbjAH5pteahTgAKTXXA5F7Q8n0vYPpuBO04UiiOXjEJbPoUb9RD JHsn9+83xNZEXpNdAWciLOkV+1DirUJeDI4BM9/vK0ZLzcgUOuQJ1tDzuQi0N1wReesl kw+3G51Xaht00DeHBk6Fh0CRZ6zA/o/UzRuPjteZ3vfvFJuOU6dNqbmWZji9Vv8XmQd9 cw== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3jfrhg88s1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 08 Sep 2022 23:57:03 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 288Nv2g5004041 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 8 Sep 2022 23:57:02 GMT Received: from [10.110.115.160] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Thu, 8 Sep 2022 16:57:01 -0700 Message-ID: <725f50bf-96dc-7976-7982-4810e8fc0610@quicinc.com> Date: Thu, 8 Sep 2022 16:57:00 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v4 1/2] dt-bindings: power: reset: qcom-pon: update "reg" property details Content-Language: en-US To: Krzysztof Kozlowski , , , , , CC: , , , , , , , David Collins References: <20220725191314.19456-1-quic_amelende@quicinc.com> <20220725191314.19456-2-quic_amelende@quicinc.com> <0e6bf142-ca56-2414-86c4-1a18b74b3ba6@quicinc.com> <889151be-9ea8-6a9e-e5fe-eac1dd93250c@linaro.org> From: Anjelique Melendez In-Reply-To: <889151be-9ea8-6a9e-e5fe-eac1dd93250c@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: C8HElnYJyAJCIRpW5zK0uA_Z6dXVCVdi X-Proofpoint-GUID: C8HElnYJyAJCIRpW5zK0uA_Z6dXVCVdi X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-08_14,2022-09-08_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 phishscore=0 priorityscore=1501 malwarescore=0 mlxlogscore=999 suspectscore=0 clxscore=1015 adultscore=0 spamscore=0 impostorscore=0 lowpriorityscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2209080084 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/8/2022 7:55 AM, Krzysztof Kozlowski wrote: > On 19/08/2022 22:26, Anjelique Melendez wrote: >> >> Hi Krzysztof, >> First I would like to apologize for my lack of response to this patch series >> over these past few weeks. I have been out of office. >> >> On 7/26/2022 3:25 AM, Krzysztof Kozlowski wrote: >>> On 25/07/2022 21:13, Anjelique Melendez wrote: >>>> From: David Collins >>>> >>>> Update the description of "reg" property to add the PON_PBS base >>>> address along with PON_HLOS base address. Also add "reg-names" >>>> property constraints. >>>> >>>> Signed-off-by: David Collins >>>> Signed-off-by: Anjelique Melendez >>>> --- >>>> Documentation/devicetree/bindings/power/reset/qcom,pon.yaml | 50 +++++++++++++++++++++++++++--- >>>> 1 file changed, 46 insertions(+), 4 deletions(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml >>>> index 353f155d..d7b6b875 100644 >>>> --- a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml >>>> +++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml >>>> @@ -15,18 +15,27 @@ description: | >>>> >>>> This DT node has pwrkey and resin as sub nodes. >>>> >>>> -allOf: >>>> - - $ref: reboot-mode.yaml# >>>> - >>>> properties: >>>> compatible: >>>> enum: >>>> - qcom,pm8916-pon >>>> - qcom,pms405-pon >>>> - qcom,pm8998-pon >>>> + - qcom,pmk8350-pon >>>> >>>> reg: >>>> - maxItems: 1 >>>> + description: | >>>> + Specifies the SPMI base address for the PON (power-on) peripheral. For >>>> + PMICs that have the PON peripheral (GEN3) split into PON_HLOS and PON_PBS >>>> + (e.g. PMK8350), this can hold addresses of both PON_HLOS and PON_PBS >>>> + peripherals. In that case, the PON_PBS address needs to be specified to >>>> + facilitate software debouncing on some PMIC. >>>> + minItems: 1 >>>> + maxItems: 2 >>>> + >>>> + reg-names: >>>> + minItems: 1 >>>> + maxItems: 2 >>>> >>>> pwrkey: >>>> type: object >>>> @@ -42,6 +51,39 @@ required: >>>> >>>> unevaluatedProperties: false >>>> >>>> +allOf: >>>> + - $ref: reboot-mode.yaml# >>>> + - if: >>>> + properties: >>>> + compatible: >>>> + contains: >>>> + enum: >>>> + - qcom,pm8916-pon >>>> + - qcom,pms405-pon >>>> + - qcom,pm8998-pon >>>> + then: >>>> + properties: >>>> + reg: >>>> + maxItems: 1 >>>> + reg-names: >>>> + items: >>>> + - const: pon >>> >>> All your previous patches were actually missing (in commit msg, in the >>> code) that piece of information which you add here. You now add >>> reg-names with "pon" for older devices. I assumed previous that it is >>> somehow needed, so I gave you the hints how it should be coded. But I >>> don't understand - why are you doing it >>> >>> This should be explained in commit msg. To me it is not needed at all... >>> unless you want to mark that first address space is entirely different >>> for other devices? >> Adding reg-names "pon" for older devices is simply to provide clarification >> about what the register relates to. Similar to reg-names "hlos" and "pbs" >> for gen3 children devices, reg-names is completely optional and is not >> consumed by any driver. > > OK, can be. Include it in the commit msg, please. ACK > > > Best regards, > Krzysztof