From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: James.Bottomley@hansenpartnership.com, Carlos Bilbao <bilbao@vt.edu>
Cc: deller@gmx.de, linux-parisc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: parisc: Update iosapic driver with proper printks
Date: Fri, 09 Jul 2021 18:05:05 +0200 [thread overview]
Message-ID: <7261873.EvYhyI6sBW@daneel.sf-tec.de> (raw)
In-Reply-To: <5760611.lOV4Wx5bFT@iron-maiden>
[-- Attachment #1: Type: text/plain, Size: 723 bytes --]
Am Freitag, 9. Juli 2021, 15:38:44 CEST schrieb Carlos Bilbao:
> The code from the old I/O Sapic Driver is outdated when it comes to printks.
> Fix applying proper indentation and using dev_dbg() instead of printk on
> debugging blocks. Also add a KERN_<LEVEL> where it is missing.
Have you actually tried building this? I bet not:
> +#define DBG(x...) dev_dbg(x)
> + DBG("io_sapic_info at %p\n", isi);
> + DBG("\t\tisi_hpa: %lx\n", isi->isi_hpa);
> + DBG("\t\tisi_status: %x\n", isi->isi_status);
> + DBG("\t\tisi_version: %x\n", isi->isi_version);
> + DBG("\t\tisi_vector: %p\n", isi->isi_vector);
> }
> #endif /* DEBUG_IOSAPIC */
You are not passing a struct device here, so this will not work.
Eike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2021-07-09 16:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 13:38 Carlos Bilbao
2021-07-09 16:05 ` Rolf Eike Beer [this message]
2021-07-09 17:16 ` [PATCH v1.1] " Carlos Bilbao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7261873.EvYhyI6sBW@daneel.sf-tec.de \
--to=eike-kernel@sf-tec.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=bilbao@vt.edu \
--cc=deller@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®