From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756645AbcH2H34 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 29 Aug 2016 03:29:56 -0400
Received: from webbox1416.server-home.net ([77.236.96.61]:53557 "EHLO
        webbox1416.server-home.net" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1751062AbcH2H3y (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 29 Aug 2016 03:29:54 -0400
From: Alexander Stein <alexander.stein@systec-electronic.com>
To: linux-kernel@vger.kernel.org
Cc: Yuan Yao <yao.yuan@freescale.com>, vinod.koul@intel.com,
        robh+dt@kernel.org, dan.j.williams@intel.com, mark.rutland@arm.com,
        linux@armlinux.org.uk, shawnguo@kernel.org, leoyang.li@nxp.com,
        dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Yuan Yao <yao.yuan@nxp.com>
Subject: Re: [PATCH v1 4/5] ARM: dts: ls1043a: add qDMA node
Date: Mon, 29 Aug 2016 09:29:50 +0200
Message-ID: <7263101.lJH82kSAYi@ws-stein>
User-Agent: KMail/4.14.10 (Linux/4.7.0-gentoo; KDE/4.14.20; x86_64; ; )
In-Reply-To: <1471502328-28305-5-git-send-email-yao.yuan@freescale.com>
References: <1471502328-28305-1-git-send-email-yao.yuan@freescale.com> <1471502328-28305-5-git-send-email-yao.yuan@freescale.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thursday 18 August 2016 14:38:47, Yuan Yao wrote:
> From: Yuan Yao <yao.yuan@nxp.com>
> 
> Add the QDMA node for ls1043a platform to
> support QDMA driver.
> 
> Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi index e8e4c3e..e463074
> 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> @@ -467,6 +467,16 @@
>  				 <&clockgen 4 0>;
>  		};
> 
> +		qdma: qdma@8390000 {
> +			compatible = "fsl,ls1021a-qdma", "fsl,ls1043a-qdma";

This doesn't match the order of your binding in Patch 2/5:
> +- compatible :
> +       - "fsl,ls1021a-qdma",
> +       Or "fsl,ls1043a-qdma" followed by "fsl,ls1021a-qdma",

It should be the other way around.

Best regards,
Alexander