From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1176768AbdDYImd (ORCPT ); Tue, 25 Apr 2017 04:42:33 -0400 Received: from mout.web.de ([212.227.15.14]:49623 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1176694AbdDYIm3 (ORCPT ); Tue, 25 Apr 2017 04:42:29 -0400 Subject: [PATCH 2/3] HSI: nokia-modem: Delete error messages for a failed memory allocation in two functions From: SF Markus Elfring To: Sebastian Reichel Cc: LKML , kernel-janitors@vger.kernel.org, Wolfram Sang References: Message-ID: <72632887-4105-04a6-0f20-fad4a979ff25@users.sourceforge.net> Date: Tue, 25 Apr 2017 10:42:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:ocs3c+pIEdCUdjMC3qaKCwLA4AOAn0GOEZfGDZvOwWUqHAQZ4kV VeqTXVwK1MiuRBmACVV6GV7cDiGBljlk0GCdISnYlyXj2fkGLli42xqL83jVefG3FCKT3a5 fCPlaEjBqv7kDtLPQRyV3itoimHqic3hyZ9NEbyiVXPUFTjVMD2ylzzDKBkP5ZDLHPMFQJd PsK2v+ZFARIImacLayFoA== X-UI-Out-Filterresults: notjunk:1;V01:K0:2IbcKAhF6Ao=:fdvemfjgrScuazn2ocfRu1 yABmlgQI5RC6XoG0uVju/rDQEzuI2YXM044uql/WIZXvtbomKipShR8CJi+z5/a4n6jsSX4fJ hRNdkA3ZkPR86BToCQM+iRZzUS0RgJXp3nBDFvR+hZtq1jCJ7gWrn/HL99igZzluq47ZCs5wj FtThj06P+BrDB5xCAIiKCTcrHgqicRnv9e8gQ18tpdeMUTcpdONUMbzzGvkhTGXRZP8fjECM0 wVcCfQSwcAMNazboAHRP6+li8wetiklERjXzLLwL+sL2LWmbWZAyKMXT0efqwmtuHLg9Tc//Y 9TpBVmQ2tVK/xsfn5j2SzuqNu5MOciZ1q1A4QDCJohfTM8JWjqImSIMKBEg1awz6G5phWMEPU N4PqtU8fM8AJNdXNmP8mDMrTUKyPoobjh0aUkEsPuUtwaQ4vsqNRyKeC8Sq9AzavxyE5z1z2v ajlYuSs2PlK+qFehz1Kk2UlGQwYqwCtm5R4viIpsO2H3HDp6PfEAu42S7O9gsGxFDjMi+Vqxn 4/2H0HWUwi/QJ161TAvD8BJhHfk6MvE/5Xthi5ByWbGo+K1LV7OMPHDSSEBf+SGUi3VInrzq9 KozLKdYxxBkMfuhwflMZ7d6bcaxH56A/Ghr4VCXFOaFnDGjJHfGQy3vQ9fDVaMNp9YaxuZ1xx PwDMl5PY4y6no7F/aCMLv6FUV0tb6V5ISu4onLD8sAERT12mksFKydEFnPYokOPg+pwMMH5u9 O5E9xmKK6p3Z3vcJS3p+5NmlkE+fMitlSEFWdF1+fPIwrZwvRLCCahRoc1WaUWkDEdtBpFJap IKULHQa Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 25 Apr 2017 10:17:06 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: Possible unnecessary 'out of memory' message Thus remove such statements here. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/hsi/clients/nokia-modem.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/hsi/clients/nokia-modem.c b/drivers/hsi/clients/nokia-modem.c index f6c97a0e1fcd..a774ca7839e1 100644 --- a/drivers/hsi/clients/nokia-modem.c +++ b/drivers/hsi/clients/nokia-modem.c @@ -104,10 +104,8 @@ static int nokia_modem_gpio_probe(struct device *dev) modem->gpios = devm_kcalloc(dev, gpio_count, sizeof(*modem->gpios), GFP_KERNEL); - if (!modem->gpios) { - dev_err(dev, "Could not allocate memory for gpios\n"); + if (!modem->gpios) return -ENOMEM; - } modem->gpio_amount = gpio_count; @@ -156,10 +154,9 @@ static int nokia_modem_probe(struct device *dev) } modem = devm_kzalloc(dev, sizeof(*modem), GFP_KERNEL); - if (!modem) { - dev_err(dev, "Could not allocate memory for nokia_modem_device\n"); + if (!modem) return -ENOMEM; - } + dev_set_drvdata(dev, modem); modem->device = dev; -- 2.12.2