From: Holger Dengler <dengler@linux.ibm.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: David Laight <david.laight.linux@gmail.com>,
Ard Biesheuvel <ardb@kernel.org>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Harald Freudenberger <freude@linux.ibm.com>,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: [PATCH v2 1/1] lib/crypto: tests: Add KUnit tests for AES
Date: Fri, 30 Jan 2026 11:54:52 +0100 [thread overview]
Message-ID: <72667cb9-f30c-4a9d-97b1-355cc23d8b8e@linux.ibm.com> (raw)
In-Reply-To: <20260129011838.GG2024@quark>
On 29/01/2026 02:18, Eric Biggers wrote:
> "AES_BLOCK_SIZE * NSEC_PER_SEC" is missing a cast to u64, as reported by
> the kernel test robot.
>
> But also as discussed in v1, using ktime_get_ns() to time one AES block
> en/decryption at a time doesn't really work. Even on x86 which has a
> high precision timer, it's spending longer getting the time than doing
> the actual AES en/decryption.
>
> You may have meant to use get_cycles() instead, which has less overhead.
>
> However, not all architectures have a cycle counter.
>
> So I recommend we go with the simple strategy that I suggested, and
> which v1 had. Just the number of iterations in v1 was way too high.
Ok, I'll send a v3.
>
> - Eric
--
Mit freundlichen Grüßen / Kind regards
Holger Dengler
--
IBM Systems, Linux on IBM Z Development
dengler@linux.ibm.com
prev parent reply other threads:[~2026-01-30 10:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 12:12 [PATCH v2 0/1] lib/crypto: tests: KUnit test-suite " Holger Dengler
2026-01-19 12:12 ` [PATCH v2 1/1] lib/crypto: tests: Add KUnit tests " Holger Dengler
2026-01-19 16:39 ` kernel test robot
2026-01-19 17:22 ` kernel test robot
2026-01-19 20:31 ` kernel test robot
2026-01-29 1:18 ` Eric Biggers
2026-01-30 10:54 ` Holger Dengler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72667cb9-f30c-4a9d-97b1-355cc23d8b8e@linux.ibm.com \
--to=dengler@linux.ibm.com \
--cc=Jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=david.laight.linux@gmail.com \
--cc=ebiggers@kernel.org \
--cc=freude@linux.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®