From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f173.google.com (mail-il1-f173.google.com [209.85.166.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46E86323D for ; Sun, 10 Nov 2024 02:19:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731205172; cv=none; b=aF8NIwIKVfQmwZStVrdt+dvDYObjXpolwAtFcqLjsms5a5ie9PLDKhSrgchcPt7lKA9LIRjc2z5f6ri6BKHSQje7gn7+5lwcj3mgqEEc43ief9tXvzYGCVNXhlvcO27TkxQs8bA6Fh+JGwxLQCu6fQMtUrgggd/2uN14rWGucbQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731205172; c=relaxed/simple; bh=+pD7XKkk7a2kvnad7+CqzCvmXc+hzqXdXdhSGLuRglg=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=RWOb+eFrkf0Gv51geWP8BDEax5Xem/qA09SmhjKAFRPMxELnfWrTtSUyYfbMLeD4HjqIPvLC1bHoHdjs04rG4xLSRC1cG0OWXSmGPvOxxSRvVm1wOKgKTIBFs5yLlcpBccDPnN1EFlRCgek/jMqdzQSlq2PzWzth4wS+vEpW1HE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=PGDvkbDT; arc=none smtp.client-ip=209.85.166.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="PGDvkbDT" Received: by mail-il1-f173.google.com with SMTP id e9e14a558f8ab-3a3b28ac9a1so158725ab.1 for ; Sat, 09 Nov 2024 18:19:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1731205170; x=1731809970; darn=vger.kernel.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=wtYxf79bGu9AQ23SIiIULXTG3CqHwpSP3g6NHEutdz0=; b=PGDvkbDTUZlrFV0XwDHfKC/xqpV7eA2G5OVVtsbdZSHm/t3LzHM/x47NcuJfvVeFIw UO3o+QlH1OLiyFP85fCnohJTGdGJju3UA7vZZsu9NpJn+AKJLmXPUsz9oT2rp3xr/f+m HkhQBVS63X+LvPLcZzJxdP0dCGohfC71COwGYs5lIWTbg0TORDekM8/Ua2FkhXh3a+JV DvB6f2SgDwJ54fEuiZ3I1jaUIGp6EEPrTAx22pNWbhY3QxM2xfT4Dx45fk/Zl4jfvyS5 rr+425fqBgZM2AMe1MYPYaFiGRftZT6FuzzQ9aX3PtTkUoQshkWtkVLoXdkCjCsaINc2 Qf4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731205170; x=1731809970; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wtYxf79bGu9AQ23SIiIULXTG3CqHwpSP3g6NHEutdz0=; b=Nv75KMG0f7QWMYKR9KpjuHSu9gpPuhpc+eMEiX2Hn5VzD5oeEKFTnNgEn0pEueQpCc +kcdGjlQovbUYkEYAWw65bhEMYdD65u/V8DeGu27gWFMFbUA8CxUmh7UJ4q8UhwqvK04 8WHXZM+4rrk3CbH+ag6etTf065H+J4xad7E50+Ot1KCguVbwshHgu0KyTaAOmy7d1yEE KI4n4vfG/14cyoLQkh2Z8KNAsvfHxywTXs2583ymL+CNvwc23HhLHL4sBp1n4eU5XDDu JygTYkM5sprlu/jpkOjBx1fkcpVreFUCHLDEgoDSIEcztcRQogJSTCI/2smccsR3nyMb Ebmw== X-Forwarded-Encrypted: i=1; AJvYcCVYP0+hEO2u4FbR62gny657EVtXRLu2GEV611qmvmjlKaSTnhTaZ13sOzoxmNz+cMm2Sndta0EOZq/coOs=@vger.kernel.org X-Gm-Message-State: AOJu0Yyxh9QjZ+rV2nlar+K3rGGnOOivgJLRPzCB1cuEgDYaF6ACtggH LuLR3FlygTgxmoi8BYd+3YlZ3eaTT68NuTNrfSl5ZqzKqIohdTYUAHPyGFw65Q== X-Gm-Gg: ASbGncvMWJEfvmHoBvAhQHDColnwz6Sm0nps1jd8cTyBpl84/Fa3rHreOjzeMkuTqqO YVn+Q0yIqdDswOiocvoKoiF+CidpJYv1yXJs4x/LGXWCQ8hsRI5veZpfufZX64cxGHKps0YeD9F n6qCaGwLX3yIGhvp62tCqoG34S6/2QS7CqD6j+ALH1lOexteEiWKjmIBBMVJ9DZKlDrLnojQ6SP rd/BmKFDYkuG71Vhi8XMvVMKlGQWL1PL9qr/EzaLlUAWBeEWWDBnu7yQS1L2E8N/sBHAyhKjUG8 6i9I X-Google-Smtp-Source: AGHT+IGOlRHUbzZ277/dq/Etm+M1ZnIxeb6x0lBP5+1k9gAuZMD69+G3KnUOpKIiYz3VJ0FVMcaicg== X-Received: by 2002:a05:6e02:1946:b0:3a0:a224:eb2c with SMTP id e9e14a558f8ab-3a6f9564132mr2137955ab.25.1731205170261; Sat, 09 Nov 2024 18:19:30 -0800 (PST) Received: from [2620:0:1008:15:c964:b0b2:aab1:6944] ([2620:0:1008:15:c964:b0b2:aab1:6944]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7f41f5f048esm5013642a12.50.2024.11.09.18.19.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Nov 2024 18:19:29 -0800 (PST) Date: Sat, 9 Nov 2024 18:19:28 -0800 (PST) From: David Rientjes To: Joshua Hahn cc: akpm@linux-foundation.org, hannes@cmpxchg.org, nphamcs@gmail.com, shakeel.butt@linux.dev, roman.gushchin@linux.dev, muchun.song@linux.dev, chris@chrisdown.name, tj@kernel.org, lizefan.x@bytedance.com, mkoutny@suse.com, corbet@lwn.net, lnyng@meta.com, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH v4 1/1] memcg/hugetlb: Add hugeTLB counters to memcg In-Reply-To: <20241101204402.1885383-1-joshua.hahnjy@gmail.com> Message-ID: <72688d81-24db-70ba-e260-bd5c74066d27@google.com> References: <20241101204402.1885383-1-joshua.hahnjy@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 1 Nov 2024, Joshua Hahn wrote: > diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst > index 69af2173555f..bd7e81c2aa2b 100644 > --- a/Documentation/admin-guide/cgroup-v2.rst > +++ b/Documentation/admin-guide/cgroup-v2.rst > @@ -1646,6 +1646,11 @@ The following nested keys are defined. > pgdemote_khugepaged > Number of pages demoted by khugepaged. > > + hugetlb > + Amount of memory used by hugetlb pages. This metric only shows > + up if hugetlb usage is accounted for in memory.current (i.e. > + cgroup is mounted with the memory_hugetlb_accounting option). > + > memory.numa_stat > A read-only nested-keyed file which exists on non-root cgroups. > Definitely makes sense to include this. Any reason to not account different hugetlb page sizes separately in this stat, however? IOW, should there be separate hugetlb_2048kB and hugetlb_1048576kB stats on x86?