From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752982AbdJLPSA (ORCPT ); Thu, 12 Oct 2017 11:18:00 -0400 Received: from g4t3426.houston.hpe.com ([15.241.140.75]:31285 "EHLO g4t3426.houston.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751394AbdJLPR6 (ORCPT ); Thu, 12 Oct 2017 11:17:58 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=mike.travis@hpe.com; Subject: Re: [PATCH 2/5] x86/kernel: Skip TSC test and error messages if already unstable To: Thomas Gleixner CC: Peter Zijlstra , Ingo Molnar , "H. Peter Anvin" , Bin Gao , "Prarit Bhargava" , Dimitri Sivanich , Andrew Banman , Russ Anderson , , References: <20171005164716.233817374@stormcage.americas.sgi.com> <20171005164716.507003714@stormcage.americas.sgi.com> From: Mike Travis Message-ID: <726db3a9-3607-3105-770a-d5e5927b1874@hpe.com> Date: Thu, 12 Oct 2017 08:17:34 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.48.179.6] X-ClientProxiedBy: MWHPR2001CA0023.namprd20.prod.outlook.com (10.172.58.161) To CS1PR84MB0184.NAMPRD84.PROD.OUTLOOK.COM (10.162.190.143) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0a53f300-1c3d-4fa1-3d61-08d5118461d4 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:CS1PR84MB0184; X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0184;3:DWX/UQpqC06KAhacCFDk7DwXDpZMQLdObgccyRG1YmFIkrwZK1ycpiwtBTKhcwAaSXDRiTkG3Ax+qdxaBOJMCgmSxnz1OYeC8SGebsPLfIiqz8JSBK96nvc2lSaBWzHfRSb+BgqxDaQihmrMn2V9TEeXesYYHArhxw+cvOoHU3ec9iUV9RcP3yg5theBN4vN978W76p/8FeDT5LVjO5M4vE9hiVgDXp0yWlPZzdKEddsShS3bLDKJYx4h7SgMxmO;25:dlEIRbgJTbCvEO6dB5uHAiftns1P2z8rhObvZjK4jRJUnjYp9pvdQsASSwsGE+T1RFHUUL31tYPwuemrMvcYzgKLxK7hxuGi0CNC1/e5lbAMVSbqUKwqXRzBLwhbu7YxHPk+mZ75yyPKUY2eTytsjgqO0FiaMEddIFnaDpM8dDwDKy9XJCWGFP8PfNoloIx10aTDOTWlbCwc8ucgubucl9USh5DhYeSARkDZxxL6NWIio1HKHpi00SAORw/qvOzkke1JvFBuCirzss7sGEXGRCCI3LBPHucpPhOSgiTLPFsFQ7QBqRoScKbjwI9aRzShu1OZzBxckZ+oKvZj92r9eqrtfjpfQUYYawlKKTqSn3Y=;31:+cZpYiMxIyf4Avy/S3hsLRz7uyUypDXJ1MO08jLtQ4DN8mwOzkr2dFCMx/kAmLPAw8PK5U7+trULAWS5rELgA8uw9DwQy0OCGbdP1noH59ubfXtTaljAFYTbuaFVDK2AAxuiEMelK++BsFZAeoY/YLR4v5s+Go//QIzAQIQ4njzfzKEFQUPxXJVrm1flnJbeSbzJsVku1YH1OPaQdcG2DJuKcAB/GTaDX+vTnuRIOUk= X-MS-TrafficTypeDiagnostic: CS1PR84MB0184: X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0184;20:fOjGV90fWiV+BMX/kBvYqgCqT+5ay7zzywwbv2NhavKesCjrz41eYHtqNaUIQqdVG0k7h92voCNzM0rtWS7bmbDvPN7wskrZn+rpmdw6XKLIp/68U6X8q5RvyM/u93l6J25ghh1u9UK+P38HhTdKY8ORIquuLmJEMoXrBjaNe/HlrxSA1rnhCj91TeFmBahhoBhzVh+YvHAujW3JOELkb8MZ0UgzJ5jPun6iK1QSx7gJ+zjq6a/MHNXakC0fs+HgnTsepCizsK5YtRpqhK1mrCMwCBtsBh7hvy3CKlz5ACndKtx+5uTuwIT+TNI917aUuhZfs/kp4BsJ88Qj4zf8bH+V8Cxwc7mY8z+XlfLe2MxMtm6cDD0qmTGNADMG7YUjgUW1jCatP8/BoLvOFGDyBD7FXDoukYSoBMOQw/92DNQ7VHQaNpyDwFeO525yaXoQf4PWcygEullrl2PfHLWbG+uU/Amyd5dX68ToIgtLQTg8QyclegWXxogge531eUwi;4:hnz0Y0MFMYVU1HN7JCiUKui0cIyMZEMvquHjua+PCZcsNllxyv+3mlF2L+v45gal9Ql++yboIViY9GEot34a5rL3zFxoUhJkp1QH1Kg/DqWQwZSfZdR7mXP47T1VBxoTn5iq4lWZAe2OSQt8p4Y4k7m1IL68vnMmu/lBpclou+YzAxaQVnd2QiyJbrZw5bvDmXoC0z5ZKAQGEX1WSAKiteynRBoqgmuwAC8zYpnPXtJ+GcG6ssJWkNJc9XdYhL9W9phI4Z1HfR9NL+DcF6uMZwZkwTZ/WFj7CXccCu4fuRA= X-Exchange-Antispam-Report-Test: UriScan:(227479698468861); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123555025)(20161123558100)(20161123562025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CS1PR84MB0184;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CS1PR84MB0184; X-Forefront-PRVS: 04583CED1A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(6049001)(39860400002)(346002)(376002)(189002)(377454003)(199003)(24454002)(2906002)(81156014)(15650500001)(53936002)(36756003)(478600001)(6116002)(81166006)(3846002)(65806001)(8676002)(8936002)(53546010)(105586002)(33646002)(101416001)(230700001)(86362001)(65956001)(31696002)(5660300001)(47776003)(49976008)(31686004)(66066001)(65826007)(54906003)(305945005)(6486002)(7736002)(6916009)(97736004)(50466002)(6666003)(189998001)(16576012)(54356999)(16526018)(50986999)(316002)(229853002)(2950100002)(3260700006)(58126008)(83506001)(76176999)(106356001)(4326008)(25786009)(6246003)(68736007)(64126003)(23746002)(78286006);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR84MB0184;H:[134.15.1.45];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CS1PR84MB0184;23:8zHRomT8kKkoYNWqL/t+glDSOiBhKWMv0ljDE?= =?Windows-1252?Q?Zzv2tTeRYfqWYoP3l1VR8j/JwSbTMWDohBM9pQnyMTo6AhNdLcDZnmz/?= =?Windows-1252?Q?7aknccvh0mXHZHjsSeD/glk96Ifg5VuwQydvlqWeyUgPnW4qO7/mMN3p?= =?Windows-1252?Q?007oTWuq23q2r4RjGWAzLt0Na3rSYskQQNKBXHMSOvR7PDHSvJmLl8Qx?= =?Windows-1252?Q?ooYVoj/u6rK/Fc3UQ23ARuSvB+7FxVBpv7NmjOA9QFLD4/4pPUHPHdlO?= =?Windows-1252?Q?UyApiZMnbxzwvqHzzgKigW+XLwMsv3Le6Bec4cHeFpNTu02HSmDxC1eG?= =?Windows-1252?Q?iu+DCzEKELYSSRpZM81e5UM9NGOxk1mMK1tNYXCinE1ntcJafGgAnSIK?= =?Windows-1252?Q?EMN3KBX0QskmPV5qCpGIWQ4R6MJYyk7d1cgO4SEU+Mno1eyy8vM4UyYb?= =?Windows-1252?Q?hl2p+wMYx6Zav/WjESYuxkWHnDVHoaHgYhXIxftns76/1Yi+29LBzvKD?= =?Windows-1252?Q?yO5WYNe+1y6ho/KjzvbDcLQYbSfREji8+48AupHRVWmXuXSNepICjTOr?= =?Windows-1252?Q?v8Gvpjr1eEcJaR25K3nzNymPLJgeDLSV2CRit7pEQDo1ejW/wSkOJ7gJ?= =?Windows-1252?Q?f0hGkcM47T4uKikq9eghmvSNt3IpYnMIwYG0KMJhxOmP1sZvpsF5iP9Y?= =?Windows-1252?Q?k1s2uZvApanoNNcVF1RWzxMIo0YhqQMVs26tFQNrqj34EHtA0cWMz1w3?= =?Windows-1252?Q?2M/XrR84x0QrRdXh9F346pyaigc2RvY/tYJK2X7XT9mK7XN/UbJsxhZA?= =?Windows-1252?Q?MYiBzh5scrTkoYABzuCTx54manUZlzYY4sUlpGc1fCqpxpmtlYvFZJ0n?= =?Windows-1252?Q?SCAP329m+/agRuGgPI4tDUTEAM9riA332XyOQ2kg+pFKx4M1pjHWrppF?= =?Windows-1252?Q?K6JdSYpZtY6xa+3C7yiOIbRMBO/pB9JXNb0GHIFp4Uvd2NtGEaITyiS+?= =?Windows-1252?Q?WDDfTvrUQeHgMnkkLs8TXTDQvW8LGqpw3a2ECCGIK7KKjDk0mcRXJWoK?= =?Windows-1252?Q?T0OIou90pvK6kClXKuJ5W3xqgAgnbGy+kOCRKd471qU5vLmqSubOjHv0?= =?Windows-1252?Q?qwu09vxXMQUl9yE14KcJmpSBgxfE0ffbuFWLD5kxgCgndtmUSoSRFqH+?= =?Windows-1252?Q?ez0LS2nKuK8xHyqb8IEX+St6ro0oP3hlMvWUZL3QM0SClm6q+FxCEpdJ?= =?Windows-1252?Q?fgkgNI+3eubfC99xsfQtLzJImm3A2aXfZs7VaaJYtidrkE06CB3q2vWG?= =?Windows-1252?Q?ygQJ2dRG6Tb4v8IRUmNwJnO23+IUpG9vAjLrjGavuEe8IQskqDiIq2+g?= =?Windows-1252?Q?8eQhZsfEIf7pc2MPS6yZD8KY+d+zh1HbpiIo53XCOru15iv5KwcS8XpX?= =?Windows-1252?Q?ldkll+fUoXQd+rZLAVJRpzVV8H4tAAIH3UdU3rQjnmqxOEXa3bkdhuMJ?= =?Windows-1252?Q?8diGt2eGY4y/VzrLHLsO6bx+2USPibrfOADN80pJGc2jtklrpHOyOpqA?= =?Windows-1252?Q?KhfMs+2OHG62+3/urqp8YAl12Ls/tQV0e06?= X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0184;6:xdn78B5OPc16U1Jjee+pP1coPHvEw6bzl+P5TKQhZ7qcm3aOCQQT2cWTUFVDjeNVhGZ+8WVtz2QLk8w+YzPnc0RAPzHFGRkiCCen9JF3PhGNTrSBpdAIErBfy2lnHmm265TAJNPf2+WUTOURIwVnHLRyhh4eD1PP9SI60uzgANqbyAoemDMvwLjqXaIYmgbyarFEFstYbloKF1+GFibEGV3annLKgGyeJQ/T4Gt/jJ1gW2J5bHOlmX4lugnNIKcOLipIec7r6GWV+kfGMtpUJJosq927ljnq03WIM4JHL+DNV+w38Laro08AWuxfKPdzmty/2vzdcT7xU4ThGNdENA==;5:+opxz3/KY4PhnyArO2pqT7ZcHIp+dlHb/Hj5F6BLkAmZ70MNF/Iwl8HbRQCOga2YvZMa+T30Sd8WGq9YcW9yhKyjI/X5Hl6hr5U/uim2RunIMPRhlbEePVnJZnBQ0BI4XMw4lvMFLDO6nKKRX8/QAuL0rgvToOHoGKDnGFZ62rg=;24:gWQTz2p097k/6iTmXr8xBINBLpaNhJETtgUNbCjWvT5hBaNq1y3wSpsAn+KBVZb0B4l/ViP36cSO/qrP0RE1UzQVKH8kDcCVHYv3BcXN/Vg=;7:y6mgSkXXUC2a0wYj+j95Tt7nGs4Ue6Gi8VAPNXJ8jl2sTm+xuKExPtddrTzB3U2qVlIPa6OG9KbzMZKDGb4aHYTXFtPjtNezrEoVjLaDD5Fv05fsb46d3Gvjr7kNyt/2IxhryhFR4IhJOHn/ioDKQqoMeQV4NEcnfN10T7QLl8/VtvOwmIQjrAxJWdfU0RGy7Arlj16meqkdCAH24Kw7cpcGtFe9R/eUCUl+GjNlQK0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2017 15:17:39.4634 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR84MB0184 X-OriginatorOrg: hpe.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/12/2017 4:17 AM, Thomas Gleixner wrote: > On Thu, 5 Oct 2017, mike.travis@hpe.com wrote: > >> If the TSC has already been determined to be unstable, then checking >> TSC ADJUST values is a waste of time and generates unnecessary error >> messages. >> >> Signed-off-by: Mike Travis >> Reviewed-by: Dimitri Sivanich >> Reviewed-by: Russ Anderson >> Reviewed-by: Peter Zijlstra >> --- >> arch/x86/kernel/tsc_sync.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> --- linux.orig/arch/x86/kernel/tsc_sync.c >> +++ linux/arch/x86/kernel/tsc_sync.c >> @@ -38,6 +38,10 @@ void tsc_verify_tsc_adjust(bool resume) >> if (!boot_cpu_has(X86_FEATURE_TSC_ADJUST)) >> return; >> >> + /* Skip unnecessary error messages if TSC already unstable */ >> + if (check_tsc_unstable()) >> + return; >> + >> /* Rate limit the MSR check */ >> if (!resume && time_before(jiffies, adj->nextcheck)) >> return; >> @@ -89,6 +93,10 @@ bool tsc_store_and_check_tsc_adjust(bool >> if (!boot_cpu_has(X86_FEATURE_TSC_ADJUST)) >> return false; >> >> + /* Skip unnecessary error messages if TSC already unstable */ >> + if (check_tsc_unstable()) >> + return false; >> + >> rdmsrl(MSR_IA32_TSC_ADJUST, bootval); >> cur->bootval = bootval; >> cur->adjusted = bootval; > > This hunk rejects and I really can't figure out against which tree that > would apply. My current merge tree happens to be 4.13.0-rc1 which was the latest when I started this patch submission. I can update my merge tree and reapply if need be? > > Btw, there are two incarnations of tsc_store_and_check_tsc_adjust(). > Shouldn't the !SMP variant get the same treatment? I could add it though I'm not sure the point? If it's only one CPU would TSC's being out of sync become a question? > > Thanks, > > tglx >