From: Joe Perches <joe@perches.com>
To: dev-harsh1998 <harshitjain6751@gmail.com>, trivial@kernel.org
Cc: Michael Hennerich <michael.hennerich@analog.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Simon Budig <simon.budig@kernelconcepts.de>,
Andi Shyti <andi@etezian.org>,
Luca Ceresoli <luca@lucaceresoli.net>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/11] touchscreen: ad7877: Use octal permissions
Date: Sun, 22 Jul 2018 01:29:07 -0700 [thread overview]
Message-ID: <726de8d70365597715ed62c0d99bf2a7adaa3362.camel@perches.com> (raw)
In-Reply-To: <20180721191029.25658-1-harshitjain6751@gmail.com>
On Sun, 2018-07-22 at 00:39 +0530, dev-harsh1998 wrote:
> WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
> +static DEVICE_ATTR(name, S_IRUGO, name ## _show, NULL);
[]
> diff --git a/drivers/input/touchscreen/ad7877.c b/drivers/input/touchscreen/ad7877.c
[]
> @@ -461,7 +461,7 @@ name ## _show(struct device *dev, struct device_attribute *attr, char *buf) \
> return v; \
> return sprintf(buf, "%u\n", (unsigned) v); \
> } \
> -static DEVICE_ATTR(name, S_IRUGO, name ## _show, NULL);
> +static DEVICE_ATTR(name, 0444, name ## _show, NULL);
I believe this could be
static DEVICE_ATTR_RO(name)
next prev parent reply other threads:[~2018-07-22 8:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-21 19:09 dev-harsh1998
2018-07-21 19:09 ` [PATCH 03/11] touchscreen: ad7846: " dev-harsh1998
2018-07-21 19:09 ` [PATCH 04/11] touchscreen: amtel: " dev-harsh1998
2018-07-21 19:09 ` [PATCH 05/11] touchscreen: elants: " dev-harsh1998
2018-07-22 9:39 ` Greg Kroah-Hartman
2018-07-21 19:09 ` [PATCH 06/11] touchscreen: ili210x: " dev-harsh1998
2018-07-21 19:09 ` [PATCH 07/11] touchscreen: mc13783: " dev-harsh1998
2018-07-21 19:09 ` [PATCH 08/11] touchscreen: melfas: " dev-harsh1998
2018-07-21 19:09 ` [PATCH 09/11] touchscreen: raydium_ts: " dev-harsh1998
2018-07-21 19:09 ` [PATCH 10/11] touchscreen: sun4i_ts: " dev-harsh1998
2018-07-21 19:09 ` [PATCH 11/11] touchscreen: tsc200x: " dev-harsh1998
2018-07-23 5:08 ` Martin Kepplinger
2018-07-21 19:09 ` [PATCH 01/11] touchscreen: ft5x06: " dev-harsh1998
2018-07-22 8:29 ` Joe Perches [this message]
2018-07-23 13:19 [PATCH 02/11] touchscreen: ad7877: " dev-harsh1998
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=726de8d70365597715ed62c0d99bf2a7adaa3362.camel@perches.com \
--to=joe@perches.com \
--cc=andi@etezian.org \
--cc=dmitry.torokhov@gmail.com \
--cc=harshitjain6751@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=michael.hennerich@analog.com \
--cc=simon.budig@kernelconcepts.de \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®