From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD50E18C00B for ; Wed, 29 Jan 2025 03:57:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738123058; cv=none; b=b/54UDXglIl5Pwo5XpocvvJ1rppqSPRghMXDGZ3gZApVbKED8NiAVxeVAT8LqiPMLEs1r1IQz8M1bFz0Ny6AA+8E7XHDoKkXzqeqrG8u/c0SLU76A9VNpVximuQzGru7knrG86XTs4w7t2RoIf6aXZ8T0rEhui8tdnSRAF1VeyA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738123058; c=relaxed/simple; bh=w1SayiDT6fHbjeRtPtYcD6dD/o7ljGA0MzGpca4ixSg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RDkCgI4nBt9iKphsHKrjl+zm67pwYVhXVOgnCRtTa/fpXTOHUkJ9Np+H+bRFvCWO2mFUTxtMdh4TTwqRRuszwkF4r0QGdCBlJEP8RCvpgmR8iKHmIxz4+vYEcb5fG0dcAs7a1iZ2dbPf9AeRZGy7aPJbkTXeSsezd+oJ7tfdiVY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=glfDfJHa; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="glfDfJHa" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738123055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zB7bwFdWnORe6bKwIQ/6vJQvYuugxQ4y04Yn/yJKnPc=; b=glfDfJHajjkpoKDbP3N33S3bXnJA7RdqnC1+DmMqevCoZGr6Wb2eZ/iwYppMR6D+URFx+Y gVTtyPluhFS3EyBMMhcs8XZ1zJJeBfDi/zLZRJedtt+PUho7NbbAdvNIT6MlvZXA5oo6wa uPVFW2N6QiIDeoS7vNGjvyPTclXhItk= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-278-aScMbCpQN22PW_hDvcF1gQ-1; Tue, 28 Jan 2025 22:57:34 -0500 X-MC-Unique: aScMbCpQN22PW_hDvcF1gQ-1 X-Mimecast-MFC-AGG-ID: aScMbCpQN22PW_hDvcF1gQ Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2164fad3792so111748205ad.0 for ; Tue, 28 Jan 2025 19:57:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738123052; x=1738727852; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zB7bwFdWnORe6bKwIQ/6vJQvYuugxQ4y04Yn/yJKnPc=; b=NfBK7cqzm3aknmjeDN1opBq/mbiQ1bYOcHBOJ6IK7mfTZJAcx8iAurxmKxSCxAXtiR mKAcnrR7rFXOYWZs5onlzkYpPX9Ej3iIbugsRpME04NnJldhFUb70KOf8lwo3KiMACuA sG1irw1JV41Gc6blR6KdCsFT22OPOpIBKUmKK0v7RHfpdeC/JyWm4O61KD1UnRvxcYPo 7vn3+UBf85GDTDLnDMPrLYn+7RYCamkGp4okQqwkk6807tw1g83Z213uYviYBshVAhi7 KsD4bUzJExflxx4MmoKK14Mbr24akwWgVuiqj6BmZllym+uo0hn3nt5PhLjfoRlF07sx 7YGg== X-Forwarded-Encrypted: i=1; AJvYcCVaW5GsUJLzRwGiAxVlidW8DaG7FNXD9dNus+yX65xuOk/F60wObprvSJrD53bV07YBLM4HvdO6MfN79D0=@vger.kernel.org X-Gm-Message-State: AOJu0YxAsDsPqb8rKdniGh61zQ8JJMwiy2xXyLgJvcB51If7CHxEJwz0 xlRWUnY9e+LrmD5zZ4pbGORxnUjMSPVHeiAyXeRh+Fqte38MzOo43fdKdqZ9ndrMhojccQti6Wq gBSJw0X3wkhVVFigj4dsMv+xJJreFzKdltr9fbK2B0sbvCTK4VFdT6CW7v2ZHdQ== X-Gm-Gg: ASbGncsO/JM9SP8NDyf0vY/Zl14d/R6mJjSZ4ERAG4w55dxaDdZyFRFxiAPAQ7B9LXW qFZ1gtQXB+QXMceq4czJ3iF6tqMyIsxtN5QkYjClhRYMBZ5i5bUX6yIBo/XCMlWKOrnQ0ciuX44 T5rqU3BqLfXS2rzSvIpAWi9VWKgVAORyaxUQdrydgrY+f7Rp26LW8YFHixRpwsmF7QyE1ju7GB+ YQO237kEAAVkZ7CikD+gH1YCVofDCnydNnaEkiji1HeoHRBFVAhKgXDEMIhS7Wf/xNsDTPpfjeS oIWgWA== X-Received: by 2002:a17:902:ce8f:b0:215:9d29:9724 with SMTP id d9443c01a7336-21dd7ddfdc9mr26688115ad.38.1738123052530; Tue, 28 Jan 2025 19:57:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IFdY9KvQ422zqadztWkjkXDL2LuY//Pm08gZwRPHxwWf8KuGeFvCcuuj/IQ8VEC/M+7z5zZXw== X-Received: by 2002:a17:902:ce8f:b0:215:9d29:9724 with SMTP id d9443c01a7336-21dd7ddfdc9mr26687925ad.38.1738123052171; Tue, 28 Jan 2025 19:57:32 -0800 (PST) Received: from [192.168.68.55] ([180.233.125.64]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21da3d9cac3sm89760675ad.38.2025.01.28.19.57.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Jan 2025 19:57:31 -0800 (PST) Message-ID: <7271b3ff-8665-4a98-b3dd-77417f85d5e3@redhat.com> Date: Wed, 29 Jan 2025 13:57:23 +1000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 06/43] arm64: RME: Check for RME support at KVM init To: Steven Price , kvm@vger.kernel.org, kvmarm@lists.linux.dev Cc: Catalin Marinas , Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Suzuki K Poulose , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev, Ganapatrao Kulkarni , Shanker Donthineni , Alper Gun , "Aneesh Kumar K . V" References: <20241212155610.76522-1-steven.price@arm.com> <20241212155610.76522-7-steven.price@arm.com> Content-Language: en-US From: Gavin Shan In-Reply-To: <20241212155610.76522-7-steven.price@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/13/24 1:55 AM, Steven Price wrote: > Query the RMI version number and check if it is a compatible version. A > static key is also provided to signal that a supported RMM is available. > > Functions are provided to query if a VM or VCPU is a realm (or rec) > which currently will always return false. > > Signed-off-by: Steven Price > --- > Changes since v5: > * Reword "unsupported" message from "host supports" to "we want" to > clarify that 'we' are the 'host'. > Changes since v2: > * Drop return value from kvm_init_rme(), it was always 0. > * Rely on the RMM return value to identify whether the RSI ABI is > compatible. > --- > arch/arm64/include/asm/kvm_emulate.h | 18 +++++++++ > arch/arm64/include/asm/kvm_host.h | 4 ++ > arch/arm64/include/asm/kvm_rme.h | 56 ++++++++++++++++++++++++++++ > arch/arm64/include/asm/virt.h | 1 + > arch/arm64/kvm/Makefile | 3 +- > arch/arm64/kvm/arm.c | 6 +++ > arch/arm64/kvm/rme.c | 50 +++++++++++++++++++++++++ > 7 files changed, 137 insertions(+), 1 deletion(-) > create mode 100644 arch/arm64/include/asm/kvm_rme.h > create mode 100644 arch/arm64/kvm/rme.c > [...] > + > +static inline bool kvm_is_realm(struct kvm *kvm) > +{ > + if (static_branch_unlikely(&kvm_rme_is_available) && kvm) > + return kvm->arch.is_realm; > + return false; > +} > + kvm->arch.is_realm won't be true when kvm_rme_is_available is false. It's set in kvm_arch_init_vm() of PATCH[10]. So it's safe to be simplified as below if the changes to kvm_arch_init_vm() is slightly modified, more details can be found from the comments to PATCH[10] With the changes, we don't have to check kvm_rme_is_available every time. static inline bool kvm_is_realm(struct kvm *kvm) { return (kvm && kvm->arch.is_realm); } Thanks, Gavin