From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Colin Cross <ccross@android.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Neil Zhang <zhangwm@marvell.com>, Joseph Lo <josephl@nvidia.com>,
linux-tegra@vger.kernel.org,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Jon Medhurst <tixy@linaro.org>,
Sivaram Nair <sivaramn@nvidia.com>
Subject: Re: [PATCH v2] cpuidle: coupled: abort idle if pokes are pending
Date: Thu, 29 Aug 2013 22:28:28 +0200 [thread overview]
Message-ID: <7272744.lhUaaLc3cm@vostro.rjw.lan> (raw)
In-Reply-To: <1377740508-22134-1-git-send-email-ccross@android.com>
On Wednesday, August 28, 2013 06:41:47 PM Colin Cross wrote:
> Joseph Lo <josephl@nvidia.com> reported a lockup on Tegra20 caused
> by a race condition in coupled cpuidle. When two or more cpus
> enter idle at the same time, the first cpus to arrive may go to the
> ready loop without processing pending pokes from the last cpu to
> arrive.
>
> This patch adds a check for pending pokes once all cpus have been
> synchronized in the ready loop and resets the coupled state and
> retries if any cpus failed to handle their pending poke.
>
> Retrying on all cpus may trigger the same issue again, so this patch
> also adds a check to ensure that each cpu has received at least one
> poke between when it enters the waiting loop and when it moves on to
> the ready loop.
>
> Reported-by: Joseph Lo <josephl@nvidia.com>
> Tested-by: Stephen Warren <swarren@nvidia.com>
> Tested-by: Joseph Lo <josephl@nvidia.com>
> Signed-off-by: Colin Cross <ccross@android.com>
Still stable material I suppose?
Queued up for 3.12, thanks!
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2013-08-29 20:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 1:41 Colin Cross
2013-08-29 20:28 ` Rafael J. Wysocki [this message]
2013-08-29 21:23 ` Colin Cross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7272744.lhUaaLc3cm@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=ccross@android.com \
--cc=josephl@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=sivaramn@nvidia.com \
--cc=tixy@linaro.org \
--cc=zhangwm@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®