Re: [PATCH v3 2/2] nvmem: core: use is_bin_visible for permissions

[Srinivas Kandagatla <srinivas.kandagatla@linaro.org>]

On 25/03/2020 12:44, Greg KH wrote:
> On Wed, Mar 25, 2020 at 12:21:16PM +0000, Srinivas Kandagatla wrote:
>> By using is_bin_visible callback to set permissions will remove a
>> large list of attribute groups. These group permissions can be
>> dynamically derived in the callback.
>>
>> Also add checks for read/write callbacks and set permissions accordingly.
>>
>> As part of this cleanup it does not make sense to have a separate
>> nvmem-sysfs.c and nvmem.h file anymore, so move all the relevant
>> data structures and functions to core.c
> 
> And because of that move, it's impossible to see the real changes made
> here :(

Yes, I agree will spit this in to two patches.

> 
> Can you do this in two steps, one do the code/logic changes, and the
> other do the "move into one file"?  That way it is actually reviewable,
> as it is, it's impossible to do so.
> 
> I'll go queue up the first patch to make the series smaller :)
thanks,
srini
> 
> thanks,
> 
> greg k-h
>