From: "Ram Gupta" <ram.gupta5@gmail.com>
To: "Andrew Morton" <akpm@osdl.org>
Cc: "linux mailing-list" <linux-kernel@vger.kernel.org>
Subject: [PATCH]drivers: returning proper error from serial driver
Date: Thu, 13 Jul 2006 11:45:11 -0500 [thread overview]
Message-ID: <728201270607130945y30dbd388o76725b8a6fe28e56@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 252 bytes --]
This patch fixes the issue of returning 0 even in case of error from
uart_set_info function.
Now it returns the error EBUSY when it can not set new port. Please apply
Signed-off-by: Ram Gupta(r.gupta@astronautics.com)
-------------
Thanks
Ram Gupta
[-- Attachment #2: patch.serial_core --]
[-- Type: application/octet-stream, Size: 359 bytes --]
--- linux-2.6.17/drivers/serial/serial_core.c.orig 2006-07-13 11:17:49.000000000 -0500
+++ linux-2.6.17/drivers/serial/serial_core.c 2006-07-13 11:23:05.000000000 -0500
@@ -786,6 +786,7 @@ static int uart_set_info(struct uart_sta
* We failed anyway.
*/
retval = -EBUSY;
+ goto exit; // Added to return the correct error -Ram Gupta
}
}
next reply other threads:[~2006-07-13 16:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-13 16:45 Ram Gupta [this message]
2006-07-13 17:00 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=728201270607130945y30dbd388o76725b8a6fe28e56@mail.gmail.com \
--to=ram.gupta5@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®