From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA70D2222A9; Thu, 25 Dec 2025 08:34:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766651650; cv=none; b=mA7qu5r4w4RSuT0sjhodgc62fGxx4PeOTIrMCNpVLJfg4hylv2fYczeTjkNISov8b39LVoaUnucfuFbZ4VCHy6OfuPzy+WBxhvqJAt8f0s8We3douaP9scxSNTlGPgla5IKVApYW2vk+q/RdrexPf+pKc5xyy7yTIwJGSeduteE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766651650; c=relaxed/simple; bh=T2HvZypfEISRGptuaf4PARKSOQw8mxtwryHv6AL3Jjo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NMn9TSEKxtSpsGdfaFH95ZRtA4dc2hzf1T6FqDK6GMSDhrYYYYxnmgu/3t3kdoL/xV0nynDLyDQqQQvw0VwAqLHqrc6u92MlZLkxfhck81oQd71AsW/hk+TJi12AG+NoEsesRhNkAOoM75zS4MLxOdXO6OeWvFH51Mezl4+QS6c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZD8iJBP8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZD8iJBP8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E406C4CEF1; Thu, 25 Dec 2025 08:34:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1766651649; bh=T2HvZypfEISRGptuaf4PARKSOQw8mxtwryHv6AL3Jjo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ZD8iJBP85IJWQkgyjUKR+z1STR7btyr2VClR/O3gos+eJg6qtqrAvjNxhXe7eOI4p /Z2R7CgRNyjkXlsJvdvMIWw36LuwWZugxLGr/fBn0V2ORP6Xh7OblUzkudC2IJ5XtE 31vC356afH+EqUG0TSm+YiWl9BFaXJFPT0c/9FBjwiOHVwvSTDAFIVCHlGfL2ODpvB X25Tmqj+A0UGa0Y2BhF4j0SBN/J3bm9eWvHWFVxO8MUrqCzPquNrd6ZgW6etnqZSWW UMXKTCEcQLcKAjUQ9Hb5anMi0P9X0IPaB1wiimF/ekkvUv9cPQwPnffq7IEuBBOvLE 7Q3XoFWd8KzVg== Message-ID: <7283e3e7-54f6-4946-b526-2fa180f15c50@kernel.org> Date: Thu, 25 Dec 2025 09:33:59 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: add retimers, dp altmode support To: Shawn Guo , jens.glathe@oldschoolsolutions.biz, Abel Vesa Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Clark , Jos Dehaes References: <20250417-slim7x-retimer-v2-1-dbe2dd511137@oldschoolsolutions.biz> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 25/12/2025 04:29, Shawn Guo wrote: > On Fri, Apr 18, 2025 at 12:35 AM Jens Glathe via B4 Relay > wrote: >> >> From: Jens Glathe >> >> comparing with CRD and other dts for a more complete support of the 7X >> only retimers, gpios, regulators, dp outputs >> >> Tested-by: Rob Clark >> Tested-by: Jos Dehaes >> Signed-off-by: Jens Glathe >> --- >> This patch adds the required nodes to support DP Altmode on all three type-c >> ports. The definition is derived from the CRD. Since they are all marked 40Gbps, >> I assume there are 3 PS8830 retimers. >> This modification is now for ~8 weeks in my tree with little to no complaints. I >> don't have access to a Yoga Slim 7X, however many people on #aarch64-laptops do >> and some are using this patch. >> --- >> Changes in v2: >> - removed changes not relevant to retimers and dp altmode (thanks Johan) >> - Link to v1: https://lore.kernel.org/r/20250417-slim7x-retimer-v1-1-5813a7835903@oldschoolsolutions.biz >> --- >> .../boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 476 ++++++++++++++++++++- >> 1 file changed, 470 insertions(+), 6 deletions(-) > > Hi, > > I'm running a Slim7x China variant (Yoga Air 14s) with Debian 13. > While the Debian stock 6.12 kernel works fine to bring up the display > (AMOLED eDP panel), newer kernels like 6.18 loses display during boot. > I can do either of the following to get the display back to work. > > - Enable PS883X driver (Yes, CONFIG_TYPEC_MUX_PS883X is missing from > Debian config [1]) Obviously. > > OR > > - Revert commit 299038d82418 ("arm64: dts: qcom: > x1e80100-lenovo-yoga-slim7x: add retimers, dp altmode support") > > My understanding is that a PS883X driver is required only for external > DP support. Why would the driver missing impact/break the internal > panel support? Do you guys have any insight on this? Thanks! > You need all drivers to avoid probe deferrals. Best regards, Krzysztof